Re: [PATCH v4 0/6] Add strace support for printing arguments of selected syscalls

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20200616103927.20222-1-filip.bozuta@syrmia.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v4 0/6] Add strace support for printing arguments of selected syscalls
Type: series
Message-id: 20200616103927.20222-1-filip.bozuta@syrmia.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
756604e linux-user: Add strace support for printing arguments of fallocate()
25680d5 linux-user: Add strace support for printing arguments of chown()/lchown()
cadd65d linux-user: Add strace support for printing arguments of lseek()
eb40627 linux-user: Add strace support for printing argument of syscalls used for extended attributes
47226e8 linux-user: Add strace support for a group of syscalls
3e531d0 linux-user: Extend strace support to enable argument printing after syscall execution

=== OUTPUT BEGIN ===
1/6 Checking commit 3e531d0470d2 (linux-user: Extend strace support to enable argument printing after syscall execution)
2/6 Checking commit 47226e8674a7 (linux-user: Add strace support for a group of syscalls)
3/6 Checking commit eb40627b1196 (linux-user: Add strace support for printing argument of syscalls used for extended attributes)
4/6 Checking commit cadd65d9f866 (linux-user: Add strace support for printing arguments of lseek())
5/6 Checking commit 25680d5e1b01 (linux-user: Add strace support for printing arguments of chown()/lchown())
6/6 Checking commit 756604eefe06 (linux-user: Add strace support for printing arguments of fallocate())
ERROR: storage class should be at the beginning of the declaration
#69: FILE: linux-user/strace.c:1146:
+UNUSED static struct flags falloc_flags[] = {

total: 1 errors, 0 warnings, 104 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200616103927.20222-1-filip.bozuta@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com