From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32B2C433DF for ; Fri, 19 Jun 2020 08:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBDA620776 for ; Fri, 19 Jun 2020 08:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="czFUd1Jf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731501AbgFSIdQ (ORCPT ); Fri, 19 Jun 2020 04:33:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731206AbgFSIdJ (ORCPT ); Fri, 19 Jun 2020 04:33:09 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EA15C06174E for ; Fri, 19 Jun 2020 01:33:07 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id p3so1514591pgh.3 for ; Fri, 19 Jun 2020 01:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=DxLF1QSYdlhCh6NZL9lmn8uNXMfSoRVrgwAtr7oZT4g=; b=czFUd1Jfcxsr/gudLfab9c+CCTq3xnDtsEMHFd3r480lJ4fgsRGvMZQDDhTIPFxXrX cIxDj30f/Wk7M/+djM0hRt7UZ8DA0X5MD7qP6m6ddEKjqhzxGWuzCBV95HWA5BN+SbF2 CuTiI6mPAfQUJoVB8yd+LKok9tIbAJj/vpMUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=DxLF1QSYdlhCh6NZL9lmn8uNXMfSoRVrgwAtr7oZT4g=; b=b/uvGWSgnogaxAQVMSt72H8leuEb6GGJjfgTywq+JNuTtqrScpYOa24ZoxnwOrtSMU LARw7ofMZqENahfFtf1ENiOZAzZY+tWmqsvfz5bzUHoNxpqd+Ibbw0994q6A99MSuwxM HaRT9S7FRFWvHS4mCqpNcffOOZL5C4506nc2HKoXvui2gq4JscC/0jMItUc4KquhtvdV IQVvLG8sbV3eDL4npLPhitL0yEGOQbqj4vTyal+wndty7lSR3h3zJgbgodzuiQHS1ETT UyMAQTznZ4SMISEnMKNDUKVGwmXGMAg9R6JIQES0+lBCanaG32ZUb+MQv3YHwQjtrooc O5bQ== X-Gm-Message-State: AOAM532m69gfEUU8GcpMgrGJS/jkBX059/+rKszWla6hXMbwrKbx0pvb qYJpYIB+QiKXcivKTtAgdZKHKA== X-Google-Smtp-Source: ABdhPJxh9NkKuR5QgKNed2psurq5OoIwxIxtvYn54t0bYKHdssnhTLFQ5n/2YwUBvXXcSHO6doPqJg== X-Received: by 2002:aa7:9acc:: with SMTP id x12mr7140195pfp.24.1592555586085; Fri, 19 Jun 2020 01:33:06 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id a7sm4578348pjd.2.2020.06.19.01.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 01:33:05 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <8db25400-5a01-18f6-d362-af3ad229361a@arm.com> References: <20200617113851.607706-1-alexandru.elisei@arm.com> <20200617113851.607706-7-alexandru.elisei@arm.com> <159242539231.62212.11549121838391298623@swboyd.mtv.corp.google.com> <8db25400-5a01-18f6-d362-af3ad229361a@arm.com> Subject: Re: [PATCH v5 6/7] arm_pmu: Introduce pmu_irq_ops From: Stephen Boyd Cc: mark.rutland@arm.com, Julien Thierry , maz@kernel.org, Will Deacon , catalin.marinas@arm.com, will@kernel.org, Julien Thierry To: Alexandru Elisei , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 19 Jun 2020 01:33:04 -0700 Message-ID: <159255558463.62212.4785740630471861314@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Alexandru Elisei (2020-06-18 03:51:24) > Hi, >=20 > On 6/17/20 9:23 PM, Stephen Boyd wrote: > > Quoting Alexandru Elisei (2020-06-17 04:38:50) > >> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > >> index df352b334ea7..17e5952d21e4 100644 > >> --- a/drivers/perf/arm_pmu.c > >> +++ b/drivers/perf/arm_pmu.c > >> @@ -26,8 +26,46 @@ > >> =20 > >> #include > >> =20 > >> +static int armpmu_count_irq_users(const int irq); > >> + > >> +struct pmu_irq_ops { > >> + void (*enable_pmuirq)(unsigned int irq); > >> + void (*disable_pmuirq)(unsigned int irq); > >> + void (*free_pmuirq)(unsigned int irq, int cpu, void __percpu *= devid); > > Does 'cpu' need to be signed? >=20 > I'm not sure what you mean. The cpu argument comes from > drivers/perf/arm_pmu_platform.c::armpmu_free_irqs -> arpmu_free_irq, wher= e is the > iterator variable used by the macro for_each_cpu. The documentation for t= he macro > states: >=20 > /** > * for_each_cpu - iterate over every cpu in a mask > * @cpu: the (optionally unsigned) integer iterator ^^^^^^^^^^^^^^^^^^^ >=20 > I could write a patch to convert to an unsigned int, but it seems like un= necessary > churn to me. Ok. It would be nice to make it unsigned in the arm_pmu_platform.c file. Not required for this patch series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52194C433DF for ; Fri, 19 Jun 2020 08:33:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FD8120890 for ; Fri, 19 Jun 2020 08:33:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FXKOP5CF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="czFUd1Jf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FD8120890 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LlFAr0nHFDrxlwKgSzsAn1e6hJQNplsHWiQXbwK7Ya8=; b=FXKOP5CFXraoj1 vuJTpOLAbFvyRJFcQQRSaAHO2gnH3+IUi5qlCgtNN2bkqt0OmlkgpBuDU+dcx9CJUyR2cVjJd4GzF Gp3mHksr6KcG2a/krJY+e1aNlMRAf/PK28D475Y9wj1/fJ5lGx2EoIvOdA3RLQp7mhPdGMZx702L9 ZjhE7ygsmAWIjb1/buInJGD2brL1lrnSJozs+rFLRgXVuKPCasVFnqoLYDG99Wr9n+zlFVZUmFEhX A/IiShMgHXht+uaOoo8StWIXKORCi1djR4csy8+zHvMT+1PCjprS+pZUvQ+qZKcZTYVwICDTo08h2 gNS0biWLparaE2XrrybA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jmCST-0005Xj-Lg; Fri, 19 Jun 2020 08:33:09 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jmCSQ-0005Wt-MU for linux-arm-kernel@lists.infradead.org; Fri, 19 Jun 2020 08:33:07 +0000 Received: by mail-pg1-x544.google.com with SMTP id q22so1355528pgk.2 for ; Fri, 19 Jun 2020 01:33:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=DxLF1QSYdlhCh6NZL9lmn8uNXMfSoRVrgwAtr7oZT4g=; b=czFUd1Jfcxsr/gudLfab9c+CCTq3xnDtsEMHFd3r480lJ4fgsRGvMZQDDhTIPFxXrX cIxDj30f/Wk7M/+djM0hRt7UZ8DA0X5MD7qP6m6ddEKjqhzxGWuzCBV95HWA5BN+SbF2 CuTiI6mPAfQUJoVB8yd+LKok9tIbAJj/vpMUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=DxLF1QSYdlhCh6NZL9lmn8uNXMfSoRVrgwAtr7oZT4g=; b=ZMgEKmrUAdkWLuqtdlT5RK/lLw46VYsxLCNM82fu2KQF/nVWJBK8ZCOB/0KzCe+N1s l4j57wGkMIFRI1HKWUwXWqnqQrOA90o0m/J5GxMreDkiLfyPTthMZVY/GhoLq7gzRz8I yLxt4YRPck0woZXYUcFH4G5dPRqKVDGifA8P/I8vpheSUqMx8bvtmA6VHrh9tha81xWo JnEdnfrOtHBwvBrYBTg9geuWN4/7bJ5rQeX3wfMsgBj4bYID+kDP9l1PFKWFuJn+dUqK jJ124bRTozUW3e9RlLRURLo+/IuBmlFPPVR3xei2gwlqNH7nHv0/F0wlQpCq7/GT+BO8 UGZQ== X-Gm-Message-State: AOAM533ypaB9TSaaQ54Zq3vXJ/MxOD0lmlwKLPjtXZRR40ia6mz3uJAt GxkFdEBsQ8Sd4LYESCeBWF5NQuensbU= X-Google-Smtp-Source: ABdhPJxh9NkKuR5QgKNed2psurq5OoIwxIxtvYn54t0bYKHdssnhTLFQ5n/2YwUBvXXcSHO6doPqJg== X-Received: by 2002:aa7:9acc:: with SMTP id x12mr7140195pfp.24.1592555586085; Fri, 19 Jun 2020 01:33:06 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id a7sm4578348pjd.2.2020.06.19.01.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 01:33:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <8db25400-5a01-18f6-d362-af3ad229361a@arm.com> References: <20200617113851.607706-1-alexandru.elisei@arm.com> <20200617113851.607706-7-alexandru.elisei@arm.com> <159242539231.62212.11549121838391298623@swboyd.mtv.corp.google.com> <8db25400-5a01-18f6-d362-af3ad229361a@arm.com> Subject: Re: [PATCH v5 6/7] arm_pmu: Introduce pmu_irq_ops From: Stephen Boyd To: Alexandru Elisei , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 19 Jun 2020 01:33:04 -0700 Message-ID: <159255558463.62212.4785740630471861314@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200619_013306_737214_0AA36A9F X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Julien Thierry , maz@kernel.org, Will Deacon , catalin.marinas@arm.com, will@kernel.org, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Alexandru Elisei (2020-06-18 03:51:24) > Hi, > > On 6/17/20 9:23 PM, Stephen Boyd wrote: > > Quoting Alexandru Elisei (2020-06-17 04:38:50) > >> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > >> index df352b334ea7..17e5952d21e4 100644 > >> --- a/drivers/perf/arm_pmu.c > >> +++ b/drivers/perf/arm_pmu.c > >> @@ -26,8 +26,46 @@ > >> > >> #include > >> > >> +static int armpmu_count_irq_users(const int irq); > >> + > >> +struct pmu_irq_ops { > >> + void (*enable_pmuirq)(unsigned int irq); > >> + void (*disable_pmuirq)(unsigned int irq); > >> + void (*free_pmuirq)(unsigned int irq, int cpu, void __percpu *devid); > > Does 'cpu' need to be signed? > > I'm not sure what you mean. The cpu argument comes from > drivers/perf/arm_pmu_platform.c::armpmu_free_irqs -> arpmu_free_irq, where is the > iterator variable used by the macro for_each_cpu. The documentation for the macro > states: > > /** > * for_each_cpu - iterate over every cpu in a mask > * @cpu: the (optionally unsigned) integer iterator ^^^^^^^^^^^^^^^^^^^ > > I could write a patch to convert to an unsigned int, but it seems like unnecessary > churn to me. Ok. It would be nice to make it unsigned in the arm_pmu_platform.c file. Not required for this patch series. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel