From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF505C433E0 for ; Tue, 23 Jun 2020 15:07:49 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EAC320774 for ; Tue, 23 Jun 2020 15:07:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="d8O5XRVN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EAC320774 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 69CF688EE6; Tue, 23 Jun 2020 15:07:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OPDc4CCFG0xB; Tue, 23 Jun 2020 15:07:45 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id DEBE788E78; Tue, 23 Jun 2020 15:07:44 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 438121BF3ED for ; Tue, 23 Jun 2020 15:07:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4057588E4E for ; Tue, 23 Jun 2020 15:07:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Az6NDkOSy21 for ; Tue, 23 Jun 2020 15:07:42 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from esa6.microchip.iphmx.com (esa6.microchip.iphmx.com [216.71.154.253]) by whitealder.osuosl.org (Postfix) with ESMTPS id F26B988280 for ; Tue, 23 Jun 2020 15:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1592924862; x=1624460862; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=A9mZ5as9dfLi7G9P4TKKSuHiJVe1VR6N0+BRbhPT0t0=; b=d8O5XRVNuGUtvFnkphPeUys41ZHD55aNkFkUXUs359jTGhCUko1Ga31K FgsBeKnJN4UyTq6Exmg5+3q8Qq7d99eEO0L2Ysi6rQ6fjFUP8rAReJcgR vsIbogLAEpH66rGrwx1CwlnlumAmOUvDJyrr8cQGYH68abxJqxIKEb/jZ /H8hOwsfFUZgM37xsgPwICHg3Q0NdFP55ijNwo2okPg2z43cLW2mwyDbN 6l3cty8GhuLZM3Y2hnC3s7c58NxCMkCnmqrNpchWC8+l2+cnDybaKMyby 9MBXxUt//Idn8kDHHDVAfno6J0XFOodkkYrLbAVP+zJ27fAQ32F7lVAcU A==; IronPort-SDR: T0mSFFDy1SskWyHRbmLNmbJKPxHGzXP/HGAl6Fa4dcHPUPDcqONXaArt7zwMjw8qgAKJoIm2rM FCXrPgFUSmtlEcjB4sriIEYLbUUENmq4Ih+vtRUhCTQ+aGXJ08gOlUCBQJe9mRcnGNV1Ef/9PS td046BJhHKb/vwl8J2IEtTbtdTduhMagJEyj+p8H+InDb3x+Csx9JXZKVcU6GLwYojXe79kUnK fXcttuZSWanWAXWRsX37N9O591z4eNWK4/HR1RO4+EAfDJtPj5MMcmJ8gq/7Fn05MldbenGCHR 2fk= X-IronPort-AV: E=Sophos;i="5.75,271,1589266800"; d="scan'208";a="16763287" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 23 Jun 2020 08:07:41 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Tue, 23 Jun 2020 08:07:29 -0700 Received: from kar-sv-agl01.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Tue, 23 Jun 2020 08:07:39 -0700 From: Christian Gromm To: Subject: [PATCH 2/5] staging: most: sound: fix error path Date: Tue, 23 Jun 2020 17:07:32 +0200 Message-ID: <1592924855-25569-3-git-send-email-christian.gromm@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1592924855-25569-1-git-send-email-christian.gromm@microchip.com> References: <1592924855-25569-1-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Gromm , driverdev-devel@linuxdriverproject.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Return error and exit the function in case registering the component with the core is failing. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/sound/sound.c b/drivers/staging/most/sound/sound.c index e6396d1..80a8feb 100644 --- a/drivers/staging/most/sound/sound.c +++ b/drivers/staging/most/sound/sound.c @@ -742,8 +742,10 @@ static int __init audio_init(void) INIT_LIST_HEAD(&adpt_list); ret = most_register_component(&comp); - if (ret) + if (ret) { pr_err("Failed to register %s\n", comp.name); + return ret; + } ret = most_register_configfs_subsys(&comp); if (ret) { pr_err("Failed to register %s configfs subsys\n", comp.name); -- 2.7.4 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel