All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: [PATCH v3 01/14 RESEND] irqchip/ath79-misc: Fix potential resource leaks
Date: Wed, 24 Jun 2020 15:44:58 +0800	[thread overview]
Message-ID: <1592984711-3130-2-git-send-email-yangtiezhu@loongson.cn> (raw)
In-Reply-To: <1592984711-3130-1-git-send-email-yangtiezhu@loongson.cn>

There exists potential resource leaks in the error path, fix them.

Fixes: 07ba4b061a79 ("irqchip/ath79-misc: Move the MISC driver from arch/mips/ath79/")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 drivers/irqchip/irq-ath79-misc.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-ath79-misc.c b/drivers/irqchip/irq-ath79-misc.c
index 3d641bb..53e0c50 100644
--- a/drivers/irqchip/irq-ath79-misc.c
+++ b/drivers/irqchip/irq-ath79-misc.c
@@ -133,7 +133,7 @@ static int __init ath79_misc_intc_of_init(
 {
 	struct irq_domain *domain;
 	void __iomem *base;
-	int irq;
+	int irq, ret;
 
 	irq = irq_of_parse_and_map(node, 0);
 	if (!irq) {
@@ -144,18 +144,26 @@ static int __init ath79_misc_intc_of_init(
 	base = of_iomap(node, 0);
 	if (!base) {
 		pr_err("Failed to get MISC IRQ registers\n");
-		return -ENOMEM;
+		ret = -ENOMEM;
+		goto err_irq_dispose;
 	}
 
 	domain = irq_domain_add_linear(node, ATH79_MISC_IRQ_COUNT,
 				&misc_irq_domain_ops, base);
 	if (!domain) {
 		pr_err("Failed to add MISC irqdomain\n");
-		return -EINVAL;
+		ret = -EINVAL;
+		goto err_iounmap;
 	}
 
 	ath79_misc_intc_domain_init(domain, irq);
 	return 0;
+
+err_iounmap:
+	iounmap(base);
+err_irq_dispose:
+	irq_dispose_mapping(irq);
+	return ret;
 }
 
 static int __init ar7100_misc_intc_of_init(
-- 
2.1.0


  reply	other threads:[~2020-06-24  7:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  7:44 [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Tiezhu Yang
2020-06-24  7:44 ` Tiezhu Yang [this message]
2020-06-24  7:44 ` [PATCH v3 02/14 RESEND] irqchip/csky-apb-intc: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 03/14 RESEND] irqchip/csky-mpintc: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 04/14 RESEND] irqchip/davinci-aintc: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 05/14 RESEND] irqchip/davinci-cp-intc: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 06/14 RESEND] irqchip/digicolor: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 07/14 RESEND] irqchip/dw-apb-ictl: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 08/14 RESEND] irqchip/ls1x: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 09/14 RESEND] irqchip/mscc-ocelot: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 10/14 RESEND] irqchip/nvic: " Tiezhu Yang
2020-06-24  7:45 ` [PATCH v3 11/14 RESEND] irqchip/omap-intc: Fix potential resource leak Tiezhu Yang
2020-06-24  8:30 ` [PATCH v3 00/14 RESEND] irqchip: Fix potential resource leaks Marc Zyngier
2020-06-24  9:02   ` Tiezhu Yang
2020-06-24 11:48     ` Tiezhu Yang
2020-06-24 11:52       ` Marc Zyngier
2020-06-28 11:25   ` Aleksandar Markovic
2020-06-28 12:06     ` Marc Zyngier
2020-06-28 12:48       ` Aleksandar Markovic
2020-06-28 16:55         ` Marc Zyngier
2020-06-28 17:00           ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1592984711-3130-2-git-send-email-yangtiezhu@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.