Re: [PATCH] trivial: Remove trailing whitespaces

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20200706162300.1084753-1-dinechin@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] trivial: Remove trailing whitespaces
Type: series
Message-id: 20200706162300.1084753-1-dinechin@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200706162300.1084753-1-dinechin@redhat.com -> patchew/20200706162300.1084753-1-dinechin@redhat.com
Switched to a new branch 'test'
9af3e90 trivial: Remove trailing whitespaces

=== OUTPUT BEGIN ===
WARNING: line over 80 characters
#121: FILE: disas/microblaze.c:112:
+   fcmp_lt, fcmp_eq, fcmp_le, fcmp_gt, fcmp_ne, fcmp_ge, fcmp_un, flt, fint, fsqrt,

ERROR: line over 90 characters
#148: FILE: disas/microblaze.c:280:
+  unsigned long bit_sequence; /* all the fixed bits for the op are set and all the variable bits (reg names, imm vals) are set to 0 */

ERROR: space prohibited between function name and open parenthesis '('
#289: FILE: disas/microblaze.c:728:
+read_insn_microblaze (bfd_vma memaddr,

ERROR: suspect code indent for conditional statements (2, 6)
#298: FILE: disas/microblaze.c:739:
+  if (status != 0)
     {

ERROR: code indent should never use tabs
#334: FILE: disas/microblaze.c:854:
+^I  /* The non-pc relative instructions are returns, which shouldn't$

WARNING: Block comments use a leading /* on a separate line
#334: FILE: disas/microblaze.c:854:
+         /* The non-pc relative instructions are returns, which shouldn't

ERROR: code indent should never use tabs
#343: FILE: disas/microblaze.c:889:
+^I    }$

WARNING: Block comments use a leading /* on a separate line
#365: FILE: disas/nios2.c:99:
+/* This structure holds information for a particular instruction.

ERROR: code indent should never use tabs
#374: FILE: disas/nios2.c:155:
+  const char *args;^I^I/* A string describing the arguments for this$

WARNING: Block comments use a leading /* on a separate line
#374: FILE: disas/nios2.c:155:
+  const char *args;            /* A string describing the arguments for this

ERROR: code indent should never use tabs
#377: FILE: disas/nios2.c:157:
+  const char *args_test;^I/* Like args, but with an extra argument for$

WARNING: Block comments use a leading /* on a separate line
#377: FILE: disas/nios2.c:157:
+  const char *args_test;       /* Like args, but with an extra argument for

ERROR: code indent should never use tabs
#380: FILE: disas/nios2.c:159:
+  unsigned long num_args;^I/* The number of arguments the instruction$

WARNING: Block comments use a leading /* on a separate line
#380: FILE: disas/nios2.c:159:
+  unsigned long num_args;      /* The number of arguments the instruction

ERROR: code indent should never use tabs
#386: FILE: disas/nios2.c:164:
+  unsigned long mask;^I^I/* Mask for the opcode field of the$

WARNING: Block comments use a leading /* on a separate line
#386: FILE: disas/nios2.c:164:
+  unsigned long mask;          /* Mask for the opcode field of the

ERROR: code indent should never use tabs
#389: FILE: disas/nios2.c:166:
+  unsigned long pinfo;^I^I/* Is this a real instruction or instruction$

WARNING: Block comments use a leading /* on a separate line
#389: FILE: disas/nios2.c:166:
+  unsigned long pinfo;         /* Is this a real instruction or instruction

WARNING: Block comments use a leading /* on a separate line
#392: FILE: disas/nios2.c:168:
+  enum overflow_type overflow_msg;  /* Used to generate informative

WARNING: Block comments use a leading /* on a separate line
#399: FILE: disas/nios2.c:172:
+/* This value is used in the nios2_opcode.pinfo field to indicate that the

WARNING: Block comments use * on subsequent lines
#400: FILE: disas/nios2.c:173:
+/* This value is used in the nios2_opcode.pinfo field to indicate that the
+   instruction is a macro or pseudo-op.  This requires special treatment by

WARNING: line over 80 characters
#549: FILE: disas/nios2.c:284:
+#define GET_IW_CUSTOM_A(W) (((W) >> IW_CUSTOM_A_LSB) & IW_CUSTOM_A_UNSHIFTED_MASK)

WARNING: line over 80 characters
#550: FILE: disas/nios2.c:285:
+#define SET_IW_CUSTOM_A(V) (((V) & IW_CUSTOM_A_UNSHIFTED_MASK) << IW_CUSTOM_A_LSB)

WARNING: line over 80 characters
#562: FILE: disas/nios2.c:291:
+#define GET_IW_CUSTOM_B(W) (((W) >> IW_CUSTOM_B_LSB) & IW_CUSTOM_B_UNSHIFTED_MASK)

WARNING: line over 80 characters
#563: FILE: disas/nios2.c:292:
+#define SET_IW_CUSTOM_B(V) (((V) & IW_CUSTOM_B_UNSHIFTED_MASK) << IW_CUSTOM_B_LSB)

WARNING: line over 80 characters
#575: FILE: disas/nios2.c:298:
+#define GET_IW_CUSTOM_C(W) (((W) >> IW_CUSTOM_C_LSB) & IW_CUSTOM_C_UNSHIFTED_MASK)

WARNING: line over 80 characters
#576: FILE: disas/nios2.c:299:
+#define SET_IW_CUSTOM_C(V) (((V) & IW_CUSTOM_C_UNSHIFTED_MASK) << IW_CUSTOM_C_LSB)

WARNING: line over 80 characters
#586: FILE: disas/nios2.c:303:
+#define IW_CUSTOM_READA_UNSHIFTED_MASK (0xffffffffu >> (32 - IW_CUSTOM_READA_SIZE))

ERROR: line over 90 characters
#587: FILE: disas/nios2.c:304:
+#define IW_CUSTOM_READA_SHIFTED_MASK (IW_CUSTOM_READA_UNSHIFTED_MASK << IW_CUSTOM_READA_LSB)

ERROR: line over 90 characters
#588: FILE: disas/nios2.c:305:
+#define GET_IW_CUSTOM_READA(W) (((W) >> IW_CUSTOM_READA_LSB) & IW_CUSTOM_READA_UNSHIFTED_MASK)

ERROR: line over 90 characters
#589: FILE: disas/nios2.c:306:
+#define SET_IW_CUSTOM_READA(V) (((V) & IW_CUSTOM_READA_UNSHIFTED_MASK) << IW_CUSTOM_READA_LSB)

WARNING: line over 80 characters
#599: FILE: disas/nios2.c:310:
+#define IW_CUSTOM_READB_UNSHIFTED_MASK (0xffffffffu >> (32 - IW_CUSTOM_READB_SIZE))

ERROR: line over 90 characters
#600: FILE: disas/nios2.c:311:
+#define IW_CUSTOM_READB_SHIFTED_MASK (IW_CUSTOM_READB_UNSHIFTED_MASK << IW_CUSTOM_READB_LSB)

ERROR: line over 90 characters
#601: FILE: disas/nios2.c:312:
+#define GET_IW_CUSTOM_READB(W) (((W) >> IW_CUSTOM_READB_LSB) & IW_CUSTOM_READB_UNSHIFTED_MASK)

ERROR: line over 90 characters
#602: FILE: disas/nios2.c:313:
+#define SET_IW_CUSTOM_READB(V) (((V) & IW_CUSTOM_READB_UNSHIFTED_MASK) << IW_CUSTOM_READB_LSB)

WARNING: line over 80 characters
#612: FILE: disas/nios2.c:317:
+#define IW_CUSTOM_READC_UNSHIFTED_MASK (0xffffffffu >> (32 - IW_CUSTOM_READC_SIZE))

ERROR: line over 90 characters
#613: FILE: disas/nios2.c:318:
+#define IW_CUSTOM_READC_SHIFTED_MASK (IW_CUSTOM_READC_UNSHIFTED_MASK << IW_CUSTOM_READC_LSB)

ERROR: line over 90 characters
#614: FILE: disas/nios2.c:319:
+#define GET_IW_CUSTOM_READC(W) (((W) >> IW_CUSTOM_READC_LSB) & IW_CUSTOM_READC_UNSHIFTED_MASK)

ERROR: line over 90 characters
#615: FILE: disas/nios2.c:320:
+#define SET_IW_CUSTOM_READC(V) (((V) & IW_CUSTOM_READC_UNSHIFTED_MASK) << IW_CUSTOM_READC_LSB)

WARNING: line over 80 characters
#627: FILE: disas/nios2.c:326:
+#define GET_IW_CUSTOM_N(W) (((W) >> IW_CUSTOM_N_LSB) & IW_CUSTOM_N_UNSHIFTED_MASK)

WARNING: line over 80 characters
#628: FILE: disas/nios2.c:327:
+#define SET_IW_CUSTOM_N(V) (((V) & IW_CUSTOM_N_UNSHIFTED_MASK) << IW_CUSTOM_N_LSB)

WARNING: Block comments use a leading /* on a separate line
#716: FILE: hw/arm/stellaris.c:982:
+    /* TODO: Real hardware has limited size FIFOs.  We have a full 16 entry

WARNING: Block comments use a leading /* on a separate line
#742: FILE: hw/core/ptimer.c:249:
+                /* Look at remaining bits of period_frac and round div up if

WARNING: Block comments use a leading /* on a separate line
#755: FILE: hw/cris/axis_dev88.c:270:
+    /* The ETRAX-FS has 128Kb on chip ram, the docs refer to it as the

WARNING: Block comments use a leading /* on a separate line
#768: FILE: hw/cris/boot.c:75:
+    /* Boots a kernel elf binary, os/linux-2.6/vmlinux from the axis

ERROR: do not use C99 // comments
#781: FILE: hw/display/qxl.c:54:
+#define PIXEL_SIZE 0.2936875 //1280x1024 is 14.8" x 11.9"

ERROR: code indent should never use tabs
#794: FILE: hw/dma/etraxfs_dma.c:325:
+^Iif (!channel_en(ctrl, c)$

WARNING: line over 80 characters
#800: FILE: hw/dma/etraxfs_dma.c:330:
+               D(printf("continue failed ch=%d state=%d stopped=%d en=%d eol=%d\n",

ERROR: code indent should never use tabs
#800: FILE: hw/dma/etraxfs_dma.c:330:
+^I^ID(printf("continue failed ch=%d state=%d stopped=%d en=%d eol=%d\n",$

ERROR: code indent should never use tabs
#809: FILE: hw/dma/etraxfs_dma.c:386:
+^ID(printf("%s: chan=%d masked_intr=%x\n", __func__,$

ERROR: code indent should never use tabs
#827: FILE: hw/dma/etraxfs_dma.c:520:
+^I^ID(printf("in dscr end len=%d\n",$

ERROR: code indent should never use tabs
#836: FILE: hw/dma/etraxfs_dma.c:711:
+^Ifor (i = 0;$

ERROR: code indent should never use tabs
#849: FILE: hw/dma/etraxfs_dma.c:730:
+^Ireturn channel_in_process(client->ctrl, client->channel,$

ERROR: code indent should never use tabs
#973: FILE: hw/intc/sh_intc.c:276:
+^Iprintf("k = %d, first = %d, enum = %d, mask = 0x%08x\n",$

WARNING: Block comments use a leading /* on a separate line
#991: FILE: hw/intc/sh_intc.c:501:
+/* Assert level <n> IRL interrupt.

ERROR: code indent should never use tabs
#1169: FILE: hw/usb/hcd-musb.c:36:
+#define MUSB_HDRC_INTRTXE^I0x06$

ERROR: code indent should never use tabs
#1170: FILE: hw/usb/hcd-musb.c:37:
+#define MUSB_HDRC_INTRRXE^I0x08$

ERROR: code indent should never use tabs
#1179: FILE: hw/usb/hcd-musb.c:116:
+#define MGC_M_POWER_ISOUPDATE^I^I0x80$

ERROR: code indent should never use tabs
#1188: FILE: hw/usb/hcd-musb.c:130:
+#define MGC_M_INTR_SOF^I^I^I0x08$

ERROR: code indent should never use tabs
#1197: FILE: hw/usb/hcd-musb.c:138:
+#define MGC_M_DEVCTL_BDEVICE^I^I0x80$

ERROR: suspect code indent for conditional statements (7, 11)
#1510: FILE: linux-user/mmap.c:423:
        if (offset + len > sb.st_size) {
+           /* If so, truncate the file map at eof aligned with

WARNING: Block comments use a leading /* on a separate line
#1512: FILE: linux-user/mmap.c:424:
+           /* If so, truncate the file map at eof aligned with

ERROR: space prohibited between function name and open parenthesis '('
#1593: FILE: linux-user/syscall.c:1620:
+    if (msg_controllen < sizeof (struct target_cmsghdr))

ERROR: braces {} are necessary for all arms of this statement
#1593: FILE: linux-user/syscall.c:1620:
+    if (msg_controllen < sizeof (struct target_cmsghdr))
[...]

ERROR: space prohibited between function name and open parenthesis '('
#1602: FILE: linux-user/syscall.c:1706:
+    if (msg_controllen < sizeof (struct target_cmsghdr))

ERROR: braces {} are necessary for all arms of this statement
#1602: FILE: linux-user/syscall.c:1706:
+    if (msg_controllen < sizeof (struct target_cmsghdr))
[...]

ERROR: suspect code indent for conditional statements (4, 11)
#1611: FILE: linux-user/syscall.c:5753:
+    if (ldt_info.entry_number < TARGET_GDT_ENTRY_TLS_MIN ||
[...]
            return -TARGET_EINVAL;

ERROR: do not use assignment in if condition
#1640: FILE: linux-user/syscall.c:10876:
+        if (!(p = lock_user_string(arg2)))

ERROR: braces {} are necessary for all arms of this statement
#1640: FILE: linux-user/syscall.c:10876:
+        if (!(p = lock_user_string(arg2)))
[...]

ERROR: code indent should never use tabs
#1653: FILE: linux-user/syscall_defs.h:1926:
+^Iabi_ulong ^Itarget_st_atime_nsec;$

ERROR: space prohibited between function name and open parenthesis '('
#1860: FILE: target/cris/translate.c:1071:
+static void cris_prepare_cc_branch (DisasContext *dc,

ERROR: do not use C99 // comments
#2163: FILE: target/i386/hvf/x86_task.c:4:
+//

ERROR: trailing whitespace
#2395: FILE: target/sh4/op_helper.c:149:
+^I$

ERROR: code indent should never use tabs
#2395: FILE: target/sh4/op_helper.c:149:
+^I$

ERROR: code indent should never use tabs
#2414: FILE: target/xtensa/core-de212/core-isa.h:608:
+#define XCHAL_HAVE_MPU^I^I^I0$

ERROR: code indent should never use tabs
#2439: FILE: target/xtensa/core-sample_controller/core-isa.h:629:
+#define XCHAL_HAVE_MPU^I^I^I0$

ERROR: braces {} are necessary for all arms of this statement
#2491: FILE: tcg/tcg.c:896:
+                if (s->pool_current)
[...]
                 else
[...]

WARNING: Block comments use a leading /* on a separate line
#2537: FILE: tcg/tcg.c:3716:
+            /* allocate a new register matching the constraint

ERROR: code indent should never use tabs
#2630: FILE: tests/tcg/multiarch/test-mmap.c:66:
+^I^Ip1 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2633: FILE: tests/tcg/multiarch/test-mmap.c:68:
+^I^Ip2 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2636: FILE: tests/tcg/multiarch/test-mmap.c:70:
+^I^Ip3 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2639: FILE: tests/tcg/multiarch/test-mmap.c:72:
+^I^Ip4 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2642: FILE: tests/tcg/multiarch/test-mmap.c:74:
+^I^Ip5 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2651: FILE: tests/tcg/multiarch/test-mmap.c:121:
+^Ip1 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2660: FILE: tests/tcg/multiarch/test-mmap.c:148:
+^I^Ip1 = mmap(NULL, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2668: FILE: tests/tcg/multiarch/test-mmap.c:155:
+^I^Ip2 = mmap(NULL, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2677: FILE: tests/tcg/multiarch/test-mmap.c:165:
+^I^Ip3 = mmap(NULL, nlen, PROT_READ,$

ERROR: code indent should never use tabs
#2683: FILE: tests/tcg/multiarch/test-mmap.c:170:
+^I^Iif (p3 < p2$

ERROR: code indent should never use tabs
#2692: FILE: tests/tcg/multiarch/test-mmap.c:194:
+^Iaddr = mmap(NULL, pagesize * 40, PROT_READ | PROT_WRITE,$

ERROR: code indent should never use tabs
#2701: FILE: tests/tcg/multiarch/test-mmap.c:203:
+^I^Ip1 = mmap(addr, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2705: FILE: tests/tcg/multiarch/test-mmap.c:206:
+^I^I/* Make sure we get pages aligned with the pagesize.$

WARNING: Block comments use a leading /* on a separate line
#2705: FILE: tests/tcg/multiarch/test-mmap.c:206:
+               /* Make sure we get pages aligned with the pagesize.

ERROR: code indent should never use tabs
#2714: FILE: tests/tcg/multiarch/test-mmap.c:234:
+^I^Ip1 = mmap(addr, pagesize, PROT_READ | PROT_WRITE,$

ERROR: code indent should never use tabs
#2718: FILE: tests/tcg/multiarch/test-mmap.c:237:
+^I^I/* Make sure we get pages aligned with the pagesize.$

WARNING: Block comments use a leading /* on a separate line
#2718: FILE: tests/tcg/multiarch/test-mmap.c:237:
+               /* Make sure we get pages aligned with the pagesize.

ERROR: code indent should never use tabs
#2728: FILE: tests/tcg/multiarch/test-mmap.c:261:
+^I^Ip1 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2729: FILE: tests/tcg/multiarch/test-mmap.c:262:
+^I^I^I  MAP_PRIVATE,$

ERROR: code indent should never use tabs
#2733: FILE: tests/tcg/multiarch/test-mmap.c:264:
+^I^Ip2 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2734: FILE: tests/tcg/multiarch/test-mmap.c:265:
+^I^I^I  MAP_PRIVATE,$

ERROR: code indent should never use tabs
#2738: FILE: tests/tcg/multiarch/test-mmap.c:267:
+^I^Ip3 = mmap(NULL, len, PROT_READ,$

ERROR: code indent should never use tabs
#2739: FILE: tests/tcg/multiarch/test-mmap.c:268:
+^I^I^I  MAP_PRIVATE,$

ERROR: code indent should never use tabs
#2750: FILE: tests/tcg/multiarch/test-mmap.c:310:
+^I^Ip1 = mmap(NULL, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2751: FILE: tests/tcg/multiarch/test-mmap.c:311:
+^I^I^I  MAP_PRIVATE,$

ERROR: code indent should never use tabs
#2752: FILE: tests/tcg/multiarch/test-mmap.c:312:
+^I^I^I  test_fd,$

ERROR: code indent should never use tabs
#2761: FILE: tests/tcg/multiarch/test-mmap.c:342:
+^Iaddr = mmap(NULL, pagesize * 44, PROT_READ,$

ERROR: code indent should never use tabs
#2772: FILE: tests/tcg/multiarch/test-mmap.c:352:
+^I^Ip1 = mmap(addr, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2773: FILE: tests/tcg/multiarch/test-mmap.c:353:
+^I^I^I  MAP_PRIVATE | MAP_FIXED,$

ERROR: code indent should never use tabs
#2774: FILE: tests/tcg/multiarch/test-mmap.c:354:
+^I^I^I  test_fd,$

ERROR: code indent should never use tabs
#2783: FILE: tests/tcg/multiarch/test-mmap.c:384:
+^Iaddr = mmap(NULL, pagesize * 40 * 4, PROT_READ,$

ERROR: code indent should never use tabs
#2792: FILE: tests/tcg/multiarch/test-mmap.c:392:
+^I^Ip1 = mmap(addr, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2796: FILE: tests/tcg/multiarch/test-mmap.c:395:
+^I^Ip2 = mmap(addr + pagesize, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2800: FILE: tests/tcg/multiarch/test-mmap.c:398:
+^I^Ip3 = mmap(addr + pagesize * 2, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2804: FILE: tests/tcg/multiarch/test-mmap.c:401:
+^I^Ip4 = mmap(addr + pagesize * 3, pagesize, PROT_READ,$

ERROR: code indent should never use tabs
#2809: FILE: tests/tcg/multiarch/test-mmap.c:405:
+^I^I/* Make sure we get pages aligned with the pagesize.$

WARNING: Block comments use a leading /* on a separate line
#2809: FILE: tests/tcg/multiarch/test-mmap.c:405:
+               /* Make sure we get pages aligned with the pagesize.

ERROR: code indent should never use tabs
#2818: FILE: tests/tcg/multiarch/test-mmap.c:482:
+^I/* Append a few extra writes to make the file end at non$

WARNING: Block comments use a leading /* on a separate line
#2818: FILE: tests/tcg/multiarch/test-mmap.c:482:
+       /* Append a few extra writes to make the file end at non

total: 83 errors, 34 warnings, 2321 lines checked

Commit 9af3e906bce3 (trivial: Remove trailing whitespaces) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200706162300.1084753-1-dinechin@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com