From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MIME_BASE64_TEXT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF2FC433E0 for ; Thu, 9 Jul 2020 07:09:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A05120720 for ; Thu, 9 Jul 2020 07:09:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UAPYBQ5s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726320AbgGIHJu (ORCPT ); Thu, 9 Jul 2020 03:09:50 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:20654 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726183AbgGIHJu (ORCPT ); Thu, 9 Jul 2020 03:09:50 -0400 X-UUID: 0436a738b37e4c1c8e2c04569d38f0df-20200709 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=KN9hhzoH05uLeemQtJA/oz8qydIgDPv4Z3bmecE5HhY=; b=UAPYBQ5shMTeK3m01pYEwcU3+kokwT2eBJO7UG9yllafqBt3pjL+Gmea8VXejA3JVAmGhXHEAIkgzhUKOVN8DNLj+Y6lytNYM/pTKfnmHBegb8r9LpiFk7iCOF11KKuMv+JT7mJILqqRBnh8Y2iMrpNSE9z2EslPXLHwkqbs4gY=; X-UUID: 0436a738b37e4c1c8e2c04569d38f0df-20200709 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 2115013973; Thu, 09 Jul 2020 15:09:43 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 15:09:43 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 9 Jul 2020 15:09:40 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Felipe Balbi CC: Matthias Brugger , Chunfeng Yun , , , , , Subject: [v3 PATCH] usb: mtu3: remove unnecessary NULL pointer checks Date: Thu, 9 Jul 2020 15:09:01 +0800 Message-ID: <1594278541-24968-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: E0704D007BDFE6557E27D3F2225493E6F51B016FC12D4C256CBF91EF0F07D15E2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org VGhlIGNsYXNzIGRyaXZlciB3aWxsIGVuc3VyZSB0aGUgcGFyYW1ldGVycyBhcmUgbm90IE5VTEwN CnBvaW50ZXJzIGJlZm9yZSBjYWxsIHRoZSBob29rIGZ1bmN0aW9uIG9mIHVzYl9lcF9vcHMsDQpz byBubyBuZWVkIGNoZWNrIHRoZW0gYWdhaW4uDQoNClJlcG9ydGVkLWJ5OiBNYXJrdXMgRWxmcmlu ZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPg0KU2lnbmVkLW9mZi1ieTogQ2h1bmZlbmcgWXVuIDxj aHVuZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KLS0tDQp2MzogcmVtb3ZlIHVubmVjZXNzYXJ5IE5V TEwgcG9pbnRlciBjaGVja3MgYnV0IG5vdCBhZGQgbW9yZSBjaGVja3MuDQoNCnYyOiBub3RoaW5n IGNoYW5nZWQsIGJ1dCBhYmFuZG9uIGFub3RoZXIgcGF0Y2guDQotLS0NCiBkcml2ZXJzL3VzYi9t dHUzL210dTNfZ2FkZ2V0LmMgfCAyNSArKysrKystLS0tLS0tLS0tLS0tLS0tLS0tDQogMSBmaWxl IGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pDQoNCmRpZmYgLS1naXQg YS9kcml2ZXJzL3VzYi9tdHUzL210dTNfZ2FkZ2V0LmMgYi9kcml2ZXJzL3VzYi9tdHUzL210dTNf Z2FkZ2V0LmMNCmluZGV4IGY5MzczMmUuLjZiMjZjYjggMTAwNjQ0DQotLS0gYS9kcml2ZXJzL3Vz Yi9tdHUzL210dTNfZ2FkZ2V0LmMNCisrKyBiL2RyaXZlcnMvdXNiL210dTMvbXR1M19nYWRnZXQu Yw0KQEAgLTI2MywyMyArMjYzLDE1IEBAIHZvaWQgbXR1M19mcmVlX3JlcXVlc3Qoc3RydWN0IHVz Yl9lcCAqZXAsIHN0cnVjdCB1c2JfcmVxdWVzdCAqcmVxKQ0KIHN0YXRpYyBpbnQgbXR1M19nYWRn ZXRfcXVldWUoc3RydWN0IHVzYl9lcCAqZXAsDQogCQlzdHJ1Y3QgdXNiX3JlcXVlc3QgKnJlcSwg Z2ZwX3QgZ2ZwX2ZsYWdzKQ0KIHsNCi0Jc3RydWN0IG10dTNfZXAgKm1lcDsNCi0Jc3RydWN0IG10 dTNfcmVxdWVzdCAqbXJlcTsNCi0Jc3RydWN0IG10dTMgKm10dTsNCisJc3RydWN0IG10dTNfZXAg Km1lcCA9IHRvX210dTNfZXAoZXApOw0KKwlzdHJ1Y3QgbXR1M19yZXF1ZXN0ICptcmVxID0gdG9f bXR1M19yZXF1ZXN0KHJlcSk7DQorCXN0cnVjdCBtdHUzICptdHUgPSBtZXAtPm10dTsNCiAJdW5z aWduZWQgbG9uZyBmbGFnczsNCiAJaW50IHJldCA9IDA7DQogDQotCWlmICghZXAgfHwgIXJlcSkN Ci0JCXJldHVybiAtRUlOVkFMOw0KLQ0KIAlpZiAoIXJlcS0+YnVmKQ0KIAkJcmV0dXJuIC1FTk9E QVRBOw0KIA0KLQltZXAgPSB0b19tdHUzX2VwKGVwKTsNCi0JbXR1ID0gbWVwLT5tdHU7DQotCW1y ZXEgPSB0b19tdHUzX3JlcXVlc3QocmVxKTsNCi0JbXJlcS0+bXR1ID0gbXR1Ow0KLQ0KIAlpZiAo bXJlcS0+bWVwICE9IG1lcCkNCiAJCXJldHVybiAtRUlOVkFMOw0KIA0KQEAgLTMwMyw2ICsyOTUs NyBAQCBzdGF0aWMgaW50IG10dTNfZ2FkZ2V0X3F1ZXVlKHN0cnVjdCB1c2JfZXAgKmVwLA0KIAkJ cmV0dXJuIC1FU0hVVERPV047DQogCX0NCiANCisJbXJlcS0+bXR1ID0gbXR1Ow0KIAltcmVxLT5y ZXF1ZXN0LmFjdHVhbCA9IDA7DQogCW1yZXEtPnJlcXVlc3Quc3RhdHVzID0gLUVJTlBST0dSRVNT Ow0KIA0KQEAgLTMzNSwxMSArMzI4LDExIEBAIHN0YXRpYyBpbnQgbXR1M19nYWRnZXRfZGVxdWV1 ZShzdHJ1Y3QgdXNiX2VwICplcCwgc3RydWN0IHVzYl9yZXF1ZXN0ICpyZXEpDQogCXN0cnVjdCBt dHUzX2VwICptZXAgPSB0b19tdHUzX2VwKGVwKTsNCiAJc3RydWN0IG10dTNfcmVxdWVzdCAqbXJl cSA9IHRvX210dTNfcmVxdWVzdChyZXEpOw0KIAlzdHJ1Y3QgbXR1M19yZXF1ZXN0ICpyOw0KKwlz dHJ1Y3QgbXR1MyAqbXR1ID0gbWVwLT5tdHU7DQogCXVuc2lnbmVkIGxvbmcgZmxhZ3M7DQogCWlu dCByZXQgPSAwOw0KLQlzdHJ1Y3QgbXR1MyAqbXR1ID0gbWVwLT5tdHU7DQogDQotCWlmICghZXAg fHwgIXJlcSB8fCBtcmVxLT5tZXAgIT0gbWVwKQ0KKwlpZiAobXJlcS0+bWVwICE9IG1lcCkNCiAJ CXJldHVybiAtRUlOVkFMOw0KIA0KIAlkZXZfZGJnKG10dS0+ZGV2LCAiJXMgOiByZXE9JXBcbiIs IF9fZnVuY19fLCByZXEpOw0KQEAgLTM3OSw5ICszNzIsNiBAQCBzdGF0aWMgaW50IG10dTNfZ2Fk Z2V0X2VwX3NldF9oYWx0KHN0cnVjdCB1c2JfZXAgKmVwLCBpbnQgdmFsdWUpDQogCXVuc2lnbmVk IGxvbmcgZmxhZ3M7DQogCWludCByZXQgPSAwOw0KIA0KLQlpZiAoIWVwKQ0KLQkJcmV0dXJuIC1F SU5WQUw7DQotDQogCWRldl9kYmcobXR1LT5kZXYsICIlcyA6ICVzLi4uIiwgX19mdW5jX18sIGVw LT5uYW1lKTsNCiANCiAJc3Bpbl9sb2NrX2lycXNhdmUoJm10dS0+bG9jaywgZmxhZ3MpOw0KQEAg LTQyNCw5ICs0MTQsNiBAQCBzdGF0aWMgaW50IG10dTNfZ2FkZ2V0X2VwX3NldF93ZWRnZShzdHJ1 Y3QgdXNiX2VwICplcCkNCiB7DQogCXN0cnVjdCBtdHUzX2VwICptZXAgPSB0b19tdHUzX2VwKGVw KTsNCiANCi0JaWYgKCFlcCkNCi0JCXJldHVybiAtRUlOVkFMOw0KLQ0KIAltZXAtPndlZGdlZCA9 IDE7DQogDQogCXJldHVybiB1c2JfZXBfc2V0X2hhbHQoZXApOw0KLS0gDQoxLjkuMQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C345C433DF for ; Thu, 9 Jul 2020 07:17:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67F5820674 for ; Thu, 9 Jul 2020 07:17:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1uWsc92O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UAPYBQ5s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67F5820674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=guPF65Wga1JXtxHgG3kMbYCo/BllZj1pASSWFygD5yg=; b=1uWsc92O2HIOE0tHwxWNcawfvH gztX9ENGSPRXM2KOJeG2SjQMQdcK8YUw/K3W185KQrQ+T0b6N6To4o3jGQYTyUn8GfQLKT5KZKbXH CPww29Q8uUl8J66EmqlXDchhXYyR1xyfss8qEQMxp2s/pa6N+i3ZY+OHpKSbtMw7f04a8CLSfHied roiQ9dfGzcP+pvLRwjMwQuRhISBDNS3fqjPhawRab0+AI8/LXL1YbHkzcUvFR3cRT7qEx74xT63ZU NQ7AaR6gj0NL+6Z+qGsOZiM4+FpSThPPL1o76gZWBrycxUCiiwNRTnDfFNpk52BDRhc8yqWtUlXEE l9H2Imzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtQoO-00026I-By; Thu, 09 Jul 2020 07:17:40 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtQoL-00025k-6H; Thu, 09 Jul 2020 07:17:38 +0000 X-UUID: 83a000ca4e4f48a1848fd7eff380c830-20200708 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=KN9hhzoH05uLeemQtJA/oz8qydIgDPv4Z3bmecE5HhY=; b=UAPYBQ5shMTeK3m01pYEwcU3+kokwT2eBJO7UG9yllafqBt3pjL+Gmea8VXejA3JVAmGhXHEAIkgzhUKOVN8DNLj+Y6lytNYM/pTKfnmHBegb8r9LpiFk7iCOF11KKuMv+JT7mJILqqRBnh8Y2iMrpNSE9z2EslPXLHwkqbs4gY=; X-UUID: 83a000ca4e4f48a1848fd7eff380c830-20200708 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2125917086; Wed, 08 Jul 2020 23:17:24 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 00:09:44 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 15:09:43 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 9 Jul 2020 15:09:40 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Felipe Balbi Subject: [v3 PATCH] usb: mtu3: remove unnecessary NULL pointer checks Date: Thu, 9 Jul 2020 15:09:01 +0800 Message-ID: <1594278541-24968-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-TM-SNTS-SMTP: E0704D007BDFE6557E27D3F2225493E6F51B016FC12D4C256CBF91EF0F07D15E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_031737_477167_6DE622B7 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The class driver will ensure the parameters are not NULL pointers before call the hook function of usb_ep_ops, so no need check them again. Reported-by: Markus Elfring Signed-off-by: Chunfeng Yun --- v3: remove unnecessary NULL pointer checks but not add more checks. v2: nothing changed, but abandon another patch. --- drivers/usb/mtu3/mtu3_gadget.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index f93732e..6b26cb8 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -263,23 +263,15 @@ void mtu3_free_request(struct usb_ep *ep, struct usb_request *req) static int mtu3_gadget_queue(struct usb_ep *ep, struct usb_request *req, gfp_t gfp_flags) { - struct mtu3_ep *mep; - struct mtu3_request *mreq; - struct mtu3 *mtu; + struct mtu3_ep *mep = to_mtu3_ep(ep); + struct mtu3_request *mreq = to_mtu3_request(req); + struct mtu3 *mtu = mep->mtu; unsigned long flags; int ret = 0; - if (!ep || !req) - return -EINVAL; - if (!req->buf) return -ENODATA; - mep = to_mtu3_ep(ep); - mtu = mep->mtu; - mreq = to_mtu3_request(req); - mreq->mtu = mtu; - if (mreq->mep != mep) return -EINVAL; @@ -303,6 +295,7 @@ static int mtu3_gadget_queue(struct usb_ep *ep, return -ESHUTDOWN; } + mreq->mtu = mtu; mreq->request.actual = 0; mreq->request.status = -EINPROGRESS; @@ -335,11 +328,11 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, struct usb_request *req) struct mtu3_ep *mep = to_mtu3_ep(ep); struct mtu3_request *mreq = to_mtu3_request(req); struct mtu3_request *r; + struct mtu3 *mtu = mep->mtu; unsigned long flags; int ret = 0; - struct mtu3 *mtu = mep->mtu; - if (!ep || !req || mreq->mep != mep) + if (mreq->mep != mep) return -EINVAL; dev_dbg(mtu->dev, "%s : req=%p\n", __func__, req); @@ -379,9 +372,6 @@ static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value) unsigned long flags; int ret = 0; - if (!ep) - return -EINVAL; - dev_dbg(mtu->dev, "%s : %s...", __func__, ep->name); spin_lock_irqsave(&mtu->lock, flags); @@ -424,9 +414,6 @@ static int mtu3_gadget_ep_set_wedge(struct usb_ep *ep) { struct mtu3_ep *mep = to_mtu3_ep(ep); - if (!ep) - return -EINVAL; - mep->wedged = 1; return usb_ep_set_halt(ep); -- 1.9.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10571C433E0 for ; Thu, 9 Jul 2020 07:19:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6B5220674 for ; Thu, 9 Jul 2020 07:19:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ugMyf4Xk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UAPYBQ5s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6B5220674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=xb0ErnSNcLMlKX+yamWjv+YwICmJlxX5MkH0XhEI7O0=; b=ugMyf4XkT6wfDr5gQmv24Va44/ PhllZLhb6gxGUQPUls2BRzM4icWuEBCW/9xd0Ts8UIHoXBRuCxEmRu4rglIehlj/gNYkCMrCyUdzm 5jjXAOiVoug2ObI1dvyd1X7Nf/l+24GaR7zorAycdVBCaInV1MHNwN/U5oWZ38q1guOwI05YtzvLT z4cz5HXOnUvE3cYSVzRa3Mmulm+hSwBa81+LMFytOlfmjVWDYxUKbn+8Ph7X3WUC80c8sOafqtqm7 Tgsobx0z5uRaij5GvsJPVdPol3fZKVoD6daOkqsCwpIWC2fuH34vi1FPWaLqdsEUh44d8OOIg7pLm 9ZMDFqCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtQoP-00026Q-5K; Thu, 09 Jul 2020 07:17:41 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtQoL-00025k-6H; Thu, 09 Jul 2020 07:17:38 +0000 X-UUID: 83a000ca4e4f48a1848fd7eff380c830-20200708 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=KN9hhzoH05uLeemQtJA/oz8qydIgDPv4Z3bmecE5HhY=; b=UAPYBQ5shMTeK3m01pYEwcU3+kokwT2eBJO7UG9yllafqBt3pjL+Gmea8VXejA3JVAmGhXHEAIkgzhUKOVN8DNLj+Y6lytNYM/pTKfnmHBegb8r9LpiFk7iCOF11KKuMv+JT7mJILqqRBnh8Y2iMrpNSE9z2EslPXLHwkqbs4gY=; X-UUID: 83a000ca4e4f48a1848fd7eff380c830-20200708 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2125917086; Wed, 08 Jul 2020 23:17:24 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 00:09:44 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 9 Jul 2020 15:09:43 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 9 Jul 2020 15:09:40 +0800 From: Chunfeng Yun To: Greg Kroah-Hartman , Felipe Balbi Subject: [v3 PATCH] usb: mtu3: remove unnecessary NULL pointer checks Date: Thu, 9 Jul 2020 15:09:01 +0800 Message-ID: <1594278541-24968-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty MIME-Version: 1.0 X-TM-SNTS-SMTP: E0704D007BDFE6557E27D3F2225493E6F51B016FC12D4C256CBF91EF0F07D15E2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_031737_477167_6DE622B7 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Chunfeng Yun , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The class driver will ensure the parameters are not NULL pointers before call the hook function of usb_ep_ops, so no need check them again. Reported-by: Markus Elfring Signed-off-by: Chunfeng Yun --- v3: remove unnecessary NULL pointer checks but not add more checks. v2: nothing changed, but abandon another patch. --- drivers/usb/mtu3/mtu3_gadget.c | 25 ++++++------------------- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/usb/mtu3/mtu3_gadget.c b/drivers/usb/mtu3/mtu3_gadget.c index f93732e..6b26cb8 100644 --- a/drivers/usb/mtu3/mtu3_gadget.c +++ b/drivers/usb/mtu3/mtu3_gadget.c @@ -263,23 +263,15 @@ void mtu3_free_request(struct usb_ep *ep, struct usb_request *req) static int mtu3_gadget_queue(struct usb_ep *ep, struct usb_request *req, gfp_t gfp_flags) { - struct mtu3_ep *mep; - struct mtu3_request *mreq; - struct mtu3 *mtu; + struct mtu3_ep *mep = to_mtu3_ep(ep); + struct mtu3_request *mreq = to_mtu3_request(req); + struct mtu3 *mtu = mep->mtu; unsigned long flags; int ret = 0; - if (!ep || !req) - return -EINVAL; - if (!req->buf) return -ENODATA; - mep = to_mtu3_ep(ep); - mtu = mep->mtu; - mreq = to_mtu3_request(req); - mreq->mtu = mtu; - if (mreq->mep != mep) return -EINVAL; @@ -303,6 +295,7 @@ static int mtu3_gadget_queue(struct usb_ep *ep, return -ESHUTDOWN; } + mreq->mtu = mtu; mreq->request.actual = 0; mreq->request.status = -EINPROGRESS; @@ -335,11 +328,11 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, struct usb_request *req) struct mtu3_ep *mep = to_mtu3_ep(ep); struct mtu3_request *mreq = to_mtu3_request(req); struct mtu3_request *r; + struct mtu3 *mtu = mep->mtu; unsigned long flags; int ret = 0; - struct mtu3 *mtu = mep->mtu; - if (!ep || !req || mreq->mep != mep) + if (mreq->mep != mep) return -EINVAL; dev_dbg(mtu->dev, "%s : req=%p\n", __func__, req); @@ -379,9 +372,6 @@ static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value) unsigned long flags; int ret = 0; - if (!ep) - return -EINVAL; - dev_dbg(mtu->dev, "%s : %s...", __func__, ep->name); spin_lock_irqsave(&mtu->lock, flags); @@ -424,9 +414,6 @@ static int mtu3_gadget_ep_set_wedge(struct usb_ep *ep) { struct mtu3_ep *mep = to_mtu3_ep(ep); - if (!ep) - return -EINVAL; - mep->wedged = 1; return usb_ep_set_halt(ep); -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel