From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7749EC433DF for ; Thu, 9 Jul 2020 13:05:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5167A2073A for ; Thu, 9 Jul 2020 13:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5167A2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AF0BE6E12F; Thu, 9 Jul 2020 13:05:05 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id B40DF6E0C4; Thu, 9 Jul 2020 13:05:04 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id A29F5A66C9; Thu, 9 Jul 2020 13:05:04 +0000 (UTC) MIME-Version: 1.0 From: Patchwork To: "Daniel Vetter" Date: Thu, 09 Jul 2020 13:05:04 -0000 Message-ID: <159429990463.31091.18350957547334100259@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20200707201229.472834-1-daniel.vetter@ffwll.ch> In-Reply-To: <20200707201229.472834-1-daniel.vetter@ffwll.ch> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_dma-fence_annotations=2C_round_3_=28rev6=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: dma-fence annotations, round 3 (rev6) URL : https://patchwork.freedesktop.org/series/79212/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6993be4b66a4 dma-fence: basic lockdep annotations -:23: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit e91498589746 ("locking/lockdep/selftests: Add mixed read-write ABBA tests")' #23: commit e91498589746065e3ae95d9a00b068e525eec34f -:97: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e966eaeeb623 ("locking/lockdep: Remove the cross-release locking checks")' #97: commit e966eaeeb623f09975ef362c2866fae6f86844f9 -:103: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #103: This code (CONFIG_LOCKDEP_CROSSRELEASE=y and CONFIG_LOCKDEP_COMPLETIONS=y), -:303: ERROR:IN_ATOMIC: do not use in_atomic in drivers #303: FILE: drivers/dma-buf/dma-fence.c:228: + if (in_atomic()) -:341: CHECK:LINE_SPACING: Please don't use multiple blank lines #341: FILE: drivers/dma-buf/dma-fence.c:266: + + -:390: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #390: FILE: include/linux/dma-fence.h:368: +} +static inline void dma_fence_end_signalling(bool cookie) {} -:396: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 3 errors, 2 warnings, 2 checks, 217 lines checked 550e03fe8f5d dma-fence: prime lockdep annotations -:31: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 23b68395c7c7 ("mm/mmu_notifiers: add a lockdep map for invalidate_range_start/end")' #31: commit 23b68395c7c78a764e8963fc15a7cfd318bf187f -:193: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 1 errors, 1 warnings, 0 checks, 91 lines checked 235ccf350083 drm/virtio: Remove open-coded commit-tail function -:54: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 32 lines checked f5a16e131fbb drm/vkms: Annotate vblank timer -:59: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 25 lines checked 855bf7ca2525 drm/vblank: Annotate with dma-fence signalling section -:71: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 38 lines checked 37fe1fb7e37d drm/amdgpu: add dma-fence annotations to atomic commit path -:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 24 lines checked 5d76f227525e drm/komdea: Annotate dma-fence critical section in commit path -:47: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 15 lines checked 8925fab7b0c5 drm/malidp: Annotate dma-fence critical section in commit path -:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 15 lines checked 75d8ed548bbf drm/atmel: Use drm_atomic_helper_commit -:213: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 170 lines checked 5b7ea987488e drm/imx: Annotate dma-fence critical section in commit path -:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 21a01abbe32a ("drm/atomic: Fix freeing connector/plane state too early by tracking commits, v3.")' #14: commit 21a01abbe32a3cbeb903378a24e504bfd9fe0648 -:50: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 1 errors, 1 warnings, 0 checks, 14 lines checked d525fd5dc000 drm/omapdrm: Annotate dma-fence critical section in commit path -:54: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 29 lines checked 49148da69b74 drm/rcar-du: Annotate dma-fence critical section in commit path -:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked 627ff2bada55 drm/tegra: Annotate dma-fence critical section in commit path -:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked ee1ca3dd92f2 drm/tidss: Annotate dma-fence critical section in commit path -:41: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 22 lines checked 3d04ddeaf40d drm/tilcdc: Use standard drm_atomic_helper_commit -:143: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 95 lines checked 39dc5478117b drm/atomic-helper: Add dma-fence annotations -:119: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 76 lines checked f332e8b0c75a drm/scheduler: use dma-fence annotations in main thread -:53: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 21 lines checked 5e5dbfd6d1ec drm/amdgpu: use dma-fence annotations in cs_submit() -:65: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 29 lines checked d86363507ad2 drm/amdgpu: s/GFP_KERNEL/GFP_ATOMIC in scheduler code -:82: WARNING:ALLOC_ARRAY_ARGS: kmalloc_array uses number as first arg, sizeof is generally wrong #82: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:211: + fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_ATOMIC); -:98: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 2 warnings, 0 checks, 24 lines checked 6660214e85f5 drm/amdgpu: DC also loves to allocate stuff where it shouldn't -:70: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #70: FILE: drivers/gpu/drm/amd/display/dc/core/dc.c:1479: + * atomic_commit_tail. */ -:76: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 2 warnings, 0 checks, 27 lines checked 26eae69dc709 drm/amdgpu/dc: Stop dma_resv_lock inversion in commit_tail -:39: WARNING:IF_0: Consider removing the code enclosed by this #if 0 and its #endif #39: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:6956: +#if 0 -:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 2 warnings, 0 checks, 23 lines checked 5f09a1d7a2d8 drm/scheduler: use dma-fence annotations in tdr work -:28: WARNING:TYPO_SPELLING: 'seperate' may be misspelled - perhaps 'separate'? #28: Hence split out as a seperate patch. -:114: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 2 warnings, 0 checks, 20 lines checked 11967393ce15 drm/amdgpu: use dma-fence annotations for gpu reset code 77e2e55426dd Revert "drm/amdgpu: add fbdev suspend/resume on gpu reset" -:145: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 16 lines checked 971910d92097 drm/amdgpu: gpu recovery does full modesets -:186: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>' total: 0 errors, 1 warnings, 0 checks, 14 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx