答复: [External Mail]Re: [PATCH 2/5] power: supply: core: add wireless charger adapter type property

["Fei1 Jiang 蒋飞" <jiangfei1@xiaomi.com>]

Hi Greg,

Our new six power supply properties  return values are all integer, so please

add them above "Properties of type `const char" comment
xxx
...
/* Properties of type `const char *' */


Thanks!

B&R
Fei Jiang
________________________________________
发件人: Greg KH <gregkh@linuxfoundation.org>
发送时间: 2020年7月10日 18:00
收件人: Qiwu Huang
抄送: sre@kernel.org; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; Fei1 Jiang 蒋飞; 黄其武
主题: [External Mail]Re: [PATCH 2/5] power: supply: core: add wireless charger adapter type property

On Fri, Jul 10, 2020 at 04:48:38PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
>
> Reports what type of wireless adapter connection is
> currently active forthe supply.
> for example it can show if ADAPTER_PD capable source is attached.
>
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 13 +++++++++++++
>  drivers/power/supply/power_supply_sysfs.c   |  1 +
>  include/linux/power_supply.h                |  1 +
>  3 files changed, 15 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 0d9d6b46e239..2099cf194a89 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -718,3 +718,16 @@ Contact: Fei Jiang <jiangfei1@xiaomi.com>
>               Access: Read-Only
>               Valid values: "QUICK_CHARGE_NORMAL", "QUICK_CHARGE_FAST", "QUICK_CHARGE_FLASH",
>               "QUICK_CHARGE_TURBE", "QUICK_CHARGE_SUPER".
> +
> +===== Wireless Charger Properties =====
> +What:                /sys/class/power_supply/<supply_name>/tx_adapter
> +Date:                Jul 2020
> +Contact:     Fei Jiang <jiangfei1@xiaomi.com>
> +Description:
> +             Reports what type of wireless adapter connection is currently active for
> +             the supply, for example it can show if ADAPTER_PD capable source
> +             is attached.
> +
> +             Access: Read-Only
> +             Valid values: "ADAPTER_NONE", "ADAPTER_SDP", "ADAPTER_DCP", "ADAPTER_CDP",
> +             "ADAPTER_QC2", "ADAPTER_QC3", "ADAPTER_PD" or other private adapter.

Why are these strings not in the patch as well?

> \ No newline at end of file
> diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
> index f95574c41898..c864a14829ec 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -207,6 +207,7 @@ static struct power_supply_attr power_supply_attrs[] = {
>       POWER_SUPPLY_ATTR(MANUFACTURER),
>       POWER_SUPPLY_ATTR(SERIAL_NUMBER),
>       POWER_SUPPLY_ATTR(quick_charge_type),
> +     POWER_SUPPLY_ATTR(tx_adapter),

upper case?

thanks,

greg k-h
#/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#