From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168DBC433E0 for ; Tue, 14 Jul 2020 10:00:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D6CC4221FF for ; Tue, 14 Jul 2020 10:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="EiBe0bVD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbgGNKAu (ORCPT ); Tue, 14 Jul 2020 06:00:50 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:60034 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725906AbgGNKAs (ORCPT ); Tue, 14 Jul 2020 06:00:48 -0400 X-UUID: bed1a5133baf41409bc26c71107765b3-20200714 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ysgoiQZkd6yevHeAk27WbwaWZS5sYS8VuJlnh1+Ohgc=; b=EiBe0bVDnv7jLZLq4iiF2Jf9Beill+ZoiWu8CI0AAXdo4Q+9vDg3yvfnw46EmODy2IJu+AenpcWe9PGGKXa69pQ92gKPKsGO0wUstZ8rKzWX1c3XncZti/QiMNi8DXcFv9kUlcSlHJECMN3m7u3UZVwCDGHQGl1mFYXyu0xmcL4=; X-UUID: bed1a5133baf41409bc26c71107765b3-20200714 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1712766276; Tue, 14 Jul 2020 18:00:43 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 18:00:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 14 Jul 2020 18:00:41 +0800 Message-ID: <1594720842.22878.38.camel@mtkswgap22> Subject: RE: [PATCH v3] scsi: ufs: Cleanup completed request without interrupt notification From: Stanley Chu To: Avri Altman CC: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "alim.akhtar@samsung.com" , "jejb@linux.ibm.com" , "bvanassche@acm.org" , "beanhuo@micron.com" , "asutoshd@codeaurora.org" , "cang@codeaurora.org" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kuohong.wang@mediatek.com" , "peter.wang@mediatek.com" , "chun-hung.wu@mediatek.com" , "andy.teng@mediatek.com" , "chaotian.jing@mediatek.com" , "cc.chou@mediatek.com" Date: Tue, 14 Jul 2020 18:00:42 +0800 In-Reply-To: References: <20200706132113.21096-1-stanley.chu@mediatek.com> <1594517160.10600.33.camel@mtkswgap22> <1594716527.22878.28.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgQXZyaSwNCg0KT24gVHVlLCAyMDIwLTA3LTE0IGF0IDA5OjI5ICswMDAwLCBBdnJpIEFsdG1h biB3cm90ZToNCj4gPiA+ID4gPiA+ICtjbGVhbnVwOg0KPiA+ID4gPiA+ID4gKyAgICAgICBzcGlu X2xvY2tfaXJxc2F2ZShob3N0LT5ob3N0X2xvY2ssIGZsYWdzKTsNCj4gPiA+ID4gPiA+ICsgICAg ICAgaWYgKCF0ZXN0X2JpdCh0YWcsICZoYmEtPm91dHN0YW5kaW5nX3JlcXMpKSB7DQo+ID4gPiBJ cyB0aGlzIG5lZWRlZD8gIGl0IHdhcyBhbHJlYWR5IGNoZWNrZWQgaW4gbGluZSA2NDM5Lg0KPiA+ ID4NCj4gPiANCj4gPiBJIGFtIHdvcnJpZWQgYWJvdXQgdGhlIGNhc2UgdGhhdCBpbnRlcnJ1cHQg Y29tZXMgdmVyeSBsYXRlbHkuIA0KPiBzY3NpIHRpbWVvdXQgaXMgMzBzZWMgLSBkbyB5b3UgZXhw ZWN0IGFuIGludGVycnVwdCB0byBhcnJpdmUgYWZ0ZXIgdGhhdD8NCj4gDQoNClllYWgsIEkgYWdy ZWUgdGhhdCBhIDMwcyBkZWxheWVkIGludGVycnVwdCBzb3VuZHMga2luZCBvZiByaWRpY3Vsb3Vz Lg0KVGhpcyBjaGVja2luZyBpcyBqdXN0IHRvIG1ha2UgdGhlIGNsZWFudXAgZmxvdyBzYWZlci4N Cg0KVGhhbmtzLA0KU3RhbmxleSBDaHUNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52248C433E1 for ; Tue, 14 Jul 2020 10:06:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D71B217D8 for ; Tue, 14 Jul 2020 10:06:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HTmYWXzC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="EiBe0bVD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D71B217D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tvak5f6d1E8hK+coXkkVao571UPPZJ0kD9n53+3UuRA=; b=HTmYWXzCV4ZApZTcHaXnkN93Y ImAMmEcuvt5hzPQaTCXt9e3y51YLxHHfgYp5q5iv25JU/B1F/Fibw6CNtJdjUj7bYr2E7cu7SWfZR xwOVatoBlZqSrYpyPO4uT+vWrcvKhfqpcYyYnzwpcMyyazSzB0LCct1sAQegpUkqRDPHbwiwZCTWy D8TqZYA/8JkHUL/k/7BseXCHWIgmnpx/ap6c0pqZNorKubtt7B/7RDw+oLD8b8J2tv7oNmDmsqCUy /+CyTGmI9/Ofgx/bJEazRzVEV529Bqq5qR+FwyO6I8yP2PTCI+AePl31iMQTyzg1MjQbnZOprBlvW RzDICV5vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvHpZ-0003dc-AJ; Tue, 14 Jul 2020 10:06:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvHpV-0003cF-A8; Tue, 14 Jul 2020 10:06:30 +0000 X-UUID: d10df7b5851a4ffea5ae7d104038b6f9-20200714 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ysgoiQZkd6yevHeAk27WbwaWZS5sYS8VuJlnh1+Ohgc=; b=EiBe0bVDnv7jLZLq4iiF2Jf9Beill+ZoiWu8CI0AAXdo4Q+9vDg3yvfnw46EmODy2IJu+AenpcWe9PGGKXa69pQ92gKPKsGO0wUstZ8rKzWX1c3XncZti/QiMNi8DXcFv9kUlcSlHJECMN3m7u3UZVwCDGHQGl1mFYXyu0xmcL4=; X-UUID: d10df7b5851a4ffea5ae7d104038b6f9-20200714 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 241921564; Tue, 14 Jul 2020 02:06:28 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 03:00:54 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 18:00:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 14 Jul 2020 18:00:41 +0800 Message-ID: <1594720842.22878.38.camel@mtkswgap22> Subject: RE: [PATCH v3] scsi: ufs: Cleanup completed request without interrupt notification From: Stanley Chu To: Avri Altman Date: Tue, 14 Jul 2020 18:00:42 +0800 In-Reply-To: References: <20200706132113.21096-1-stanley.chu@mediatek.com> <1594517160.10600.33.camel@mtkswgap22> <1594716527.22878.28.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_060629_538407_86BF508F X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cc.chou@mediatek.com" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "asutoshd@codeaurora.org" , "chaotian.jing@mediatek.com" , "bvanassche@acm.org" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Avri, On Tue, 2020-07-14 at 09:29 +0000, Avri Altman wrote: > > > > > > +cleanup: > > > > > > + spin_lock_irqsave(host->host_lock, flags); > > > > > > + if (!test_bit(tag, &hba->outstanding_reqs)) { > > > Is this needed? it was already checked in line 6439. > > > > > > > I am worried about the case that interrupt comes very lately. > scsi timeout is 30sec - do you expect an interrupt to arrive after that? > Yeah, I agree that a 30s delayed interrupt sounds kind of ridiculous. This checking is just to make the cleanup flow safer. Thanks, Stanley Chu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF969C433E1 for ; Tue, 14 Jul 2020 10:07:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC15B217D8 for ; Tue, 14 Jul 2020 10:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3l3SO8Js"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="EiBe0bVD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC15B217D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e5IFkpVlDp3IAhw8bzC3SWOiajZr0YZy/60tFrAV7Jg=; b=3l3SO8JszC8PCCquK/tLV7APO lVDWZCo+Thp0C75qCmZILoHTjT/Tl3WH0GsxsN/19ZQq2NuvDaab0Qw7Tj6rswRvj8L25KHi4FI/g vA6JPedZQAyOhr10Tn0prZ9ZYH80H88kzcIW6jJWKt8WejDtu+TbeEJiw8J8jn4xxwN7K0e/VLwQx AhzjvulRsd9Ce0iOqqzeFXBKLOYiet2xfWNzOpVlZCo1OaW1g/yavrpnyY+hNbPVwEn72D5S0PC+b qCPQymw65oxb+u9/qPfQHS01aTdbXIX0NQu80UYh2tr+wXr00dJ+H+x914sUkr7c7Md/P1qxKHfnK c7AJHLWvQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvHpX-0003dG-N5; Tue, 14 Jul 2020 10:06:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvHpV-0003cF-A8; Tue, 14 Jul 2020 10:06:30 +0000 X-UUID: d10df7b5851a4ffea5ae7d104038b6f9-20200714 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ysgoiQZkd6yevHeAk27WbwaWZS5sYS8VuJlnh1+Ohgc=; b=EiBe0bVDnv7jLZLq4iiF2Jf9Beill+ZoiWu8CI0AAXdo4Q+9vDg3yvfnw46EmODy2IJu+AenpcWe9PGGKXa69pQ92gKPKsGO0wUstZ8rKzWX1c3XncZti/QiMNi8DXcFv9kUlcSlHJECMN3m7u3UZVwCDGHQGl1mFYXyu0xmcL4=; X-UUID: d10df7b5851a4ffea5ae7d104038b6f9-20200714 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 241921564; Tue, 14 Jul 2020 02:06:28 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 03:00:54 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 14 Jul 2020 18:00:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 14 Jul 2020 18:00:41 +0800 Message-ID: <1594720842.22878.38.camel@mtkswgap22> Subject: RE: [PATCH v3] scsi: ufs: Cleanup completed request without interrupt notification From: Stanley Chu To: Avri Altman Date: Tue, 14 Jul 2020 18:00:42 +0800 In-Reply-To: References: <20200706132113.21096-1-stanley.chu@mediatek.com> <1594517160.10600.33.camel@mtkswgap22> <1594716527.22878.28.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_060629_538407_86BF508F X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cc.chou@mediatek.com" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "asutoshd@codeaurora.org" , "chaotian.jing@mediatek.com" , "bvanassche@acm.org" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Avri, On Tue, 2020-07-14 at 09:29 +0000, Avri Altman wrote: > > > > > > +cleanup: > > > > > > + spin_lock_irqsave(host->host_lock, flags); > > > > > > + if (!test_bit(tag, &hba->outstanding_reqs)) { > > > Is this needed? it was already checked in line 6439. > > > > > > > I am worried about the case that interrupt comes very lately. > scsi timeout is 30sec - do you expect an interrupt to arrive after that? > Yeah, I agree that a 30s delayed interrupt sounds kind of ridiculous. This checking is just to make the cleanup flow safer. Thanks, Stanley Chu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel