From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make i830 .get_cdclk() assignment less confusing
Date: Tue, 14 Jul 2020 17:45:45 +0100 [thread overview]
Message-ID: <159474514516.3188.7254765951013259696@build.alporthouse.com> (raw)
In-Reply-To: <20200714152626.380-3-ville.syrjala@linux.intel.com>
Quoting Ville Syrjala (2020-07-14 16:26:25)
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Explicitly check for i830 when assigning the .get_cdclk() vfunc,
> and then deal with the case of not having assigned the vfunc
> separately. Less confusing, and gets rid of the checkpatch complaint
> about using {} on one branch but not the others.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-14 16:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 15:26 [Intel-gfx] [PATCH 1/4] drm/i915: Pack struct intel_cdclk_vals Ville Syrjala
2020-07-14 15:26 ` [Intel-gfx] [PATCH 2/4] drm/i915: Fix some whitespace Ville Syrjala
2020-07-14 16:48 ` Chris Wilson
2020-07-14 15:26 ` [Intel-gfx] [PATCH 3/4] drm/i915: Make i830 .get_cdclk() assignment less confusing Ville Syrjala
2020-07-14 16:45 ` Chris Wilson [this message]
2020-07-14 15:26 ` [Intel-gfx] [PATCH 4/4] drm/i915: Nuke force_min_cdclk_changed Ville Syrjala
2020-09-16 7:46 ` Lisovskiy, Stanislav
2020-07-14 16:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Pack struct intel_cdclk_vals Patchwork
2020-07-14 16:44 ` [Intel-gfx] [PATCH 1/4] " Chris Wilson
2020-07-14 18:09 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159474514516.3188.7254765951013259696@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.