From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Tue, 14 Jul 2020 17:15:22 +0000 Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/selftest: Fix an error code in live_noa_gpr() Message-Id: <159474692212.3188.5286642208247298191@build.alporthouse.com> List-Id: References: <20200714143652.GA337376@mwanda> <29d5e25e-45e1-fca0-7d09-fd5e303b9eea@intel.com> In-Reply-To: <29d5e25e-45e1-fca0-7d09-fd5e303b9eea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula , Lionel Landwerlin Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org Quoting Lionel Landwerlin (2020-07-14 15:39:21) > On 14/07/2020 17:36, Dan Carpenter wrote: > > The error code needs to be set on this path. It currently returns > > success. > > > > Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait") > > Reported-by: Lionel Landwerlin > > Signed-off-by: Dan Carpenter > > --- > > v2: Fix a different bug instead. :P Colin fixed mine already. I was thinking that Colin already sent the patch for this one... > > > > drivers/gpu/drm/i915/selftests/i915_perf.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c > > index 0aa151501fb3..c232194c60a2 100644 > > --- a/drivers/gpu/drm/i915/selftests/i915_perf.c > > +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c > > @@ -358,6 +358,7 @@ static int live_noa_gpr(void *arg) > > cs = intel_ring_begin(rq, 4); > > if (IS_ERR(cs)) { > > i915_request_add(rq); > > + err = PTR_ERR(cs); > > goto out_rq; > > } > > > > Reviewed-by: Lionel Landwerlin Ta, -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA99C433E0 for ; Tue, 14 Jul 2020 17:15:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EC2E22596 for ; Tue, 14 Jul 2020 17:15:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EC2E22596 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C2AD6E172; Tue, 14 Jul 2020 17:15:48 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E04A6E0C5 for ; Tue, 14 Jul 2020 17:15:45 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21818335-1500050 for multiple; Tue, 14 Jul 2020 18:15:23 +0100 MIME-Version: 1.0 In-Reply-To: <29d5e25e-45e1-fca0-7d09-fd5e303b9eea@intel.com> References: <20200714143652.GA337376@mwanda> <29d5e25e-45e1-fca0-7d09-fd5e303b9eea@intel.com> From: Chris Wilson To: Dan Carpenter , Jani Nikula , Lionel Landwerlin Date: Tue, 14 Jul 2020 18:15:22 +0100 Message-ID: <159474692212.3188.5286642208247298191@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/selftest: Fix an error code in live_noa_gpr() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Lionel Landwerlin (2020-07-14 15:39:21) > On 14/07/2020 17:36, Dan Carpenter wrote: > > The error code needs to be set on this path. It currently returns > > success. > > > > Fixes: ed2690a9ca89 ("drm/i915/selftest: Check that GPR are restored across noa_wait") > > Reported-by: Lionel Landwerlin > > Signed-off-by: Dan Carpenter > > --- > > v2: Fix a different bug instead. :P Colin fixed mine already. I was thinking that Colin already sent the patch for this one... > > > > drivers/gpu/drm/i915/selftests/i915_perf.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c > > index 0aa151501fb3..c232194c60a2 100644 > > --- a/drivers/gpu/drm/i915/selftests/i915_perf.c > > +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c > > @@ -358,6 +358,7 @@ static int live_noa_gpr(void *arg) > > cs = intel_ring_begin(rq, 4); > > if (IS_ERR(cs)) { > > i915_request_add(rq); > > + err = PTR_ERR(cs); > > goto out_rq; > > } > > > > Reviewed-by: Lionel Landwerlin Ta, -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx