All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Petr Vorel <pvorel@suse.cz>, linux-integrity@vger.kernel.org
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: [PATCH ima-evm-utils v2] Check for tsspcrread in runtime
Date: Wed, 15 Jul 2020 21:47:46 -0400	[thread overview]
Message-ID: <1594864066.12900.356.camel@linux.ibm.com> (raw)
In-Reply-To: <20200715132817.8529-1-pvorel@suse.cz>

On Wed, 2020-07-15 at 15:28 +0200, Petr Vorel wrote:
> instead of checking in build time as it's runtime dependency.
> Also log when tsspcrread not found to make debugging easier.
> 
> We search for tsspcrread unless there is tss2-esys with Esys_PCR_Read(),
> thus pcr_none.c was dropped as unneeded.
> 
> file_exist(), tst_get_path() and MIN() taken from LTP project.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi Mimi,
> 
> changes v1->v2:
> * Log used binary/library.
> * Drop using **errmsg in tpm2_pcr_supported() use log_info() and
> log_debug() instead.
> * Formatting changes in includes
> 
> Feel free to amend this patch to suit your needs.

log_info() is not displaying the method of reading the PCRs.  To
resolve this add the necessary USE_FPRINTF definitions.

Mimi

  parent reply	other threads:[~2020-07-16  1:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15 13:28 [PATCH ima-evm-utils v2] Check for tsspcrread in runtime Petr Vorel
2020-07-15 13:37 ` Petr Vorel
2020-07-15 19:34   ` Mimi Zohar
2020-07-15 19:57     ` Vitaly Chikunov
2020-07-15 20:02       ` Mimi Zohar
2020-07-16  8:15     ` Petr Vorel
2020-07-16  1:47 ` Mimi Zohar [this message]
2020-07-16  8:07   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594864066.12900.356.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=pvorel@suse.cz \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.