All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 05/10] drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs
Date: Wed, 22 Jul 2020 09:30:45 +0100	[thread overview]
Message-ID: <159540664575.15672.1731319291840351479@build.alporthouse.com> (raw)
In-Reply-To: <a764e063-b62f-ccb9-24df-b52fa6caa13e@linux.intel.com>

Quoting Tvrtko Ursulin (2020-07-22 09:12:14)
> 
> On 20/07/2020 16:02, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2020-07-20 12:23:35)
> >>
> >> On 20/07/2020 10:23, Chris Wilson wrote:
> >>> -void intel_engine_init_breadcrumbs(struct intel_engine_cs *engine)
> >>> +struct intel_breadcrumbs *
> >>> +intel_breadcrumbs_create(struct intel_engine_cs *irq_engine)
> >>>    {
> >>> -     struct intel_breadcrumbs *b = &engine->breadcrumbs;
> >>> +     struct intel_breadcrumbs *b;
> >>> +
> >>> +     b = kzalloc(sizeof(*b), GFP_KERNEL);
> >>> +     if (!b)
> >>> +             return NULL;
> >>>    
> >>>        spin_lock_init(&b->irq_lock);
> >>>        INIT_LIST_HEAD(&b->signalers);
> >>>        INIT_LIST_HEAD(&b->signaled_requests);
> >>>    
> >>>        init_irq_work(&b->irq_work, signal_irq_work);
> >>> +
> >>> +     b->irq_engine = irq_engine;
> >>> +     if (!irq_engine)
> >>> +             b->irq_armed = true; /* fake HW, used for irq_work */
> >>
> >> Disarm is checking for !b->irq_engine and arm asserts there must be when
> >> arming. If instead arm would abort on !b->irq_engine would it all work
> >> just as well without the need for this hack?
> > 
> > Yes, it is asymmetric. I thought keeping the asymmetry in place for the
> > conversion would be simpler, but didn't really make an attempt to make
> > irq_armed behave as one would expect.
> 
> You think it's not as simple as early return in arm if on irq engine?

And moving the early checks to disarm_irq for symmetry. I was just
worrying too much about the impact of changing irq_armed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-07-22  8:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20  9:23 [Intel-gfx] [PATCH 01/10] drm/i915/gem: Remove disordered per-file request list for throttling Chris Wilson
2020-07-20  9:23 ` [Intel-gfx] [PATCH 02/10] drm/i915: Remove requirement for holding i915_request.lock for breadcrumbs Chris Wilson
2020-07-20  9:23 ` [Intel-gfx] [PATCH 03/10] drm/i915/gt: Replace intel_engine_transfer_stale_breadcrumbs Chris Wilson
2020-07-20  9:32   ` Tvrtko Ursulin
2020-07-20  9:23 ` [Intel-gfx] [PATCH 04/10] drm/i915/gt: Only transfer the virtual context to the new engine if active Chris Wilson
2020-07-20  9:23 ` [Intel-gfx] [PATCH 05/10] drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs Chris Wilson
2020-07-20 11:23   ` Tvrtko Ursulin
2020-07-20 15:02     ` Chris Wilson
2020-07-22  8:12       ` Tvrtko Ursulin
2020-07-22  8:30         ` Chris Wilson [this message]
2020-07-21  7:59   ` kernel test robot
2020-07-21  7:59     ` kernel test robot
2020-07-20  9:23 ` [Intel-gfx] [PATCH 06/10] drm/i915/gt: Move intel_breadcrumbs_arm_irq earlier Chris Wilson
2020-07-22 12:55   ` Tvrtko Ursulin
2020-07-20  9:23 ` [Intel-gfx] [PATCH 07/10] drm/i915/gt: Hold context/request reference while breadcrumbs are active Chris Wilson
2020-07-22 13:05   ` Tvrtko Ursulin
2020-07-22 13:11     ` Chris Wilson
2020-07-20  9:23 ` [Intel-gfx] [PATCH 08/10] drm/i915/gt: Track signaled breadcrumbs outside of the breadcrumb spinlock Chris Wilson
2020-07-22 13:26   ` Tvrtko Ursulin
2020-07-22 13:42     ` Chris Wilson
2020-07-20  9:23 ` [Intel-gfx] [PATCH 09/10] drm/i915/gt: Split the breadcrumb spinlock between global and contexts Chris Wilson
2020-07-20  9:23 ` [Intel-gfx] [PATCH 10/10] drm/i915: Drop i915_request.lock serialisation around await_start Chris Wilson
2020-07-20 10:33 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915/gem: Remove disordered per-file request list for throttling Patchwork
2020-07-20 10:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-20 10:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-07-20 13:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159540664575.15672.1731319291840351479@build.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.