From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED49C433E0 for ; Fri, 24 Jul 2020 10:19:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96B8A206F0 for ; Fri, 24 Jul 2020 10:19:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96B8A206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 291596E94C; Fri, 24 Jul 2020 10:19:10 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 59F026E94C for ; Fri, 24 Jul 2020 10:19:09 +0000 (UTC) IronPort-SDR: JYEFiBLZ7dSFSrR4wEYe9BokwxZOcb4excgWZnCQ/N7xAL/wgS48LztVr1crNH9/j/iSft8VMQ pWA3gUFiojLw== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="215272557" X-IronPort-AV: E=Sophos;i="5.75,390,1589266800"; d="scan'208";a="215272557" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 03:19:07 -0700 IronPort-SDR: C/6gGkZv0hhcd+0PcwyrKxEKbDejXS6eFfXUHoa4NS+wlRiJLIW7ky6iICU3oZfAckZGjQ9BnQ d08uWctwCw5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,390,1589266800"; d="scan'208";a="488690272" Received: from cwilso3-mobl.fi.intel.com (HELO localhost) ([10.213.227.31]) by fmsmga006.fm.intel.com with ESMTP; 24 Jul 2020 03:19:06 -0700 MIME-Version: 1.0 In-Reply-To: References: <20200724001901.35662-1-umesh.nerlige.ramappa@intel.com> <20200724001901.35662-3-umesh.nerlige.ramappa@intel.com> <159558277976.21069.2416672457874030480@build.alporthouse.com> From: Chris Wilson To: Lionel Landwerlin , Umesh Nerlige Ramappa , intel-gfx@lists.freedesktop.org Date: Fri, 24 Jul 2020 11:19:05 +0100 Message-ID: <159558594558.21069.2521382659864870599@build.alporthouse.com> User-Agent: alot/0.9 Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915/perf: Whitelist OA report trigger registers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Lionel Landwerlin (2020-07-24 11:07:18) > On 24/07/2020 12:26, Chris Wilson wrote: > > Quoting Umesh Nerlige Ramappa (2020-07-24 01:18:59) > >> diff --git a/drivers/gpu/drm/i915/gt/selftest_workarounds.c b/drivers/gpu/drm/i915/gt/selftest_workarounds.c > >> index febc9e6692ba..3b1d3dbcd477 100644 > >> --- a/drivers/gpu/drm/i915/gt/selftest_workarounds.c > >> +++ b/drivers/gpu/drm/i915/gt/selftest_workarounds.c > >> @@ -934,6 +934,10 @@ static bool pardon_reg(struct drm_i915_private *i915, i915_reg_t reg) > >> static const struct regmask pardon[] = { > >> { GEN9_CTX_PREEMPT_REG, INTEL_GEN_MASK(9, 9) }, > >> { GEN8_L3SQCREG4, INTEL_GEN_MASK(9, 9) }, > >> + { OAREPORTTRIG2, INTEL_GEN_MASK(8, 11) }, > >> + { OAREPORTTRIG6, INTEL_GEN_MASK(8, 11) }, > >> + { GEN12_OAG_OAREPORTTRIG2, INTEL_GEN_MASK(12, 12) }, > >> + { GEN12_OAG_OAREPORTTRIG6, INTEL_GEN_MASK(12, 12) }, > > Because we are not making the mistake of exposing more globals, and the > > pardon is a list of our past sins, not an excuse for more. > > I'm afraid the HW design leave us no choice on Gen12 :( The question then is how much mischief can a client get up to if they subvert the OA of the privileged user. It's a privilege escalation hole, but is there anything dangerous behind it? Or is it just going to disturb the data being fed to the privileged client... (Which seems scary enough.) -Chris --------------------------------------------------------------------- Intel Corporation (UK) Limited Registered No. 1134945 (England) Registered Office: Pipers Way, Swindon SN3 1RJ VAT No: 860 2173 47 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx