From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A7B7C433E3 for ; Fri, 24 Jul 2020 20:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B5172070B for ; Fri, 24 Jul 2020 20:27:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bLLtK1Ze" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgGXU1X (ORCPT ); Fri, 24 Jul 2020 16:27:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgGXU1W (ORCPT ); Fri, 24 Jul 2020 16:27:22 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A2BFC0619E4 for ; Fri, 24 Jul 2020 13:27:22 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id t15so6105866pjq.5 for ; Fri, 24 Jul 2020 13:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=FvJp6KRxuCLfQ1LrQuFAFBgfAkQQ7QvIAiuIgT4S7HI=; b=bLLtK1ZeE35eR4FeMC+fIRZcgm/BS04TxFnqA147MIiBhcPUrpTjQ8mBLU2R2PtCm9 CUVySufyEYz8uVUJpQ49823cuD7nd7ZhKLAi1xYUsl3Pn6QhRjbfekw074vqy7qJrFyO OmkvtFikiS+cJRmGZVH7c4nQhXUT68Q9nduVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=FvJp6KRxuCLfQ1LrQuFAFBgfAkQQ7QvIAiuIgT4S7HI=; b=tw49SnFvAqTcWLAxqbnqqKvuK0VvQ10TyzTULZlKtd5yNURo6CcN80gczUvyAhG1ru D5xR5u8DWG1B6pdWuYfJQxmMHwAxmPpXpHC7YB6FXdS52u6G8H2vfC083+txCbAi2KYL z2DyEb6/5zHiwxvKa+mwZ4xs+MKQoJNKGGhS0UUPU0c+yMQjVvu2V06/2OfRFjyP2+Oc 151aXHCkYx/oSumMqyQPlFpRGuGFBik1lCtSBH0iOXIt+SOehtfywO9CCYJc18VnUuHW LSG/2NVCDKdIRB9uv9k+PEStGsmRh8U5WN4cftH7C/mjNHN/X6xeEZeUaYG1OcCVfI3E V21g== X-Gm-Message-State: AOAM530TrpiVzkqsOiRuPQEfd7Evbjpuk3XS/eKoYBYvzJzo7TcXeL5U fiMYA6zTOoezqFEaqCfvohcMUw== X-Google-Smtp-Source: ABdhPJzNm0R7S4KH72z9GGjwL6AJWsQTruzmVb+ywN6nSy348ghglA8LdzPaCVFFbhqmejehPPY8sQ== X-Received: by 2002:a17:90a:d181:: with SMTP id fu1mr6839522pjb.60.1595622442012; Fri, 24 Jul 2020 13:27:22 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id nh14sm6590084pjb.4.2020.07.24.13.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 13:27:21 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <20200723010137.3127584-1-swboyd@chromium.org> <159561988523.3847286.14763422711224252201@swboyd.mtv.corp.google.com> <159562087212.3847286.9484527206999948907@swboyd.mtv.corp.google.com> Subject: Re: [PATCH] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free From: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , LKML , linux-arm-msm , Maulik Shah , Lina Iyer To: Doug Anderson Date: Fri, 24 Jul 2020 13:27:20 -0700 Message-ID: <159562244072.3847286.7905035931282026601@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Doug Anderson (2020-07-24 13:11:59) >=20 > I wasn't suggesting adding a timeout. I was just saying that if > claim_tcs_for_req() were to ever return an error code other than > -EBUSY that we'd need a check for it because otherwise we'd interpret > the result as a tcs_id. >=20 Ok that sounds like you don't want a check for -EBUSY so I'll leave this as >=3D 0.