From: "tip-bot2 for Ingo Molnar" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: x86/cleanups] x86/mm: Remove the unused mk_kernel_pgd() #define
Date: Sat, 25 Jul 2020 10:13:39 -0000 [thread overview]
Message-ID: <159567201969.4006.15220161067207214829.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200724114418.629021-4-mingo@kernel.org>
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 4b8e0328e56e177663645a96ea4c5c0401ecd78f
Gitweb: https://git.kernel.org/tip/4b8e0328e56e177663645a96ea4c5c0401ecd78f
Author: Ingo Molnar <mingo@kernel.org>
AuthorDate: Fri, 24 Jul 2020 13:44:18 +02:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Sat, 25 Jul 2020 12:00:57 +02:00
x86/mm: Remove the unused mk_kernel_pgd() #define
AFAICS the last uses of directly 'making' kernel PGDs was removed 7 years ago:
8b78c21d72d9: ("x86, 64bit, mm: hibernate use generic mapping_init")
Where the explicit PGD walking loop was replaced with kernel_ident_mapping_init()
calls. This was then (unnecessarily) carried over through the 5-level paging conversion.
Also clean up the 'level' comments a bit, to convey the original, meanwhile somewhat
bit-rotten notion, that these are empty comment blocks with no methods to handle any
of the levels except the PTE level.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200724114418.629021-4-mingo@kernel.org
---
arch/x86/include/asm/pgtable_64.h | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h
index 1b68d24..d2af8c4 100644
--- a/arch/x86/include/asm/pgtable_64.h
+++ b/arch/x86/include/asm/pgtable_64.h
@@ -175,16 +175,13 @@ extern void sync_global_pgds(unsigned long start, unsigned long end);
* and a page entry and page directory to the page they refer to.
*/
-/*
- * Level 4 access.
- */
-#define mk_kernel_pgd(address) __pgd((address) | _KERNPG_TABLE)
+/* PGD - Level 4 access */
-/* PUD - Level3 access */
+/* PUD - Level 3 access */
-/* PMD - Level 2 access */
+/* PMD - Level 2 access */
-/* PTE - Level 1 access. */
+/* PTE - Level 1 access */
/*
* Encode and de-code a swap entry
prev parent reply other threads:[~2020-07-25 10:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 11:44 [PATCH 0/3] x86 cleanups of leftover code Ingo Molnar
2020-07-24 11:44 ` [PATCH 1/3] x86/ioapic: Remove unused "IOAPIC_AUTO" define Ingo Molnar
2020-07-25 10:13 ` [tip: x86/cleanups] " tip-bot2 for Ingo Molnar
2020-07-24 11:44 ` [PATCH 2/3] x86/tsc: Remove unused "US_SCALE" and "NS_SCALE" leftover macros Ingo Molnar
2020-07-25 10:13 ` [tip: x86/cleanups] " tip-bot2 for Ingo Molnar
2020-07-24 11:44 ` [PATCH 3/3] x86/mm: Remove the unused mk_kernel_pgd() #define Ingo Molnar
2020-07-25 10:13 ` tip-bot2 for Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159567201969.4006.15220161067207214829.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.