From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MIME_BASE64_TEXT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB63C433E0 for ; Tue, 28 Jul 2020 03:20:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A675207CD for ; Tue, 28 Jul 2020 03:20:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jt3Iec1l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgG1DUJ (ORCPT ); Mon, 27 Jul 2020 23:20:09 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:61904 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726662AbgG1DUI (ORCPT ); Mon, 27 Jul 2020 23:20:08 -0400 X-UUID: 5849a90168044181a7e230cfd2c9819b-20200728 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=oFbqZRvunwxR2x3NX4VJTIH2wGfuuJT6jKUmQmAqW0g=; b=jt3Iec1lnqn7GQ18nhkt7gkz8PS53ZTHB+5SRPKs1TI1t1PgsVzeM0tqE1rz890m9PzVlUFFeRGFy0ztH0PPOfr16DhtBC1rjP/oLOkyL7gBSiy91i1tDGusrat4kEyHJ8U6fG+Yqielq7xMn9TeqIWf5i8Oe1Qzd7CQuAHI9As=; X-UUID: 5849a90168044181a7e230cfd2c9819b-20200728 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1135649000; Tue, 28 Jul 2020 11:20:06 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Jul 2020 11:20:03 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 28 Jul 2020 11:20:00 +0800 From: Frankie Chang To: Todd Kjos CC: Greg Kroah-Hartman , Joel Fernandes , Martijn Coenen , =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Christian Brauner , , , , Jian-Min Liu , Frankie Chang Subject: [PATCH v6 2/3] binder: add trace at free transaction. Date: Tue, 28 Jul 2020 11:20:00 +0800 Message-ID: <1595906401-11985-3-git-send-email-Frankie.Chang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1595906401-11985-1-git-send-email-Frankie.Chang@mediatek.com> References: <1595252430.5899.6.camel@mtkswgap22> <1595906401-11985-1-git-send-email-Frankie.Chang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: 5EF4B174386E5C2BBBD9CFA1E27E242358E22D020083524886B3E5F4576546E12000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogIkZyYW5raWUuQ2hhbmciIDxGcmFua2llLkNoYW5nQG1lZGlhdGVrLmNvbT4NCg0KU2lu Y2UgdGhlIG9yaWdpbmFsIHRyYWNlX2JpbmRlcl90cmFuc2FjdGlvbl9yZWNlaXZlZCBjYW5ub3QN CnByZWNpc2VseSBwcmVzZW50IHRoZSByZWFsIGZpbmlzaGVkIHRpbWUgb2YgdHJhbnNhY3Rpb24s IGFkZGluZyBhDQp0cmFjZV9iaW5kZXJfdHhuX2xhdGVuY3lfZnJlZSBhdCB0aGUgcG9pbnQgb2Yg ZnJlZSB0cmFuc2FjdGlvbg0KbWF5IGJlIG1vcmUgY2xvc2UgdG8gaXQuDQoNClNpZ25lZC1vZmYt Ynk6IEZyYW5raWUuQ2hhbmcgPEZyYW5raWUuQ2hhbmdAbWVkaWF0ZWsuY29tPg0KLS0tDQogZHJp dmVycy9hbmRyb2lkL2JpbmRlci5jICAgICAgIHwgICAgNiArKysrKysNCiBkcml2ZXJzL2FuZHJv aWQvYmluZGVyX3RyYWNlLmggfCAgIDI3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKw0KIDIg ZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9h bmRyb2lkL2JpbmRlci5jIGIvZHJpdmVycy9hbmRyb2lkL2JpbmRlci5jDQppbmRleCAyZGYxNDZm Li4xZTZmYzQwIDEwMDY0NA0KLS0tIGEvZHJpdmVycy9hbmRyb2lkL2JpbmRlci5jDQorKysgYi9k cml2ZXJzL2FuZHJvaWQvYmluZGVyLmMNCkBAIC0xNTIyLDYgKzE1MjIsOSBAQCBzdGF0aWMgdm9p ZCBiaW5kZXJfZnJlZV90cmFuc2FjdGlvbihzdHJ1Y3QgYmluZGVyX3RyYW5zYWN0aW9uICp0KQ0K IAkgKiBJZiB0aGUgdHJhbnNhY3Rpb24gaGFzIG5vIHRhcmdldF9wcm9jLCB0aGVuDQogCSAqIHQt PmJ1ZmZlci0+dHJhbnNhY3Rpb24gaGFzIGFscmVhZHkgYmVlbiBjbGVhcmVkLg0KIAkgKi8NCisJ c3Bpbl9sb2NrKCZ0LT5sb2NrKTsNCisJdHJhY2VfYmluZGVyX3R4bl9sYXRlbmN5X2ZyZWUodCk7 DQorCXNwaW5fdW5sb2NrKCZ0LT5sb2NrKTsNCiAJYmluZGVyX2ZyZWVfdHhuX2ZpeHVwcyh0KTsN CiAJa2ZyZWUodCk7DQogCWJpbmRlcl9zdGF0c19kZWxldGVkKEJJTkRFUl9TVEFUX1RSQU5TQUNU SU9OKTsNCkBAIC0zMDkzLDYgKzMwOTYsOSBAQCBzdGF0aWMgdm9pZCBiaW5kZXJfdHJhbnNhY3Rp b24oc3RydWN0IGJpbmRlcl9wcm9jICpwcm9jLA0KIAlrZnJlZSh0Y29tcGxldGUpOw0KIAliaW5k ZXJfc3RhdHNfZGVsZXRlZChCSU5ERVJfU1RBVF9UUkFOU0FDVElPTl9DT01QTEVURSk7DQogZXJy X2FsbG9jX3Rjb21wbGV0ZV9mYWlsZWQ6DQorCXNwaW5fbG9jaygmdC0+bG9jayk7DQorCXRyYWNl X2JpbmRlcl90eG5fbGF0ZW5jeV9mcmVlKHQpOw0KKwlzcGluX3VubG9jaygmdC0+bG9jayk7DQog CWtmcmVlKHQpOw0KIAliaW5kZXJfc3RhdHNfZGVsZXRlZChCSU5ERVJfU1RBVF9UUkFOU0FDVElP Tik7DQogZXJyX2FsbG9jX3RfZmFpbGVkOg0KZGlmZiAtLWdpdCBhL2RyaXZlcnMvYW5kcm9pZC9i aW5kZXJfdHJhY2UuaCBiL2RyaXZlcnMvYW5kcm9pZC9iaW5kZXJfdHJhY2UuaA0KaW5kZXggNjcz MWMzYy4uOGFjODdkMSAxMDA2NDQNCi0tLSBhL2RyaXZlcnMvYW5kcm9pZC9iaW5kZXJfdHJhY2Uu aA0KKysrIGIvZHJpdmVycy9hbmRyb2lkL2JpbmRlcl90cmFjZS5oDQpAQCAtOTUsNiArOTUsMzMg QEANCiAJCSAgX19lbnRyeS0+dGhyZWFkX3RvZG8pDQogKTsNCiANCitUUkFDRV9FVkVOVChiaW5k ZXJfdHhuX2xhdGVuY3lfZnJlZSwNCisJVFBfUFJPVE8oc3RydWN0IGJpbmRlcl90cmFuc2FjdGlv biAqdCksDQorCVRQX0FSR1ModCksDQorCVRQX1NUUlVDVF9fZW50cnkoDQorCQlfX2ZpZWxkKGlu dCwgZGVidWdfaWQpDQorCQlfX2ZpZWxkKGludCwgZnJvbV9wcm9jKQ0KKwkJX19maWVsZChpbnQs IGZyb21fdGhyZWFkKQ0KKwkJX19maWVsZChpbnQsIHRvX3Byb2MpDQorCQlfX2ZpZWxkKGludCwg dG9fdGhyZWFkKQ0KKwkJX19maWVsZCh1bnNpZ25lZCBpbnQsIGNvZGUpDQorCQlfX2ZpZWxkKHVu c2lnbmVkIGludCwgZmxhZ3MpDQorCSksDQorCVRQX2Zhc3RfYXNzaWduKA0KKwkJX19lbnRyeS0+ ZGVidWdfaWQgPSB0LT5kZWJ1Z19pZDsNCisJCV9fZW50cnktPmZyb21fcHJvYyA9IHQtPmZyb20g PyB0LT5mcm9tLT5wcm9jLT5waWQgOiAwOw0KKwkJX19lbnRyeS0+ZnJvbV90aHJlYWQgPSB0LT5m cm9tID8gdC0+ZnJvbS0+cGlkIDogMDsNCisJCV9fZW50cnktPnRvX3Byb2MgPSB0LT50b19wcm9j ID8gdC0+dG9fcHJvYy0+cGlkIDogMDsNCisJCV9fZW50cnktPnRvX3RocmVhZCA9IHQtPnRvX3Ro cmVhZCA/IHQtPnRvX3RocmVhZC0+cGlkIDogMDsNCisJCV9fZW50cnktPmNvZGUgPSB0LT5jb2Rl Ow0KKwkJX19lbnRyeS0+ZmxhZ3MgPSB0LT5mbGFnczsNCisJKSwNCisJVFBfcHJpbnRrKCJ0cmFu c2FjdGlvbj0lZCBmcm9tICVkOiVkIHRvICVkOiVkIGZsYWdzPTB4JXggY29kZT0weCV4IiwNCisJ CSAgX19lbnRyeS0+ZGVidWdfaWQsIF9fZW50cnktPmZyb21fcHJvYywgX19lbnRyeS0+ZnJvbV90 aHJlYWQsDQorCQkgIF9fZW50cnktPnRvX3Byb2MsIF9fZW50cnktPnRvX3RocmVhZCwgX19lbnRy eS0+Y29kZSwNCisJCSAgX19lbnRyeS0+ZmxhZ3MpDQorKTsNCisNCiBUUkFDRV9FVkVOVChiaW5k ZXJfdHJhbnNhY3Rpb24sDQogCVRQX1BST1RPKGJvb2wgcmVwbHksIHN0cnVjdCBiaW5kZXJfdHJh bnNhY3Rpb24gKnQsDQogCQkgc3RydWN0IGJpbmRlcl9ub2RlICp0YXJnZXRfbm9kZSksDQotLSAN CjEuNy45LjUNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D4D4C433E4 for ; Tue, 28 Jul 2020 03:28:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EDB12072E for ; Tue, 28 Jul 2020 03:28:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aDk3GaM2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="I0SP9bMb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EDB12072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1nKO9a8eraQhwJUU2hal7kxvsYY9oAZAWbFFlIh8YrM=; b=aDk3GaM2UnaJnDH80M241amAp KjU2hYjHyZO1iVc9wq12pGUBcfAtpLU66B4c3Qqhkqm0znHBrRtPy04/tf2jj42SRI6kOmw1nZYfW fmqVE+zocZ8bPbt7IaHuJgESa2t1T3Xu8aRoDmLFvS9DCExb2nqpBoAExtQFmTl4TrQKBL754uiP6 cYh+29Uiw74C3QWZdSxkChAIgjT1Gt9qww6nVe4lsszObyfWytSfrFofJozk/G6X0HQB+PpOJJujh 5Zy57QCCl747qr48JbLm6LKHRA9wV2nxBz1ZjlD3Y5EffbRDXI0F3gYtAXye9HLgnany2pnK8zOMQ KA4HRB05g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0GHo-00030L-9A; Tue, 28 Jul 2020 03:28:16 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0GHm-0002z8-3S for linux-mediatek@lists.infradead.org; Tue, 28 Jul 2020 03:28:15 +0000 X-UUID: 7a10cf3bc0214095a055966b33ced91f-20200727 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=oFbqZRvunwxR2x3NX4VJTIH2wGfuuJT6jKUmQmAqW0g=; b=I0SP9bMbsALP5Iumc87b64j7ptWCSGvj11dvwGpYK4RPmjRcHA22j/VV7vpNaQtH+YH/NsLjDYGiszwMOWdS8ibVMVW79Rn3l+Jg9Hy1JsDM+Dbnhmp5WhS1i2gUfYW1oc/bR8kaHgRCCLYFhjLfbqiZOmleQjTIzbybW0fkiDE=; X-UUID: 7a10cf3bc0214095a055966b33ced91f-20200727 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 687554323; Mon, 27 Jul 2020 19:28:12 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 27 Jul 2020 20:20:05 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 Jul 2020 11:20:03 +0800 Received: from mtkswgap22.mediatek.inc (172.21.77.33) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 28 Jul 2020 11:20:00 +0800 From: Frankie Chang To: Todd Kjos Subject: [PATCH v6 2/3] binder: add trace at free transaction. Date: Tue, 28 Jul 2020 11:20:00 +0800 Message-ID: <1595906401-11985-3-git-send-email-Frankie.Chang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1595906401-11985-1-git-send-email-Frankie.Chang@mediatek.com> References: <1595252430.5899.6.camel@mtkswgap22> <1595906401-11985-1-git-send-email-Frankie.Chang@mediatek.com> MIME-Version: 1.0 X-TM-SNTS-SMTP: 5EF4B174386E5C2BBBD9CFA1E27E242358E22D020083524886B3E5F4576546E12000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_232814_365242_795282A6 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Jian-Min Liu , linux-mediatek@lists.infradead.org, Joel Fernandes , Frankie Chang , Martijn Coenen , Christian Brauner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: "Frankie.Chang" Since the original trace_binder_transaction_received cannot precisely present the real finished time of transaction, adding a trace_binder_txn_latency_free at the point of free transaction may be more close to it. Signed-off-by: Frankie.Chang --- drivers/android/binder.c | 6 ++++++ drivers/android/binder_trace.h | 27 +++++++++++++++++++++++++++ 2 files changed, 33 insertions(+) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 2df146f..1e6fc40 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -1522,6 +1522,9 @@ static void binder_free_transaction(struct binder_transaction *t) * If the transaction has no target_proc, then * t->buffer->transaction has already been cleared. */ + spin_lock(&t->lock); + trace_binder_txn_latency_free(t); + spin_unlock(&t->lock); binder_free_txn_fixups(t); kfree(t); binder_stats_deleted(BINDER_STAT_TRANSACTION); @@ -3093,6 +3096,9 @@ static void binder_transaction(struct binder_proc *proc, kfree(tcomplete); binder_stats_deleted(BINDER_STAT_TRANSACTION_COMPLETE); err_alloc_tcomplete_failed: + spin_lock(&t->lock); + trace_binder_txn_latency_free(t); + spin_unlock(&t->lock); kfree(t); binder_stats_deleted(BINDER_STAT_TRANSACTION); err_alloc_t_failed: diff --git a/drivers/android/binder_trace.h b/drivers/android/binder_trace.h index 6731c3c..8ac87d1 100644 --- a/drivers/android/binder_trace.h +++ b/drivers/android/binder_trace.h @@ -95,6 +95,33 @@ __entry->thread_todo) ); +TRACE_EVENT(binder_txn_latency_free, + TP_PROTO(struct binder_transaction *t), + TP_ARGS(t), + TP_STRUCT__entry( + __field(int, debug_id) + __field(int, from_proc) + __field(int, from_thread) + __field(int, to_proc) + __field(int, to_thread) + __field(unsigned int, code) + __field(unsigned int, flags) + ), + TP_fast_assign( + __entry->debug_id = t->debug_id; + __entry->from_proc = t->from ? t->from->proc->pid : 0; + __entry->from_thread = t->from ? t->from->pid : 0; + __entry->to_proc = t->to_proc ? t->to_proc->pid : 0; + __entry->to_thread = t->to_thread ? t->to_thread->pid : 0; + __entry->code = t->code; + __entry->flags = t->flags; + ), + TP_printk("transaction=%d from %d:%d to %d:%d flags=0x%x code=0x%x", + __entry->debug_id, __entry->from_proc, __entry->from_thread, + __entry->to_proc, __entry->to_thread, __entry->code, + __entry->flags) +); + TRACE_EVENT(binder_transaction, TP_PROTO(bool reply, struct binder_transaction *t, struct binder_node *target_node), -- 1.7.9.5 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek