From: Peter Maydell <1889288@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1889288] Re: aarch64 BICS instruciton doesn't set flags
Date: Tue, 28 Jul 2020 18:01:36 -0000 [thread overview]
Message-ID: <159595929665.16561.12945967811327222694.malone@wampee.canonical.com> (raw)
In-Reply-To: 159595596008.2765.9252796063113419577.malonedeb@gac.canonical.com
The code is correct (though it is admittedly not entirely obvious at
first glance). The switch statement at line 4753 is on "(opc | (invert
<< 2))" (where opc is a 2 bit field and invert a 1 bit field). Both ANDS
and BICS have opc==3 and so will cause a call to gen_logic_CC(). The
difference between the two insns is that ANDC has invert==0 and BICS has
invert==1.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1889288
Title:
aarch64 BICS instruciton doesn't set flags
Status in QEMU:
Invalid
Bug description:
When reading the source for translate-a64.c here:
https://github.com/qemu/qemu/blob/a466dd084f51cdc9da2e99361f674f98d7218559/target/arm/translate-a64.c#L4783
I noticed that it does not appear to call gen_logic_CC for the BICS
instruction so is not setting the flags as required. I haven't tried
to produce a test case for it but it seems like it might be a bug.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1889288/+subscriptions
next prev parent reply other threads:[~2020-07-28 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 17:05 [Bug 1889288] [NEW] aarch64 BICS instruciton doesn't set flags Robert
2020-07-28 18:01 ` Peter Maydell [this message]
2020-07-28 20:42 ` [Bug 1889288] " Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159595929665.16561.12945967811327222694.malone@wampee.canonical.com \
--to=1889288@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.