From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577DAC433E1 for ; Wed, 29 Jul 2020 08:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3488E2076E for ; Wed, 29 Jul 2020 08:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HE7sii7h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbgG2ImU (ORCPT ); Wed, 29 Jul 2020 04:42:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgG2ImT (ORCPT ); Wed, 29 Jul 2020 04:42:19 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35743C061794 for ; Wed, 29 Jul 2020 01:42:18 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id m16so11501593pls.5 for ; Wed, 29 Jul 2020 01:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=aXoZD/sjDpEWgC90G0tbRlSg3ouqwk6Z53e9x6lUnWY=; b=HE7sii7hRjjmvwiQRJOVtVBeV9zc60V2y/ZRFYjWEIauLK/87smb8yCZAcQZQ7eLeH /PNdn74/kEGw5U9SoetNDcwWg9KOtEh4SqEn4EQxKvxB4p+v4qaC/0xNeCp02ANp+Mkh RRYhLZbrw9FAEJ1p5c/tNj9pejdsXD352HmNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=aXoZD/sjDpEWgC90G0tbRlSg3ouqwk6Z53e9x6lUnWY=; b=n6zhI5ya5vqVl19wZDSerkFizFlC2g2BerUomqGw0mIkQ4SI5j0a2EUO6MvX+q1YGH SBIU6hA8eeSrdLubU58QGB27DNoPiCALguVhTYTaqDuDb/IxJMcg/lMDxYrVUyg5E6Sg dKJWU1eH70SGFfb2n46b0ANVEy6TEhlSFRm8oDCOJHMKwWzIgiXVjYlau/SNiAwZBSGc SUkqllwFyMpf050leUQXtsBHzX4nLdfmHXUofy8+VYnb0FiwDhBd2OpaDBfzN7whGHi9 cJqpQOdUoMMN0cq12twwbvSuTp5pmO7N63Zx68SxpfAeZvTD40NX4kTFTPL7im/o74NX pPhg== X-Gm-Message-State: AOAM532LihoXLRJwwrY8cP3IyLKIoncUpn/KKrLWuUMpj8RHLHQKoyB5 TxFqwPe+3sdZfHIqFdbohQZbAg== X-Google-Smtp-Source: ABdhPJz1X/KuaL0DEpVO+OTg+AJlQykKUWOCJVQK39D8e0v6ixdTAsLkfpq/NI9BVxB0c1I9xGaRXg== X-Received: by 2002:a17:90a:fa8c:: with SMTP id cu12mr8917242pjb.229.1596012137807; Wed, 29 Jul 2020 01:42:17 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:3e52:82ff:fe6c:83ab]) by smtp.gmail.com with ESMTPSA id y198sm1591486pfg.116.2020.07.29.01.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2020 01:42:17 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200728170317.v2.10.I071b118136317d3ff77fc598079f21e4ed0e347f@changeid> References: <20200728151258.1222876-1-campello@chromium.org> <20200728230520.2011240-1-campello@chromium.org> <20200728170317.v2.10.I071b118136317d3ff77fc598079f21e4ed0e347f@changeid> Subject: Re: [PATCH v2 10/14] iio: sx9310: Simplify error return handling From: Stephen Boyd Cc: Jonathan Cameron , Daniel Campello , Andy Shevchenko , Douglas Anderson , Enrico Granata , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org To: Daniel Campello , LKML , LKML Date: Wed, 29 Jul 2020 01:42:15 -0700 Message-ID: <159601213589.1360974.3536496595430081422@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Daniel Campello (2020-07-28 16:05:16) > Checks for non-zero return values to signal error conditions. >=20 > Signed-off-by: Daniel Campello > Reviewed-by: Andy Shevchenko > --- Reviewed-by: Stephen Boyd The mutex_lock, unlock, wait, lock, check wait, unlock sequence can be improved in another patch.