From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390D9C04AB6 for ; Fri, 31 May 2019 14:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 070D926B1B for ; Fri, 31 May 2019 14:56:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OmgbsuxQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbfEaO4N (ORCPT ); Fri, 31 May 2019 10:56:13 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40463 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726501AbfEaO4M (ORCPT ); Fri, 31 May 2019 10:56:12 -0400 Received: by mail-pf1-f196.google.com with SMTP id u17so6360702pfn.7 for ; Fri, 31 May 2019 07:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=XKYEbc4g3xx5Kespd2rSqwj6hjN41j8NXsg5PsoK/zc=; b=OmgbsuxQQb7QGFaagUtR3GO/1FgQJQwveae/3nS8I5TDH9LDvJLDwOwaSX9KNYSJAD P7+u0WH58s+ZJPf1pJAZYs5ImZGM9NDCaVrSKljYwvuntl7evtHy/Ekm2J8YL/mKHWEV gEDnp3Wwr/sYGHobYQEwuTLWW5m++A76OM1YbM5z9+zMvhm2QQ//P8jsfTgq5M2Oy6PP 0lulUASGPUfRrPLL7Vlpr7OUjc6EW00wfs4+Ktrd4bvkLJ2SSvRCzuRPA6SgLuwK0duO zxaJlzW8AHZ2eE0SC5e5xXtNUy5dmZoKqVsKl+KYLPTVqje8Vk/tL3FdA1e1iQ+sD8ud xXtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XKYEbc4g3xx5Kespd2rSqwj6hjN41j8NXsg5PsoK/zc=; b=I1Rkw3MtB3DlSEPcZu7L/wjAD1ROje77EodnC6eP4TFdhmWSIdFYhqAX1qwnwjOmqi a+QYWOEaE6XSyr5ZEsUWBtmvpovdVn9TZkWVslwgbJYT3Nq9bO0BmZ8wmbthAuNNI0xF sICqrl7Ln/05SQjrffQqiL2peC+9jeJ3jj6ne8yRXSpKAbw4cVaClJl4wQYi9kGlSmt4 NzrZ9A87HU8FrfAAjCqbyO58trqq6m8Lq78yEoJdOWeg53zPmRJXRRrF+DW12+6Zt+Fw I20ZjyQITLCo6HN7OCtLObPn+XLBJ/hUrzJYJY49sdqrsrRM97oIIosVgQ5GLLSKzITn Dl+g== X-Gm-Message-State: APjAAAWr9sXnuqBxx2dvq4bUu9rn6ojdIeiT0Cv+tf+Z2E6SafrmHLcg AvXkvFD4LBm5UWh4g9fSd3bee4Ye X-Google-Smtp-Source: APXvYqxLxEDFjkAbhyU5yv8zA1huwzbv2U2LD23ERx1MWyinZ9cqfFXHrW/o8RimfY0YVZOdcwmpwQ== X-Received: by 2002:a62:1a51:: with SMTP id a78mr10728579pfa.39.1559314571852; Fri, 31 May 2019 07:56:11 -0700 (PDT) Received: from [192.168.84.42] (8.100.247.35.bc.googleusercontent.com. [35.247.100.8]) by smtp.gmail.com with ESMTPSA id u4sm6400186pfu.26.2019.05.31.07.56.10 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 31 May 2019 07:56:11 -0700 (PDT) Subject: Re: [PATCH] net/neighbour: fix potential null pointer deference To: Young Xiao <92siuyang@gmail.com>, davem@davemloft.net, dsahern@gmail.com, roopa@cumulusnetworks.com, christian@brauner.io, khlebnikov@yandex-team.ru, netdev@vger.kernel.org References: <1559291383-5814-1-git-send-email-92siuyang@gmail.com> From: Eric Dumazet Message-ID: <15960edf-b5b7-ea53-c48a-e459280547a6@gmail.com> Date: Fri, 31 May 2019 07:56:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1559291383-5814-1-git-send-email-92siuyang@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 5/31/19 1:29 AM, Young Xiao wrote: > There is a possible null pointer deference bugs in neigh_fill_info(), > which is similar to the bug which was fixed in commit 6adc5fd6a142 > ("net/neighbour: fix crash at dumping device-agnostic proxy entries"). > > Signed-off-by: Young Xiao <92siuyang@gmail.com> > --- > net/core/neighbour.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index dfa8710..33c3ff1 100644 > --- a/net/core/neighbour.c > +++ b/net/core/neighbour.c > @@ -2440,7 +2440,7 @@ static int neigh_fill_info(struct sk_buff *skb, struct neighbour *neigh, > ndm->ndm_pad2 = 0; > ndm->ndm_flags = neigh->flags; > ndm->ndm_type = neigh->type; > - ndm->ndm_ifindex = neigh->dev->ifindex; > + ndm->ndm_ifindex = neigh->dev ? neigh->dev->ifindex : 0; > > if (nla_put(skb, NDA_DST, neigh->tbl->key_len, neigh->primary_key)) > goto nla_put_failure; > When was the bug added exactly ? Hint : We want a Fixes: tag, so that we can fully understand the issue and make sure the fix is complete. Otherwise, your patch might very well have been randomly generated by a bot. Thank you.