From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052F6C433DF for ; Mon, 3 Aug 2020 09:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8C6820722 for ; Mon, 3 Aug 2020 09:44:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="dAaHRELa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbgHCJoY (ORCPT ); Mon, 3 Aug 2020 05:44:24 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:41323 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725968AbgHCJoX (ORCPT ); Mon, 3 Aug 2020 05:44:23 -0400 X-UUID: 3ac428711cf848909e39cce4385870c7-20200803 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ZhKk3+aYfBtmyDfjmtzRdC9n/uCOzIpf/GjJwiyB4Og=; b=dAaHRELah656k8mrFCHfIOihZ5+eBWflnkiktZdcDtNO+x/0h7R+gzMEyhQleGlB4XIhuxUMxJTZMXOxC1Hpm00CQst2EuxseGTHesvJ0uK8waLOXZbXikTFlD9os4UmsNevcFm33nCXMclVjk/c2sFB0dnT+WLlqN2KwuUV7ik=; X-UUID: 3ac428711cf848909e39cce4385870c7-20200803 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1170194191; Mon, 03 Aug 2020 17:44:18 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 17:44:15 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkcas08.mediatek.inc (172.21.101.126) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 17:44:15 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Aug 2020 17:44:15 +0800 Message-ID: <1596447857.32283.24.camel@mtkswgap22> Subject: Re: [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully From: Stanley Chu To: Can Guo CC: , , , , , , , , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , "Bean Huo" , Bart Van Assche , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Date: Mon, 3 Aug 2020 17:44:17 +0800 In-Reply-To: <1596445485-19834-10-git-send-email-cang@codeaurora.org> References: <1596445485-19834-1-git-send-email-cang@codeaurora.org> <1596445485-19834-10-git-send-email-cang@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIwLTA4LTAzIGF0IDAyOjA0IC0wNzAwLCBDYW4gR3VvIHdyb3RlOg0KPiBJbiBj dXJyZW50IFVGUyB0YXNrIGFib3J0IGhvb2ssIG5hbWVseSB1ZnNoY2RfYWJvcnQoKSwgaWYgYSB0 YXNrIGlzDQo+IGFib3J0ZWQgc3VjY2Vzc2Z1bGx5LCBjbG9jayBzY2FsaW5nIGJ1c3kgdGltZSBz dGF0aXN0aWNzIGlzIG5vdCB1cGRhdGVkDQo+IGFuZCwgbW9zdCBpbXBvcnRhbnQsIGNsa19nYXRp bmcuYWN0aXZlX3JlcXMgaXMgbm90IGRlY3JlYXNlZCwgd2hpY2ggbWFrZXMNCj4gY2xrX2dhdGlu Zy5hY3RpdmVfcmVxcyBzdGF5IGFib3ZlIHplcm8gZm9yZXZlciwgdGh1cyBjbG9jayBnYXRpbmcg d291bGQNCj4gbmV2ZXIgaGFwcGVuLiBUbyBmaXggaXQsIGluc3RlYWQgb2YgcmVsZWFzaW5nIHJl c291cmNlcyAibWFubnVhbGx5IiwgdXNlDQo+IHRoZSBleGlzdGluZyBmdW5jIF9fdWZzaGNkX3Ry YW5zZmVyX3JlcV9jb21wbCgpLiBUaGlzIGNhbiBhbHNvIGVsaW1pbmF0ZQ0KPiByYWNpbmcgb2Yg c2NzaV9kbWFfdW5tYXAoKSBmcm9tIHRoZSByZWFsIGNvbXBsZXRpb24gaW4gSVJRIGhhbmRsZXIg cGF0aC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IENhbiBHdW8gPGNhbmdAY29kZWF1cm9yYS5vcmc+ DQo+IENDOiBTdGFubGV5IENodSA8c3RhbmxleS5jaHVAbWVkaWF0ZWsuY29tPg0KPiAtLS0NCj4g IGRyaXZlcnMvc2NzaS91ZnMvdWZzaGNkLmMgfCA1ICstLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwg MSBpbnNlcnRpb24oKyksIDQgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9zY3NpL3Vmcy91ZnNoY2QuYyBiL2RyaXZlcnMvc2NzaS91ZnMvdWZzaGNkLmMNCj4gaW5kZXgg ZDdkMjc1OC4uOWE0ODM4OSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2Qu Yw0KPiArKysgYi9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC5jDQo+IEBAIC02NjM1LDExICs2NjM1 LDggQEAgc3RhdGljIGludCB1ZnNoY2RfYWJvcnQoc3RydWN0IHNjc2lfY21uZCAqY21kKQ0KPiAg CQlnb3RvIG91dDsNCj4gIAl9DQo+ICANCj4gLQlzY3NpX2RtYV91bm1hcChjbWQpOw0KPiAtDQo+ ICAJc3Bpbl9sb2NrX2lycXNhdmUoaG9zdC0+aG9zdF9sb2NrLCBmbGFncyk7DQo+IC0JdWZzaGNk X291dHN0YW5kaW5nX3JlcV9jbGVhcihoYmEsIHRhZyk7DQo+IC0JaGJhLT5scmJbdGFnXS5jbWQg PSBOVUxMOw0KPiArCV9fdWZzaGNkX3RyYW5zZmVyX3JlcV9jb21wbChoYmEsICgxVUwgPDwgdGFn KSk7DQo+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZShob3N0LT5ob3N0X2xvY2ssIGZsYWdzKTsN Cj4gIA0KPiAgb3V0Og0KDQpSZXZpZXdlZC1ieTogU3RhbmxleSBDaHUgPHN0YW5sZXkuY2h1QG1l ZGlhdGVrLmNvbT4NCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5472C433E0 for ; Mon, 3 Aug 2020 09:45:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24F6420722 for ; Mon, 3 Aug 2020 09:45:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aB1KUaPk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="dAaHRELa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24F6420722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sO4Jv7oKrPV36u5cXEVeI+Wyj9xsqBbKSqC0OQ4tyNE=; b=aB1KUaPkocGHdFLzJbyumtfgp Fm9b4zexjNiVb4qXoIiHbT4gzRa6FDK9SsaK7wjFfGKUQSI3rt+2IzTcWKOuSw+Ju2AVusZyRWXuH XWPQuEtgaBnZS9v6wNsi0kc7I+o+/S2mHIeqH25rtlnjagpaauFbxgt1fdMDtoU3FnFcCYVmlESCl 5CeIzwO+iJTNYmIXf9qh0w5nAlnfPIqln4aiJdCt3SXO3bwMyuC5yCnbDtpmGvifE/KfPMeBkV/94 grRFUE20YtU9NS5YrDX5T/PRlRfg4qTgd03v7lAL7pgfITV/XHvL0izs7hwAA5Ms+5LQaPHhcyOAo 5pI3nyQiA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2X1S-00014o-Sf; Mon, 03 Aug 2020 09:44:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2X15-0000oT-9U; Mon, 03 Aug 2020 09:44:25 +0000 X-UUID: 159649abaec74751ae58fdfb89706413-20200803 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ZhKk3+aYfBtmyDfjmtzRdC9n/uCOzIpf/GjJwiyB4Og=; b=dAaHRELah656k8mrFCHfIOihZ5+eBWflnkiktZdcDtNO+x/0h7R+gzMEyhQleGlB4XIhuxUMxJTZMXOxC1Hpm00CQst2EuxseGTHesvJ0uK8waLOXZbXikTFlD9os4UmsNevcFm33nCXMclVjk/c2sFB0dnT+WLlqN2KwuUV7ik=; X-UUID: 159649abaec74751ae58fdfb89706413-20200803 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1465528572; Mon, 03 Aug 2020 01:44:12 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 02:44:16 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkcas08.mediatek.inc (172.21.101.126) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 17:44:15 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Aug 2020 17:44:15 +0800 Message-ID: <1596447857.32283.24.camel@mtkswgap22> Subject: Re: [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully From: Stanley Chu To: Can Guo Date: Mon, 3 Aug 2020 17:44:17 +0800 In-Reply-To: <1596445485-19834-10-git-send-email-cang@codeaurora.org> References: <1596445485-19834-1-git-send-email-cang@codeaurora.org> <1596445485-19834-10-git-send-email-cang@codeaurora.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_054423_698147_6C5C9460 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:ARM/Mediatek SoC support" , rnayak@codeaurora.org, saravanak@google.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley" , nguyenb@codeaurora.org, open list , Avri Altman , "moderated list:ARM/Mediatek SoC support" , salyzyn@google.com, Alim Akhtar , "Martin K. Petersen" , Matthias Brugger , Bean Huo , kernel-team@android.com, Bart Van Assche , hongwus@codeaurora.org, asutoshd@codeaurora.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2020-08-03 at 02:04 -0700, Can Guo wrote: > In current UFS task abort hook, namely ufshcd_abort(), if a task is > aborted successfully, clock scaling busy time statistics is not updated > and, most important, clk_gating.active_reqs is not decreased, which makes > clk_gating.active_reqs stay above zero forever, thus clock gating would > never happen. To fix it, instead of releasing resources "mannually", use > the existing func __ufshcd_transfer_req_compl(). This can also eliminate > racing of scsi_dma_unmap() from the real completion in IRQ handler path. > > Signed-off-by: Can Guo > CC: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index d7d2758..9a48389 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6635,11 +6635,8 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) > goto out; > } > > - scsi_dma_unmap(cmd); > - > spin_lock_irqsave(host->host_lock, flags); > - ufshcd_outstanding_req_clear(hba, tag); > - hba->lrb[tag].cmd = NULL; > + __ufshcd_transfer_req_compl(hba, (1UL << tag)); > spin_unlock_irqrestore(host->host_lock, flags); > > out: Reviewed-by: Stanley Chu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B520C433DF for ; Mon, 3 Aug 2020 09:46:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37C222076C for ; Mon, 3 Aug 2020 09:46:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QoIRxZV8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="dAaHRELa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37C222076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LIm0VPEjoskJQzcig5QNJkQgRZs6RHYumKXPx7RZQUo=; b=QoIRxZV8OYa3xdIJaYo6C8N4q J6hOleI7ZQpS6QJGdV6XQJgTc6TxFG8GCZhKxgC9q761Y8a7/0WPopG5/X8FQApnDFNSscgqBBpnG Gu4ZxUqNglWw1A7ybJRvWeCSJ2z070oP82/dGM2lZhuXQYVPsR6aoz5f78q/6ZwdmJtlLHSNKC/8U MR9QDGtStm8dBxv0zW/HCcKkBKvKCVPbd9zpZREfLj84cDJxvCC/RVNWKLvPTslM2gtXrR7spc0pH yeMUZuuAkIb9j1XCKe4lxqm/49QE1TxMreGmBLd0dDCzsd0BMIdjqx9VUHVHsDtRCQMvtWWIGQCEs 3lMmyp2pQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2X1Z-00019n-T7; Mon, 03 Aug 2020 09:44:55 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2X15-0000oT-9U; Mon, 03 Aug 2020 09:44:25 +0000 X-UUID: 159649abaec74751ae58fdfb89706413-20200803 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=ZhKk3+aYfBtmyDfjmtzRdC9n/uCOzIpf/GjJwiyB4Og=; b=dAaHRELah656k8mrFCHfIOihZ5+eBWflnkiktZdcDtNO+x/0h7R+gzMEyhQleGlB4XIhuxUMxJTZMXOxC1Hpm00CQst2EuxseGTHesvJ0uK8waLOXZbXikTFlD9os4UmsNevcFm33nCXMclVjk/c2sFB0dnT+WLlqN2KwuUV7ik=; X-UUID: 159649abaec74751ae58fdfb89706413-20200803 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1465528572; Mon, 03 Aug 2020 01:44:12 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 02:44:16 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkcas08.mediatek.inc (172.21.101.126) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 Aug 2020 17:44:15 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 3 Aug 2020 17:44:15 +0800 Message-ID: <1596447857.32283.24.camel@mtkswgap22> Subject: Re: [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully From: Stanley Chu To: Can Guo Date: Mon, 3 Aug 2020 17:44:17 +0800 In-Reply-To: <1596445485-19834-10-git-send-email-cang@codeaurora.org> References: <1596445485-19834-1-git-send-email-cang@codeaurora.org> <1596445485-19834-10-git-send-email-cang@codeaurora.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_054423_698147_6C5C9460 X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:ARM/Mediatek SoC support" , rnayak@codeaurora.org, saravanak@google.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley" , nguyenb@codeaurora.org, open list , Avri Altman , "moderated list:ARM/Mediatek SoC support" , salyzyn@google.com, Alim Akhtar , "Martin K. Petersen" , Matthias Brugger , Bean Huo , kernel-team@android.com, Bart Van Assche , hongwus@codeaurora.org, asutoshd@codeaurora.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-08-03 at 02:04 -0700, Can Guo wrote: > In current UFS task abort hook, namely ufshcd_abort(), if a task is > aborted successfully, clock scaling busy time statistics is not updated > and, most important, clk_gating.active_reqs is not decreased, which makes > clk_gating.active_reqs stay above zero forever, thus clock gating would > never happen. To fix it, instead of releasing resources "mannually", use > the existing func __ufshcd_transfer_req_compl(). This can also eliminate > racing of scsi_dma_unmap() from the real completion in IRQ handler path. > > Signed-off-by: Can Guo > CC: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index d7d2758..9a48389 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -6635,11 +6635,8 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) > goto out; > } > > - scsi_dma_unmap(cmd); > - > spin_lock_irqsave(host->host_lock, flags); > - ufshcd_outstanding_req_clear(hba, tag); > - hba->lrb[tag].cmd = NULL; > + __ufshcd_transfer_req_compl(hba, (1UL << tag)); > spin_unlock_irqrestore(host->host_lock, flags); > > out: Reviewed-by: Stanley Chu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel