From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90581C433DF for ; Mon, 3 Aug 2020 21:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A349D208C7 for ; Mon, 3 Aug 2020 21:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596490045; bh=SEWW09/i+04+jjvVuA9NB1iGYFQ/+Gb2zPeEc9SAtPI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=cxxD/QwKEM8WIrdJBDrTxOS9iGVudNI4dObBLwap2kInMYBdCkYr7zOXwR4I0Eg8l ScVTD5LWirHNbvyUoBOHrZPh9cgt8oSdx5g8vPnjAjNNBTNApUTAuHhvO+jSLeFxiR C2feZJVNH/Rp7TxFMN+UIyfoGpwDxXiWOh/Qphf0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729113AbgHCV1Y (ORCPT ); Mon, 3 Aug 2020 17:27:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:47468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726398AbgHCV1X (ORCPT ); Mon, 3 Aug 2020 17:27:23 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACF2C207DF; Mon, 3 Aug 2020 21:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596490043; bh=SEWW09/i+04+jjvVuA9NB1iGYFQ/+Gb2zPeEc9SAtPI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=fKraf1DqTK0sVAU2Wtz2SmkZ8NLOotp3LiIuxM3o3RlO6RPHjb25lL4EmJ4Klx/rT TNxFCNmgzFyC7a6fKwBaVGUPHU4sHqw3J9DCkXSMrNi2k4fiO8OJcLyoLrp26e/+0L i2jpkTYD8p0EVnDCgqcjs8Dt6NYUqq2NR9tOs+9o= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200730182619.23246-1-nsaenzjulienne@suse.de> References: <20200730182619.23246-1-nsaenzjulienne@suse.de> Subject: Re: [PATCH v2] clk: bcm2835: Do not use prediv with bcm2711's PLLs From: Stephen Boyd Cc: pbrobinson@gmail.com, kernel-list@raspberrypi.com, Nathan Chancellor , Michael Turquette , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Eric Anholt , Florian Fainelli , Matthias Brugger , Nicolas Saenz Julienne , Ray Jui , Scott Branden , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com Date: Mon, 03 Aug 2020 14:27:22 -0700 Message-ID: <159649004236.1360974.8603728575729464532@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Nicolas Saenz Julienne (2020-07-30 11:26:19) > Contrary to previous SoCs, bcm2711 doesn't have a prescaler in the PLL > feedback loop. Bypass it by zeroing fb_prediv_mask when running on > bcm2711. >=20 > Note that, since the prediv configuration bits were re-purposed, this > was triggering miscalculations on all clocks hanging from the VPU clock, > notably the aux UART, making its output unintelligible. >=20 > Fixes: 42de9ad400af ("clk: bcm2835: Add BCM2711_CLOCK_EMMC2 support") > Reported-by: Nathan Chancellor > Signed-off-by: Nicolas Saenz Julienne > --- Applied to clk-next From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A7CC433DF for ; Mon, 3 Aug 2020 21:28:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 226A2207DF for ; Mon, 3 Aug 2020 21:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L25H3cpB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fKraf1Dq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 226A2207DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wnBiCdFVWZDZ4vTnKOPt9+KIV+6xAs447qnJZrtxe2Q=; b=L25H3cpBrbwZZd8Sw0qzQ5cuK VaVmujaUlTWzqHbVCy2YXdeLvgXqsgUBTrYU+PYH4lislwzFrAhEUIrkJ9eGoSTNE/CO46i+cSaYx oKqsV/m1q1W2PvUm/SE6kujHKQjjcBTufPXDQKTkg2nmqNdJovf/nN4Bv1S7b6u8c5yT00fGHNQYO 9EC61BmKY/Qfjij8XPmb90uWjKz/7zFjfJV6LuaRKrDa2n0AqJ0ST/6fVZQ7/87a8kHo3mq/FJ7Sq OrsxP3MAvrLDWKB9oNCDBLDsUJxAIfOj8v1NHPj8HCrjp1JWCQTlsaoP3GqhSYLdQCSd9nW6tdF5C 8sqnhAqKw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2hzT-0000v8-AP; Mon, 03 Aug 2020 21:27:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k2hzQ-0000uE-84; Mon, 03 Aug 2020 21:27:24 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACF2C207DF; Mon, 3 Aug 2020 21:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596490043; bh=SEWW09/i+04+jjvVuA9NB1iGYFQ/+Gb2zPeEc9SAtPI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=fKraf1DqTK0sVAU2Wtz2SmkZ8NLOotp3LiIuxM3o3RlO6RPHjb25lL4EmJ4Klx/rT TNxFCNmgzFyC7a6fKwBaVGUPHU4sHqw3J9DCkXSMrNi2k4fiO8OJcLyoLrp26e/+0L i2jpkTYD8p0EVnDCgqcjs8Dt6NYUqq2NR9tOs+9o= MIME-Version: 1.0 In-Reply-To: <20200730182619.23246-1-nsaenzjulienne@suse.de> References: <20200730182619.23246-1-nsaenzjulienne@suse.de> Subject: Re: [PATCH v2] clk: bcm2835: Do not use prediv with bcm2711's PLLs From: Stephen Boyd To: Eric Anholt , Florian Fainelli , Matthias Brugger , Nicolas Saenz Julienne , Ray Jui , Scott Branden , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com Date: Mon, 03 Aug 2020 14:27:22 -0700 Message-ID: <159649004236.1360974.8603728575729464532@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200803_172724_397753_354E52A2 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-list@raspberrypi.com, Michael Turquette , linux-kernel@vger.kernel.org, pbrobinson@gmail.com, Nathan Chancellor , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nicolas Saenz Julienne (2020-07-30 11:26:19) > Contrary to previous SoCs, bcm2711 doesn't have a prescaler in the PLL > feedback loop. Bypass it by zeroing fb_prediv_mask when running on > bcm2711. > > Note that, since the prediv configuration bits were re-purposed, this > was triggering miscalculations on all clocks hanging from the VPU clock, > notably the aux UART, making its output unintelligible. > > Fixes: 42de9ad400af ("clk: bcm2835: Add BCM2711_CLOCK_EMMC2 support") > Reported-by: Nathan Chancellor > Signed-off-by: Nicolas Saenz Julienne > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel