From: longli@linuxonhyperv.com
To: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Cc: dev@dpdk.org, Long Li <longli@microsoft.com>
Subject: [dpdk-dev] [PATCH 3/4] net/netvsc: mark chim_index as NVS_CHIM_IDX_INVALID after freeing it
Date: Mon, 10 Aug 2020 19:33:13 -0700 [thread overview]
Message-ID: <1597113194-90208-3-git-send-email-longli@linuxonhyperv.com> (raw)
In-Reply-To: <1597113194-90208-1-git-send-email-longli@linuxonhyperv.com>
From: Long Li <longli@microsoft.com>
chim_index could potentially be used in other hn_txdesc when re-allocated.
Mark it as invalid to prevent stale value being used.
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/net/netvsc/hn_rxtx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index c8c4ee10c..a388ff258 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -419,8 +419,10 @@ hn_nvs_send_completed(struct rte_eth_dev *dev, uint16_t queue_id,
++txq->stats.errors;
}
- if (txd->chim_index != NVS_CHIM_IDX_INVALID)
+ if (txd->chim_index != NVS_CHIM_IDX_INVALID) {
hn_chim_free(hv, txd->chim_index);
+ txd->chim_index = NVS_CHIM_IDX_INVALID;
+ }
rte_pktmbuf_free(txd->m);
hn_txd_put(txq, txd);
--
2.25.1
next prev parent reply other threads:[~2020-08-11 2:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 2:33 [dpdk-dev] [PATCH 1/4] net/netvsc: move rxbuf_info from per-device to per-queue longli
2020-08-11 2:33 ` [dpdk-dev] [PATCH 2/4] bus/vmbus: remove vmbus_send_interrupt longli
2020-08-11 15:31 ` Stephen Hemminger
2020-08-11 2:33 ` longli [this message]
2020-08-11 15:32 ` [dpdk-dev] [PATCH 3/4] net/netvsc: mark chim_index as NVS_CHIM_IDX_INVALID after freeing it Stephen Hemminger
2020-08-11 2:33 ` [dpdk-dev] [PATCH 4/4] net/netvsc: check for overflow on packet info from host longli
2020-08-11 15:42 ` Stephen Hemminger
2020-10-27 17:10 ` Luca Boccassi
2020-10-27 23:07 ` Ferruh Yigit
2020-10-28 11:08 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
2020-10-29 8:43 ` Ferruh Yigit
2020-08-16 23:11 ` [dpdk-dev] [PATCH 1/4] net/netvsc: move rxbuf_info from per-device to per-queue Stephen Hemminger
2020-08-19 15:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597113194-90208-3-git-send-email-longli@linuxonhyperv.com \
--to=longli@linuxonhyperv.com \
--cc=dev@dpdk.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=longli@microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.