From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@sandeen.net, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 1/2] xfs_db: fix nlink usage in check
Date: Tue, 11 Aug 2020 09:42:24 -0700 [thread overview]
Message-ID: <159716414414.2135493.1784583001962165153.stgit@magnolia> (raw)
In-Reply-To: <159716413625.2135493.4789129138005837744.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
process_inode uses a local convenience variable to abstract the
differences between the ondisk nlink fields in a v1 inode and a v2
inode. Use this variable for checking and reporting errors.
Fixes: 6526f30e4801 ("xfs_db: stop misusing an onstack inode")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
db/check.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/db/check.c b/db/check.c
index c2233a0d1ba7..ef0e82d4efa1 100644
--- a/db/check.c
+++ b/db/check.c
@@ -2797,10 +2797,10 @@ process_inode(
be64_to_cpu(dip->di_nblocks), ino);
error++;
}
- if (dip->di_nlink != 0) {
+ if (nlink != 0) {
if (v)
dbprintf(_("bad nlink %d for free inode %lld\n"),
- be32_to_cpu(dip->di_nlink), ino);
+ nlink, ino);
error++;
}
if (dip->di_mode != 0) {
next prev parent reply other threads:[~2020-08-11 16:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 16:42 [PATCH 0/2] xfsprogs: various small enhancements Darrick J. Wong
2020-08-11 16:42 ` Darrick J. Wong [this message]
2020-08-11 19:25 ` [PATCH 1/2] xfs_db: fix nlink usage in check Eric Sandeen
2020-08-11 16:42 ` [PATCH 2/2] mkfs: allow setting dax flag on root directory Darrick J. Wong
2020-08-11 19:39 ` Eric Sandeen
2020-08-11 19:54 ` Darrick J. Wong
2020-08-11 20:02 ` Eric Sandeen
2020-08-11 20:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159716414414.2135493.1784583001962165153.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.