From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E90AFC433E0 for ; Tue, 11 Aug 2020 21:50:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C139F206DA for ; Tue, 11 Aug 2020 21:50:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C139F206DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E18606E856; Tue, 11 Aug 2020 21:50:11 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [IPv6:2610:10:20:722:a800:ff:feee:56cf]) by gabe.freedesktop.org (Postfix) with ESMTP id 427ED6E854; Tue, 11 Aug 2020 21:50:11 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 33A4AA47E6; Tue, 11 Aug 2020 21:50:11 +0000 (UTC) MIME-Version: 1.0 From: Patchwork To: "Lyude Paul" Date: Tue, 11 Aug 2020 21:50:11 -0000 Message-ID: <159718261118.3769.6805063988306771832@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20200811200457.134743-1-lyude@redhat.com> In-Reply-To: <20200811200457.134743-1-lyude@redhat.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_drm/dp=2C_i915=2C_nouveau=3A_Cleanup_nouveau_HPD_and_add_DP?= =?utf-8?q?_features_from_i915_=28rev2=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915 (rev2) URL : https://patchwork.freedesktop.org/series/80542/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7429fbed7536 drm/nouveau/kms: Fix some indenting in nouveau_dp_detect() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 21 lines checked d6d94517b732 drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc() -:102: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct nouveau_connector *' should also have an identifier name #102: FILE: drivers/gpu/drm/nouveau/nouveau_encoder.h:109: +int nouveau_dp_detect(struct nouveau_connector *, struct nouveau_encoder *); -:102: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct nouveau_encoder *' should also have an identifier name #102: FILE: drivers/gpu/drm/nouveau/nouveau_encoder.h:109: +int nouveau_dp_detect(struct nouveau_connector *, struct nouveau_encoder *); total: 0 errors, 2 warnings, 0 checks, 74 lines checked 478aa516d10c drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c bd4724757ea9 drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c eb430d7e3dc4 drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new() -:7: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit fa3cdf8d0b09 ("drm/nouveau: Reset MST branching unit before enabling")' #7: Since fa3cdf8d0b09 ("drm/nouveau: Reset MST branching unit before total: 1 errors, 0 warnings, 0 checks, 17 lines checked 7cb0374b4558 drm/nouveau/kms: Search for encoders' connectors properly b197d002e32f drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in nv50_sor_disable() 2aa54c3a5de3 drm/nouveau/kms/nv50-: Refactor and cleanup DP HPD handling -:53: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #53: * Enabling bits in MSTM_CTRL before calling drm_dp_mst_topology_mgr_set_mst(). -:460: WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct drm_device *' should also have an identifier name #460: FILE: drivers/gpu/drm/nouveau/nouveau_display.h:21: + void (*fini)(struct drm_device *, bool suspend, bool runtime); -:598: CHECK:LINE_SPACING: Please don't use multiple blank lines #598: FILE: drivers/gpu/drm/nouveau/nouveau_dp.c:161: + total: 0 errors, 2 warnings, 1 checks, 577 lines checked 8b6671700abf drm/i915/dp: Extract drm_dp_has_mst() 1616b919e4b2 drm/nouveau/kms: Use new drm_dp_has_mst() helper for checking MST caps -:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 29 lines checked 67b2ac39f22b drm/nouveau/kms: Move drm_dp_cec_unset_edid() into nouveau_connector_detect() 00e33908c535 drm/nouveau/kms: Only use hpd_work for reprobing in HPD paths -:279: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #279: FILE: drivers/gpu/drm/nouveau/nouveau_drv.h:201: + struct mutex hpd_lock; total: 0 errors, 0 warnings, 1 checks, 219 lines checked 43964c882505 drm/i915/dp: Extract drm_dp_downstream_read_info() 7ebbddd8fe5f drm/nouveau/kms/nv50-: Use downstream DP clock limits for mode validation -:63: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #63: FILE: drivers/gpu/drm/nouveau/nouveau_dp.c:196: + unsigned max_clock, ds_clock, clock; total: 0 errors, 1 warnings, 0 checks, 57 lines checked e308120f0a75 drm/i915/dp: Extract drm_dp_has_sink_count() dd59fa4b47de drm/i915/dp: Extract drm_dp_get_sink_count() c726b1b06424 drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #11: plugged into it currently results in a bogus EDID retrieval error in the kernel log. total: 0 errors, 1 warnings, 0 checks, 108 lines checked b2b88eaa8158 drm/nouveau/kms: Don't change EDID when it hasn't actually changed dbc6ce6444f9 drm/i915/dp: Extract drm_dp_read_dpcd_caps() ed9c2cbd0615 drm/nouveau/kms: Start using drm_dp_read_dpcd_caps() _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx