From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45591C433E1 for ; Wed, 12 Aug 2020 07:53:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18B32206B5 for ; Wed, 12 Aug 2020 07:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597218812; bh=P6ejn0S1w+bT2hmJQj0bBbZBGv/i7M2RCBerqlQ0tto=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=nKRS2GDIG9vciwFAe7tvipyPkl/vS22wSaB6lYirNN38YBI5cE5Hu+ow7geJkLzYv vnWENt4axtWFbIcNlqX5MGkzFtA0KU5ANz+5Rge4uGYmiImBhYXWS7AoX5Ci3jAO8F ul3dIHIDRcXGN+P7vNdPup/IM6SjbREbjtyiV+F4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727013AbgHLHxb (ORCPT ); Wed, 12 Aug 2020 03:53:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:35774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbgHLHxa (ORCPT ); Wed, 12 Aug 2020 03:53:30 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B45720771; Wed, 12 Aug 2020 07:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597218810; bh=P6ejn0S1w+bT2hmJQj0bBbZBGv/i7M2RCBerqlQ0tto=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cYpOh+wGFM5q4h0EVw4BenMsqzWP58oOKUENaUKnf31yzm8gW69JYPjy59IdNYhf4 e1I1V8vWSdNMtpxNY4gNzcTAuWAVIs5SuDEKWEJvaywvK0XGOaSOm39fZbxeFkAfWV BSP0At06Izb5dIxnKzChYlLDR4M3KPGOBGNKm5D8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200806182059.2431-5-krzk@kernel.org> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-5-krzk@kernel.org> Subject: Re: [PATCH v2 05/41] ARM: s3c24xx: make S3C24XX_MISCCR access indirect From: Stephen Boyd Cc: Arnd Bergmann , Krzysztof Kozlowski , Russell King , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Date: Wed, 12 Aug 2020 00:53:29 -0700 Message-ID: <159721880936.33733.15599563496602398778@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Krzysztof Kozlowski (2020-08-06 11:20:22) > From: Arnd Bergmann >=20 > The clk driver uses both a function call into an exported > platform file and a direct register access to a hardcoded > virtual address for accessing the MISCCR register, both > become are a problem for a multiplatform kernel because > of the header file dependency. >=20 > Make this an indirect function call through platform data > instead. >=20 > Signed-off-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62F0EC433DF for ; Wed, 12 Aug 2020 07:55:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 310AD206B2 for ; Wed, 12 Aug 2020 07:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lkL6D2NI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cYpOh+wG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 310AD206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+jWgslaYGMXyssdAnn51NH6I6yBfY1/CdQEtVpyOxLI=; b=lkL6D2NIhMcg75DobO86fOiJl NUgGwUw49Io3qqM10Tg/It2xGm1chyzj+tk+CHW1Gp8SaSKM+wnzZQz7BCQl48hUTxpA1TKIdpVCB 1FbAvdwWrCaZBs2H8LHaAwX0rnMeYZ+sOjaYcZ3LvFUrCqXIUnKiIeH+iZnN6MudrUck8oq9zPmDj cISSoWJlG7U9XrPOdh+EawnZS7MHe5T4qw2h5rlmWjuR+WFj45Q3c+udoUxMID61MTrAWOLP88qNO oqLm9dtNnscW+m5P4xs5oWz8l7FcuD8K0WTko+5f+I+Wan7xSQRyR2K8M0JibKOM1S62WNhOkpxjr kruhUEXcg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5lZq-0002tW-3D; Wed, 12 Aug 2020 07:53:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5lZj-0002ru-64 for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 07:53:31 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B45720771; Wed, 12 Aug 2020 07:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597218810; bh=P6ejn0S1w+bT2hmJQj0bBbZBGv/i7M2RCBerqlQ0tto=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cYpOh+wGFM5q4h0EVw4BenMsqzWP58oOKUENaUKnf31yzm8gW69JYPjy59IdNYhf4 e1I1V8vWSdNMtpxNY4gNzcTAuWAVIs5SuDEKWEJvaywvK0XGOaSOm39fZbxeFkAfWV BSP0At06Izb5dIxnKzChYlLDR4M3KPGOBGNKm5D8= MIME-Version: 1.0 In-Reply-To: <20200806182059.2431-5-krzk@kernel.org> References: <20200806181932.2253-1-krzk@kernel.org> <20200806182059.2431-5-krzk@kernel.org> Subject: Re: [PATCH v2 05/41] ARM: s3c24xx: make S3C24XX_MISCCR access indirect From: Stephen Boyd To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Date: Wed, 12 Aug 2020 00:53:29 -0700 Message-ID: <159721880936.33733.15599563496602398778@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_035331_330370_CC3268EE X-CRM114-Status: GOOD ( 13.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Arnd Bergmann , Michael Turquette , Tomasz Figa , Krzysztof Kozlowski , Russell King , Chanwoo Choi , Kukjin Kim , Sylwester Nawrocki , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Krzysztof Kozlowski (2020-08-06 11:20:22) > From: Arnd Bergmann > > The clk driver uses both a function call into an exported > platform file and a direct register access to a hardcoded > virtual address for accessing the MISCCR register, both > become are a problem for a multiplatform kernel because > of the header file dependency. > > Make this an indirect function call through platform data > instead. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel