From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE75AC433DF for ; Wed, 12 Aug 2020 07:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98DB820786 for ; Wed, 12 Aug 2020 07:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219059; bh=GD6v7CB5dursMy1LFpKqdYSAC+0NBpdsVgzB6336OsY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=c5HVHmMyv0p69oNX2SLqspeUlmPuOoSge/kqjjbZDZBv7Cws5lXz7N+Hnf78W4pK4 LE0OAIsf4j9eupn9vvpXVFI3D2SFQR5UnJmYKL8G7F8B4NU4+As1lXWZyvehPCh74i 282Tehj7XkGVX8osCWxDF9zoBBxuOWceVLq04+lo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726507AbgHLH5j (ORCPT ); Wed, 12 Aug 2020 03:57:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:37754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgHLH5i (ORCPT ); Wed, 12 Aug 2020 03:57:38 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37B28206B5; Wed, 12 Aug 2020 07:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219058; bh=GD6v7CB5dursMy1LFpKqdYSAC+0NBpdsVgzB6336OsY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=gZ5jkX3CKM34ZTH++hII1uQw30e8+MyMAKBf/92qWAPFNOB5EDsGGpwuXXUzUoVYW BIntS+buE/cYprrFrlXTkPTipWz6w6D8cuPgvaJsI+4GBwNCLTlbYcOE8cxL8hrqrs IhPAVxZVSfXakucpn21EgTtcV7/DYAAjgiQ5+Ui8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200804192654.12783-3-krzk@kernel.org> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-3-krzk@kernel.org> Subject: Re: [PATCH v2 02/13] clk: samsung: s3c24xx: declare s3c24xx_common_clk_init() in shared header From: Stephen Boyd Cc: Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao To: Alexandre Torgue , Arnd Bergmann , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Sylwester Nawrocki , Tomasz Figa , Will Deacon , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, patches@opensource.cirrus.com Date: Wed, 12 Aug 2020 00:57:37 -0700 Message-ID: <159721905719.33733.2654708598275375464@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Quoting Krzysztof Kozlowski (2020-08-04 12:26:43) > The s3c2410_common_clk_init() and others are defined and used by the > clk-s3c24xx driver and also used in the mach-s3c24xx machine code. Move > the declaration to a header to fix W=3D1 build warnings: >=20 > drivers/clk/samsung/clk-s3c2410.c:320:13: warning: no previous protot= ype for 's3c2410_common_clk_init' [-Wmissing-prototypes] > 320 | void __init s3c2410_common_clk_init(struct device_node *np, u= nsigned long xti_f, > drivers/clk/samsung/clk-s3c2412.c:205:13: warning: no previous protot= ype for 's3c2412_common_clk_init' [-Wmissing-prototypes] > 205 | void __init s3c2412_common_clk_init(struct device_node *np, u= nsigned long xti_f, > drivers/clk/samsung/clk-s3c2443.c:341:13: warning: no previous protot= ype for 's3c2443_common_clk_init' [-Wmissing-prototypes] > 341 | void __init s3c2443_common_clk_init(struct device_node *np, u= nsigned long xti_f, >=20 > Signed-off-by: Krzysztof Kozlowski >=20 > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E92C433DF for ; Wed, 12 Aug 2020 07:59:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02B80206B5 for ; Wed, 12 Aug 2020 07:59:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zUNyffh5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gZ5jkX3C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02B80206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=die0jT7Wfhxx7sF1isVrR6n+le28TC83ipB7mLDPAnk=; b=zUNyffh5JRrQwTkegjVlTqHyR L8YyV7f29F5eCqOvKtLAhuI5whOBiA0N8mNuFeivgrIOgLUP3gUxT/QEH3CrZ9LOh62fm40hRzB5A xknzK/G5YZMUCBg1ylj5jSl+343ABDLCZkr2KSFKk6El1NflL9MfCMa4hH9OrobcfKqCwgZVXCGys wHI+bU9y8xxPgm/v0CZeuq3CyJ+saz9KJyCqihEN9X9pqYZW2GeguGAVnqRrkjT3QsrDvxndv0Q3m bHJ7/Gd9XQZSr3oupclv1w/2LRib7iQjQkqsxQHswBzN3SjUCXkzFdWqx5MozEMcYFlUHDd0Mg6mQ QQGeTTbzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5ldu-0006AU-8Y; Wed, 12 Aug 2020 07:57:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5ldj-00062j-B7 for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 07:57:47 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 37B28206B5; Wed, 12 Aug 2020 07:57:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219058; bh=GD6v7CB5dursMy1LFpKqdYSAC+0NBpdsVgzB6336OsY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=gZ5jkX3CKM34ZTH++hII1uQw30e8+MyMAKBf/92qWAPFNOB5EDsGGpwuXXUzUoVYW BIntS+buE/cYprrFrlXTkPTipWz6w6D8cuPgvaJsI+4GBwNCLTlbYcOE8cxL8hrqrs IhPAVxZVSfXakucpn21EgTtcV7/DYAAjgiQ5+Ui8= MIME-Version: 1.0 In-Reply-To: <20200804192654.12783-3-krzk@kernel.org> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-3-krzk@kernel.org> Subject: Re: [PATCH v2 02/13] clk: samsung: s3c24xx: declare s3c24xx_common_clk_init() in shared header From: Stephen Boyd To: Alexandre Torgue , Arnd Bergmann , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Sylwester Nawrocki , Tomasz Figa , Will Deacon , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, patches@opensource.cirrus.com Date: Wed, 12 Aug 2020 00:57:37 -0700 Message-ID: <159721905719.33733.2654708598275375464@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_035739_476755_497071F0 X-CRM114-Status: GOOD ( 13.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sylwester Nawrocki , Lihua Yao , Cedric Roux , Sergio Prado , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Krzysztof Kozlowski (2020-08-04 12:26:43) > The s3c2410_common_clk_init() and others are defined and used by the > clk-s3c24xx driver and also used in the mach-s3c24xx machine code. Move > the declaration to a header to fix W=1 build warnings: > > drivers/clk/samsung/clk-s3c2410.c:320:13: warning: no previous prototype for 's3c2410_common_clk_init' [-Wmissing-prototypes] > 320 | void __init s3c2410_common_clk_init(struct device_node *np, unsigned long xti_f, > drivers/clk/samsung/clk-s3c2412.c:205:13: warning: no previous prototype for 's3c2412_common_clk_init' [-Wmissing-prototypes] > 205 | void __init s3c2412_common_clk_init(struct device_node *np, unsigned long xti_f, > drivers/clk/samsung/clk-s3c2443.c:341:13: warning: no previous prototype for 's3c2443_common_clk_init' [-Wmissing-prototypes] > 341 | void __init s3c2443_common_clk_init(struct device_node *np, unsigned long xti_f, > > Signed-off-by: Krzysztof Kozlowski > > --- Reviewed-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel