From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCC14C433E1 for ; Wed, 12 Aug 2020 07:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF8DA2083B for ; Wed, 12 Aug 2020 07:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219176; bh=2RVi0D02jynn0p6bTNjO1y53JcI46pZTDa3hdIrdGRU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=eRrMQcXmkzyxGtYeFkzJUFsI9DPLuj9X88HD64U6hdMonTqBPZSoelTLgdnywp3jw BdK6yXoshYNQdMt39VH+FBr5hXI9TIem+OauodUpKHTu6ryA3jOVR9M1l7wW76FD4a vJCSLypQqq2m7ffr64whk1XpzMoBYSVqmi1n05u0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726507AbgHLH7g (ORCPT ); Wed, 12 Aug 2020 03:59:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:38466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbgHLH7f (ORCPT ); Wed, 12 Aug 2020 03:59:35 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70BC1206B5; Wed, 12 Aug 2020 07:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219175; bh=2RVi0D02jynn0p6bTNjO1y53JcI46pZTDa3hdIrdGRU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=WvaHRSRcEls0qNPsEW91OJCAhQYwOYUvsuPFUefwVJarK5lbkanhw0oDP5fEvVZ3R KmidoSAeqi9QgpOPRJlmz9Loj+WSXywqrDC83rtub8hXhP+yOMySrO+GCCr2nee4GG Sd6V3ENtxYxNTcy5/AjbPR/zCRDTo+qvtSYrrCtw= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200804192654.12783-14-krzk@kernel.org> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration From: Stephen Boyd Cc: Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao To: Alexandre Torgue , Arnd Bergmann , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Sylwester Nawrocki , Tomasz Figa , Will Deacon , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, patches@opensource.cirrus.com Date: Wed, 12 Aug 2020 00:59:34 -0700 Message-ID: <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org Quoting Krzysztof Kozlowski (2020-08-04 12:26:54) > The s3c_camif_gpio_put() declaration in > include/media/drv-intf/s3c_camif.h header was different than definition. > Fixing this allows to include that header to also fix the W=3D1 compile > warnings: >=20 > arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous protot= ype for 's3c_camif_gpio_get' [-Wmissing-prototypes] > 28 | int s3c_camif_gpio_get(void) > arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous protot= ype for 's3c_camif_gpio_put' [-Wmissing-prototypes] > 56 | void s3c_camif_gpio_put(void) Maybe it should have been void all along? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5E2C433E1 for ; Wed, 12 Aug 2020 08:01:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B93220774 for ; Wed, 12 Aug 2020 08:01:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DxsU/U10"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WvaHRSRc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B93220774 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BJ5Vnq04Q+1WUcUg9bEn7S7JDJlBx8Qa8Po030oPoQo=; b=DxsU/U10G+AxdtByV7RevDKb+ 8z3OSiB53RO/Pz2/aYMRWeOiVrxcsRTy3GoBufG+M2wUxXk44kOIRhxuzTVLOQvotvctPVVI/TBc/ oFOzAEYJ9FhxsA4wOY6oVRXWicEZVkwWscETFdmTwvSIy1zRyY/dEsdp6Q1+gjkxA1D6xBG7C9Mz2 Y15ypx/aV6QUS7sBFzYzoPUqQtvZR5J75H4wXEhLGAk/eIFOBvc4P1kntR3WG6zjDbGXukTYJ9b1y o+ROpH3xJ+277jMiDzFc+Z0ZpEJ4lF0hYuzbKcBoZrhC9tX18xZSFWCIQ1SkNX0u7hc4Lg5a3feym HX8EJr7hQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5lfj-0006u9-Tt; Wed, 12 Aug 2020 07:59:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5lfc-0006qf-Es for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 07:59:41 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70BC1206B5; Wed, 12 Aug 2020 07:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597219175; bh=2RVi0D02jynn0p6bTNjO1y53JcI46pZTDa3hdIrdGRU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=WvaHRSRcEls0qNPsEW91OJCAhQYwOYUvsuPFUefwVJarK5lbkanhw0oDP5fEvVZ3R KmidoSAeqi9QgpOPRJlmz9Loj+WSXywqrDC83rtub8hXhP+yOMySrO+GCCr2nee4GG Sd6V3ENtxYxNTcy5/AjbPR/zCRDTo+qvtSYrrCtw= MIME-Version: 1.0 In-Reply-To: <20200804192654.12783-14-krzk@kernel.org> References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration From: Stephen Boyd To: Alexandre Torgue , Arnd Bergmann , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Sylwester Nawrocki , Tomasz Figa , Will Deacon , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-watchdog@vger.kernel.org, patches@opensource.cirrus.com Date: Wed, 12 Aug 2020 00:59:34 -0700 Message-ID: <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_035936_615440_4CC42F96 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sylwester Nawrocki , Lihua Yao , Cedric Roux , Sergio Prado , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Krzysztof Kozlowski (2020-08-04 12:26:54) > The s3c_camif_gpio_put() declaration in > include/media/drv-intf/s3c_camif.h header was different than definition. > Fixing this allows to include that header to also fix the W=1 compile > warnings: > > arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes] > 28 | int s3c_camif_gpio_get(void) > arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes] > 56 | void s3c_camif_gpio_put(void) Maybe it should have been void all along? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel