* [PATCH] Fix compile warnings reported during Non TPG build
@ 2020-08-31 15:37 Sowjanya Komatineni
2020-08-31 15:37 ` [PATCH] media: tegra-video: Fix compilation warning of unused variable Sowjanya Komatineni
0 siblings, 1 reply; 2+ messages in thread
From: Sowjanya Komatineni @ 2020-08-31 15:37 UTC (permalink / raw)
To: skomatineni, thierry.reding, jonathanh, hverkuil
Cc: mchehab, linux-media, linux-tegra, linux-kernel
Patch-0001 fixes compilation warnings for variables used with V4L2
control operation when tegra-video is builded for Non TPG.
Patch-0001 should be applied on top of below external support patches.
https://patchwork.kernel.org/cover/11709839/
Sowjanya Komatineni (1):
media: tegra-video: Fix compilation warning of unused variable
drivers/staging/media/tegra-video/vi.c | 2 ++
1 file changed, 2 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] media: tegra-video: Fix compilation warning of unused variable
2020-08-31 15:37 [PATCH] Fix compile warnings reported during Non TPG build Sowjanya Komatineni
@ 2020-08-31 15:37 ` Sowjanya Komatineni
0 siblings, 0 replies; 2+ messages in thread
From: Sowjanya Komatineni @ 2020-08-31 15:37 UTC (permalink / raw)
To: skomatineni, thierry.reding, jonathanh, hverkuil
Cc: mchehab, linux-media, linux-tegra, linux-kernel
vi_pattern_strings is used only when CONFIG_VIDEO_TEGRA_TPG is
enabled and V4L2 control operations currently are used only in
TPG mode.
So when tegra-video is build for non TPG, warnings of unused
variable is reported for v4l2 control operation variable.
This patch fixes it.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/staging/media/tegra-video/vi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c
index 5543ead..dabb99a 100644
--- a/drivers/staging/media/tegra-video/vi.c
+++ b/drivers/staging/media/tegra-video/vi.c
@@ -788,6 +788,7 @@ static const struct v4l2_file_operations tegra_channel_fops = {
/*
* V4L2 control operations
*/
+#if IS_ENABLED(CONFIG_VIDEO_TEGRA_TPG)
static int vi_s_ctrl(struct v4l2_ctrl *ctrl)
{
struct tegra_vi_channel *chan = container_of(ctrl->handler,
@@ -814,6 +815,7 @@ static const char *const vi_pattern_strings[] = {
"Black/White Direct Mode",
"Color Patch Mode",
};
+#endif
static int tegra_channel_setup_ctrl_handler(struct tegra_vi_channel *chan)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-31 15:37 [PATCH] Fix compile warnings reported during Non TPG build Sowjanya Komatineni
2020-08-31 15:37 ` [PATCH] media: tegra-video: Fix compilation warning of unused variable Sowjanya Komatineni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.