From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0ACC43461 for ; Mon, 7 Sep 2020 17:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE29F206B8 for ; Mon, 7 Sep 2020 17:17:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WMCTZj4w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731241AbgIGRQS (ORCPT ); Mon, 7 Sep 2020 13:16:18 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:27671 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729758AbgIGODo (ORCPT ); Mon, 7 Sep 2020 10:03:44 -0400 X-UUID: c0da1ee31c9f4c1899fa454d5d655abc-20200907 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XMk5hJ81PHI3xSrI0ggTQY8xS0Db8n8wp1TadPvcMYI=; b=WMCTZj4wBj5yOwbjeo7002FeDJ+xsnVVyjiGwbqUy2CoWVGW7vaTviB+DUR3qvFLVZNhZQadGQAUzzFfDS9EgbrJw7Gq2oyPLk0g1X75KJwT8oL99c4CrIluleEQzSZDRxaz2fHKkZxN+XJ50mXQEyzDrg0THtOXYG3ik1Ong5A=; X-UUID: c0da1ee31c9f4c1899fa454d5d655abc-20200907 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1785733985; Mon, 07 Sep 2020 21:51:17 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 21:51:13 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 7 Sep 2020 21:51:13 +0800 Message-ID: <1599486675.16905.34.camel@mtkswgap22> Subject: Re: [PATCH v8 3/3] binder: add transaction latency tracer From: Frankie Chang To: Greg Kroah-Hartman CC: Todd Kjos , Joel Fernandes , Martijn Coenen , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Christian Brauner , , , , Jian-Min Liu Date: Mon, 7 Sep 2020 21:51:15 +0800 In-Reply-To: <20200907122557.GC2029056@kroah.com> References: <20200907070045.GA605692@kroah.com> <1599480055-25781-1-git-send-email-Frankie.Chang@mediatek.com> <1599480055-25781-4-git-send-email-Frankie.Chang@mediatek.com> <20200907122557.GC2029056@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: CA5E52C9A8AB3697DACA4A468846144A584745BA3552FA87A3BED667353550882000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIwLTA5LTA3IGF0IDE0OjI1ICswMjAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6DQo+IE9uIE1vbiwgU2VwIDA3LCAyMDIwIGF0IDA4OjAwOjU1UE0gKzA4MDAsIEZyYW5raWUg Q2hhbmcgd3JvdGU6DQo+ID4gRnJvbTogIkZyYW5raWUuQ2hhbmciIDxGcmFua2llLkNoYW5nQG1l ZGlhdGVrLmNvbT4NCj4gPiANCj4gPiBSZWNvcmQgc3RhcnQvZW5kIHRpbWVzdGFtcCBmb3IgYmlu ZGVyIHRyYW5zYWN0aW9uLg0KPiA+IFdoZW4gdHJhbnNhY3Rpb24gaXMgY29tcGxldGVkIG9yIHRy YW5zYWN0aW9uIGlzIGZyZWUsDQo+ID4gaXQgd291bGQgYmUgY2hlY2tlZCBpZiB0cmFuc2FjdGlv biBsYXRlbmN5IG92ZXIgdGhyZXNob2xkDQo+ID4gKGRlZmF1bHQgMiBzZWMpLCBpZiB5ZXMsIHBy aW50aW5nIHJlbGF0ZWQgaW5mb3JtYXRpb24gZm9yIHRyYWNpbmcuDQo+ID4gDQo+ID4gLyogSW1w bGVtZW50IGRldGFpbHMgKi8NCj4gPiAtIEFkZCBsYXRlbmN5IHRyYWNlciBtb2R1bGUgdG8gbW9u aXRvciB0cmFuc2FjdGlvbg0KPiA+ICAgYnkgYXR0YWNoaW5nIHRvIG5ldyB0cmFjZXBvaW50cyBp bnRyb2R1Y2VkDQo+ID4gICB3aGVuIHRyYW5zYWN0aW9ucyBhcmUgYWxsb2NhdGVkIGFuZCBmcmVl ZC4NCj4gPiAgIFRoZSB0cmFjZV9iaW5kZXJfdHhuX2xhdGVuY3lfZnJlZSB3b3VsZCBub3QgYmUg ZW5hYmxlZA0KPiA+ICAgYnkgZGVmYXVsdC4gTW9uaXRvcmluZyB3aGljaCB0cmFuc2FjdGlvbiBp cyB0b28gc2xvdyB0bw0KPiA+ICAgY2F1c2Ugc29tZSBvZiBleGNlcHRpb25zIGlzIGltcG9ydGFu dC4gU28gd2UgaG9vayB0aGUNCj4gPiAgIHRyYWNlcG9pbnQgdG8gY2FsbCB0aGUgbW9uaXRvciBm dW5jdGlvbi4NCj4gPiANCj4gPiAtIFNpbmNlIHNvbWUgb2YgbW9kdWxlcyB3b3VsZCB0cmlnZ2Vy IHRpbWVvdXQgTkUNCj4gPiAgIGlmIHRoZWlyIGJpbmRlciB0cmFuc2FjdGlvbiBkb24ndCBmaW5p c2ggaW4gdGltZSwNCj4gPiAgIHN1Y2ggYXMgYXVkaW8gdGltZW91dCAoNSBzZWMpLCBldmVuIEJU IGNvbW1hbmQNCj4gPiAgIHRpbWVvdXQgKDIgc2VjKSwgZXRjLg0KPiA+ICAgVGhlcmVmb3JlLCBz ZXR0aW5nIHRoZSB0aW1lb3V0IHRocmVzaG9sZCBhcyBkZWZhdWx0DQo+ID4gICAyIHNlY29uZHMg Y291bGQgYmUgaGVscGZ1bCB0byBkZWJ1Zy4NCj4gPiAgIEJ1dCB0aGlzIHRpbWVvdXQgdGhyZXNo b2xkIGlzIGNvbmZpZ3VyYWJsZSwgdG8gbGV0DQo+ID4gICBhbGwgdXNlcnMgZGV0ZXJtaW5lIHRo ZSBtb3JlIHN1aXRhYmxlIHRocmVzaG9sZC4NCj4gPiANCj4gPiAtIFRoZSByZWFzb24gd2h5IHBy aW50aW5nIHRoZSByZWxhdGVkIGluZm9ybWF0aW9uIHRvDQo+ID4gICBrZXJuZWwgaW5mb3JtYXRp b24gbG9nIGJ1dCBub3QgdHJhY2UgYnVmZmVyIGlzIHRoYXQNCj4gPiAgIHNvbWUgYWJub3JtYWwg dHJhbnNhY3Rpb25zIG1heSBiZSBwZW5kaW5nIGZvciBhIGxvbmcNCj4gPiAgIHRpbWUgYWdvLCB0 aGV5IGNvdWxkIG5vdCBiZSByZWNvcmRlZCBkdWUgdG8gYnVmZmVyDQo+ID4gICBsaW1pdGVkLg0K PiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEZyYW5raWUuQ2hhbmcgPEZyYW5raWUuQ2hhbmdAbWVk aWF0ZWsuY29tPg0KPiA+IEFja2VkLWJ5OiBUb2RkIEtqb3MgPHRram9zQGdvb2dsZS5jb20+DQo+ ID4gLS0tDQo+ID4gIGRyaXZlcnMvYW5kcm9pZC9LY29uZmlnICAgICAgICAgICAgICAgICB8ICAg IDggKysrDQo+ID4gIGRyaXZlcnMvYW5kcm9pZC9NYWtlZmlsZSAgICAgICAgICAgICAgICB8ICAg IDEgKw0KPiA+ICBkcml2ZXJzL2FuZHJvaWQvYmluZGVyLmMgICAgICAgICAgICAgICAgfCAgICA2 ICsrDQo+ID4gIGRyaXZlcnMvYW5kcm9pZC9iaW5kZXJfaW50ZXJuYWwuaCAgICAgICB8ICAgMTMg KysrKw0KPiA+ICBkcml2ZXJzL2FuZHJvaWQvYmluZGVyX2xhdGVuY3lfdHJhY2VyLmMgfCAgMTEy ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiAgZHJpdmVycy9hbmRyb2lkL2Jp bmRlcl90cmFjZS5oICAgICAgICAgIHwgICAyNiArKysrKystDQo+ID4gIDYgZmlsZXMgY2hhbmdl ZCwgMTYzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ID4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL2FuZHJvaWQvYmluZGVyX2xhdGVuY3lfdHJhY2VyLmMNCj4gPiANCj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9hbmRyb2lkL0tjb25maWcgYi9kcml2ZXJzL2FuZHJvaWQvS2Nv bmZpZw0KPiA+IGluZGV4IDUzYjIyZTIuLjhhYWRhZjQgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVy cy9hbmRyb2lkL0tjb25maWcNCj4gPiArKysgYi9kcml2ZXJzL2FuZHJvaWQvS2NvbmZpZw0KPiA+ IEBAIC01NCw2ICs1NCwxNCBAQCBjb25maWcgQU5EUk9JRF9CSU5ERVJfSVBDX1NFTEZURVNUDQo+ ID4gIAkgIGV4aGF1c3RpdmVseSB3aXRoIGNvbWJpbmF0aW9ucyBvZiB2YXJpb3VzIGJ1ZmZlciBz aXplcyBhbmQNCj4gPiAgCSAgYWxpZ25tZW50cy4NCj4gPiAgDQo+ID4gK2NvbmZpZyBCSU5ERVJf VFJBTlNBQ1RJT05fTEFURU5DWV9UUkFDS0lORw0KPiA+ICsJdHJpc3RhdGUgIkFuZHJvaWQgQmlu ZGVyIHRyYW5zYWN0aW9uIHRyYWNraW5nIg0KPiA+ICsJaGVscA0KPiA+ICsJICBVc2VkIGZvciB0 cmFjayBhYm5vcm1hbCBiaW5kZXIgdHJhbnNhY3Rpb24gd2hpY2ggaXMgb3ZlciB0aHJlc2hvbGQs DQo+ID4gKwkgIHdoZW4gdGhlIHRyYW5zYWN0aW9uIGlzIGRvbmUgb3IgYmUgZnJlZSwgdGhpcyB0 cmFuc2FjdGlvbiB3b3VsZCBiZQ0KPiA+ICsJICBjaGVja2VkIHdoZXRoZXIgaXQgZXhlY3V0ZWQg b3ZlcnRpbWUuDQo+ID4gKwkgIElmIHllcywgcHJpbnRpbmcgb3V0IHRoZSBkZXRhaWxlZCBpbmZv Lg0KPiA+ICsNCj4gPiAgZW5kaWYgIyBpZiBBTkRST0lEDQo+ID4gIA0KPiA+ICBlbmRtZW51DQo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYW5kcm9pZC9NYWtlZmlsZSBiL2RyaXZlcnMvYW5kcm9p ZC9NYWtlZmlsZQ0KPiA+IGluZGV4IGM5ZDNkMGM5Li5jMmZmZGI2IDEwMDY0NA0KPiA+IC0tLSBh L2RyaXZlcnMvYW5kcm9pZC9NYWtlZmlsZQ0KPiA+ICsrKyBiL2RyaXZlcnMvYW5kcm9pZC9NYWtl ZmlsZQ0KPiA+IEBAIC00LDMgKzQsNCBAQCBjY2ZsYWdzLXkgKz0gLUkkKHNyYykJCQkjIG5lZWRl ZCBmb3IgdHJhY2UgZXZlbnRzDQo+ID4gIG9iai0kKENPTkZJR19BTkRST0lEX0JJTkRFUkZTKQkJ Kz0gYmluZGVyZnMubw0KPiA+ICBvYmotJChDT05GSUdfQU5EUk9JRF9CSU5ERVJfSVBDKQkrPSBi aW5kZXIubyBiaW5kZXJfYWxsb2Mubw0KPiA+ICBvYmotJChDT05GSUdfQU5EUk9JRF9CSU5ERVJf SVBDX1NFTEZURVNUKSArPSBiaW5kZXJfYWxsb2Nfc2VsZnRlc3Qubw0KPiA+ICtvYmotJChDT05G SUdfQklOREVSX1RSQU5TQUNUSU9OX0xBVEVOQ1lfVFJBQ0tJTkcpCSs9IGJpbmRlcl9sYXRlbmN5 X3RyYWNlci5vDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYW5kcm9pZC9iaW5kZXIuYyBiL2Ry aXZlcnMvYW5kcm9pZC9iaW5kZXIuYw0KPiA+IGluZGV4IDBjYWI5MDAuLjY1YWQzOGMgMTAwNjQ0 DQo+ID4gLS0tIGEvZHJpdmVycy9hbmRyb2lkL2JpbmRlci5jDQo+ID4gKysrIGIvZHJpdmVycy9h bmRyb2lkL2JpbmRlci5jDQo+ID4gQEAgLTI2NzQsNiArMjY3NCw3IEBAIHN0YXRpYyB2b2lkIGJp bmRlcl90cmFuc2FjdGlvbihzdHJ1Y3QgYmluZGVyX3Byb2MgKnByb2MsDQo+ID4gIAkJcmV0dXJu X2Vycm9yX2xpbmUgPSBfX0xJTkVfXzsNCj4gPiAgCQlnb3RvIGVycl9hbGxvY190X2ZhaWxlZDsN Cj4gPiAgCX0NCj4gPiArCXRyYWNlX2JpbmRlcl90eG5fbGF0ZW5jeV9hbGxvYyh0KTsNCj4gPiAg CUlOSVRfTElTVF9IRUFEKCZ0LT5mZF9maXh1cHMpOw0KPiA+ICAJYmluZGVyX3N0YXRzX2NyZWF0 ZWQoQklOREVSX1NUQVRfVFJBTlNBQ1RJT04pOw0KPiA+ICAJc3Bpbl9sb2NrX2luaXQoJnQtPmxv Y2spOw0KPiA+IEBAIC01MTc3LDYgKzUxNzgsNyBAQCBzdGF0aWMgdm9pZCBwcmludF9iaW5kZXJf dHJhbnNhY3Rpb25faWxvY2tlZChzdHJ1Y3Qgc2VxX2ZpbGUgKm0sDQo+ID4gIAkJICAgdG9fcHJv YyA/IHRvX3Byb2MtPnBpZCA6IDAsDQo+ID4gIAkJICAgdC0+dG9fdGhyZWFkID8gdC0+dG9fdGhy ZWFkLT5waWQgOiAwLA0KPiA+ICAJCSAgIHQtPmNvZGUsIHQtPmZsYWdzLCB0LT5wcmlvcml0eSwg dC0+bmVlZF9yZXBseSk7DQo+ID4gKwl0cmFjZV9iaW5kZXJfdHhuX2xhdGVuY3lfaW5mbyhtLCB0 KTsNCj4gPiAgCXNwaW5fdW5sb2NrKCZ0LT5sb2NrKTsNCj4gPiAgDQo+ID4gIAlpZiAocHJvYyAh PSB0b19wcm9jKSB7DQo+ID4gQEAgLTU4MTgsNCArNTgyMCw4IEBAIHN0YXRpYyBpbnQgX19pbml0 IGJpbmRlcl9pbml0KHZvaWQpDQo+ID4gICNkZWZpbmUgQ1JFQVRFX1RSQUNFX1BPSU5UUw0KPiA+ ICAjaW5jbHVkZSAiYmluZGVyX3RyYWNlLmgiDQo+ID4gIA0KPiA+ICtFWFBPUlRfVFJBQ0VQT0lO VF9TWU1CT0woYmluZGVyX3R4bl9sYXRlbmN5X2FsbG9jKTsNCj4gPiArRVhQT1JUX1RSQUNFUE9J TlRfU1lNQk9MKGJpbmRlcl90eG5fbGF0ZW5jeV9pbmZvKTsNCj4gPiArRVhQT1JUX1RSQUNFUE9J TlRfU1lNQk9MKGJpbmRlcl90eG5fbGF0ZW5jeV9mcmVlKTsNCj4gPiArDQo+ID4gIE1PRFVMRV9M SUNFTlNFKCJHUEwgdjIiKTsNCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hbmRyb2lkL2JpbmRl cl9pbnRlcm5hbC5oIGIvZHJpdmVycy9hbmRyb2lkL2JpbmRlcl9pbnRlcm5hbC5oDQo+ID4gaW5k ZXggODcyMjMyZi4uMzA5ZDFiMTAgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9hbmRyb2lkL2Jp bmRlcl9pbnRlcm5hbC5oDQo+ID4gKysrIGIvZHJpdmVycy9hbmRyb2lkL2JpbmRlcl9pbnRlcm5h bC5oDQo+ID4gQEAgLTE1LDYgKzE1LDExIEBADQo+ID4gICNpbmNsdWRlIDx1YXBpL2xpbnV4L2Fu ZHJvaWQvYmluZGVyZnMuaD4NCj4gPiAgI2luY2x1ZGUgImJpbmRlcl9hbGxvYy5oIg0KPiA+ICAN Cj4gPiArI2lmIElTX0VOQUJMRUQoQ09ORklHX0JJTkRFUl9UUkFOU0FDVElPTl9MQVRFTkNZX1RS QUNLSU5HKQ0KPiA+ICsjaW5jbHVkZSA8dWFwaS9saW51eC90aW1lX3R5cGVzLmg+DQo+ID4gKyNp bmNsdWRlIDxsaW51eC9ydGMuaD4NCj4gPiArI2VuZGlmDQo+ID4gKw0KPiA+ICBzdHJ1Y3QgYmlu ZGVyX2NvbnRleHQgew0KPiA+ICAJc3RydWN0IGJpbmRlcl9ub2RlICpiaW5kZXJfY29udGV4dF9t Z3Jfbm9kZTsNCj4gPiAgCXN0cnVjdCBtdXRleCBjb250ZXh0X21ncl9ub2RlX2xvY2s7DQo+ID4g QEAgLTUyNCw2ICs1MjksMTQgQEAgc3RydWN0IGJpbmRlcl90cmFuc2FjdGlvbiB7DQo+ID4gIAkg KiBkdXJpbmcgdGhyZWFkIHRlYXJkb3duDQo+ID4gIAkgKi8NCj4gPiAgCXNwaW5sb2NrX3QgbG9j azsNCj4gPiArCS8qKg0KPiA+ICsJICogQHRpbWVzdGFtcCBhbmQgQHR2IGFyZSB1c2VkIHRvIHJl Y29yZCB0aGUgdGltZQ0KPiA+ICsJICogdGhhdCB0aGUgYmluZGVyIHRyYW5zYWN0aW9uIHN0YXJ0 dXANCj4gPiArCSAqLw0KPiA+ICsjaWYgSVNfRU5BQkxFRChDT05GSUdfQklOREVSX1RSQU5TQUNU SU9OX0xBVEVOQ1lfVFJBQ0tJTkcpDQo+ID4gKwlzdHJ1Y3QgdGltZXNwZWM2NCB0aW1lc3RhbXA7 DQo+ID4gKwlzdHJ1Y3QgX19rZXJuZWxfb2xkX3RpbWV2YWwgdHY7DQo+IA0KPiBBcyBJIHN0YXRl ZCBpbiB0aGUgMC8zIGVtYWlsLCBwbGVhc2UgdXNlIHRoZSBjb3JyZWN0IGluLWtlcm5lbCBzdHJ1 Y3R1cmUNCj4gZm9yIHRoaXMuICBUaGF0IHN0cnVjdHVyZSBpcyBfT05MWV8gZm9yIG9sZCB1c2Vy c3BhY2UgYXBpIGNvbXBhdGliaWxpdHkNCj4gaXNzdWVzLiAgV2hpY2ggaXMgbm90IHRoZSBjYXNl IGhlcmUgYXQgYWxsLg0KPiANCj4gdGhhbmtzLA0KPiBncmVnIGstaA0KDQpTaW5jZSBpdCdzIG5v dCBwcm9wZXIgdG8gdXNlIHRpbWV2YWwgJiBfX2tlcm5lbF9vbGRfdGltZXZhbC4NClRoZSByZW1h aW5pbmcgc3RydWN0dXJlIHdpdGggdHZfdXNlYyB0aGF0IEkgZm91bmQgaXMNCl9fa2VybmVsX3Rp bWV4X3RpbWV2YWwsIGJ1dCBJJ20gbm90IHN1cmUgaWYgdGhpcyBpcyBwcm9wZXIgb25lIG9yIG5v dC4NCkFsbCBJIGNhbiBzZWUgaXMgaW4NCmh0dHBzOi8vbHduLm5ldC9tbC9saW51eC1rZXJuZWwv MjAxODA3MDUyMTM2MDQuMTg4ODMtNi1kZWVwYS5rZXJuZWxAZ21haWwuY29tLw0KDQpJJ20gYWZy YWlkIG9mIHVzaW5nIHdyb25nIHN0cnVjdHVyZSBhZ2Fpbi4NCkNvdWxkIHlvdSBnaXZlIG1lIHNv bWUgYWR2aWNlcyBhYm91dCB0aGlzPw0KDQpPciBpcyB0aGVyZSBhbm90aGVyIHN1aXRhYmxlIHdh eSB0byByZXBsYWNlIHRpbWV2YWwNCg0KTWFueSB0aGFua3MsDQpGcmFua2llDQoNCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09182C433E2 for ; Mon, 7 Sep 2020 13:52:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C30A2078E for ; Mon, 7 Sep 2020 13:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="x/110HPV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="WMCTZj4w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C30A2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v9b7viIfjWphXMWP9Hz7xyoVt7km4gQ5sHUxYZe2m7A=; b=x/110HPVdxkrQisP72JifRkAw m7Q4coIAssLOBQBH2z6Ly5mXJSACFjK4qrvYa4gnr78hyCSSnplJzXHwhcmomUpsMBo294FAXBJzi C+zFFcNSvP3OfaxdmG0ccNeFT/r7Rhex91gLffYDYPTXGijFh1BkXD974MGZunhN/Pw8zSxDclZdP jhobPhKjxmZ/CbLPnoWX2FagiLLquooyw5PSNZV5oUSsGnWPPIoHvYKxk4rqnEeTXAiQg/RaV8jrJ n9BuCyZiFJdgDJjpPhK6q+6Xg3Jb/u6Ig9vW9sna3nxyC/zU/1nv0rw2xJa4dj1YXjqgXD54kXOwe pmJTSVmzA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFHZL-0008HZ-9D; Mon, 07 Sep 2020 13:52:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFHYq-00082V-UJ for linux-mediatek@lists.infradead.org; Mon, 07 Sep 2020 13:52:19 +0000 X-UUID: ed241b214e42451e9e46001666b38ba9-20200907 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=XMk5hJ81PHI3xSrI0ggTQY8xS0Db8n8wp1TadPvcMYI=; b=WMCTZj4wBj5yOwbjeo7002FeDJ+xsnVVyjiGwbqUy2CoWVGW7vaTviB+DUR3qvFLVZNhZQadGQAUzzFfDS9EgbrJw7Gq2oyPLk0g1X75KJwT8oL99c4CrIluleEQzSZDRxaz2fHKkZxN+XJ50mXQEyzDrg0THtOXYG3ik1Ong5A=; X-UUID: ed241b214e42451e9e46001666b38ba9-20200907 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1503492714; Mon, 07 Sep 2020 05:51:32 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 06:51:29 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 21:51:13 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 7 Sep 2020 21:51:13 +0800 Message-ID: <1599486675.16905.34.camel@mtkswgap22> Subject: Re: [PATCH v8 3/3] binder: add transaction latency tracer From: Frankie Chang To: Greg Kroah-Hartman Date: Mon, 7 Sep 2020 21:51:15 +0800 In-Reply-To: <20200907122557.GC2029056@kroah.com> References: <20200907070045.GA605692@kroah.com> <1599480055-25781-1-git-send-email-Frankie.Chang@mediatek.com> <1599480055-25781-4-git-send-email-Frankie.Chang@mediatek.com> <20200907122557.GC2029056@kroah.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: CA5E52C9A8AB3697DACA4A468846144A584745BA3552FA87A3BED667353550882000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_095157_202475_47A21E88 X-CRM114-Status: GOOD ( 36.30 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Jian-Min Liu , linux-mediatek@lists.infradead.org, Joel Fernandes , Martijn Coenen , Christian Brauner , Todd Kjos Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > From: "Frankie.Chang" > > > > Record start/end timestamp for binder transaction. > > When transaction is completed or transaction is free, > > it would be checked if transaction latency over threshold > > (default 2 sec), if yes, printing related information for tracing. > > > > /* Implement details */ > > - Add latency tracer module to monitor transaction > > by attaching to new tracepoints introduced > > when transactions are allocated and freed. > > The trace_binder_txn_latency_free would not be enabled > > by default. Monitoring which transaction is too slow to > > cause some of exceptions is important. So we hook the > > tracepoint to call the monitor function. > > > > - Since some of modules would trigger timeout NE > > if their binder transaction don't finish in time, > > such as audio timeout (5 sec), even BT command > > timeout (2 sec), etc. > > Therefore, setting the timeout threshold as default > > 2 seconds could be helpful to debug. > > But this timeout threshold is configurable, to let > > all users determine the more suitable threshold. > > > > - The reason why printing the related information to > > kernel information log but not trace buffer is that > > some abnormal transactions may be pending for a long > > time ago, they could not be recorded due to buffer > > limited. > > > > Signed-off-by: Frankie.Chang > > Acked-by: Todd Kjos > > --- > > drivers/android/Kconfig | 8 +++ > > drivers/android/Makefile | 1 + > > drivers/android/binder.c | 6 ++ > > drivers/android/binder_internal.h | 13 ++++ > > drivers/android/binder_latency_tracer.c | 112 +++++++++++++++++++++++++++++++ > > drivers/android/binder_trace.h | 26 ++++++- > > 6 files changed, 163 insertions(+), 3 deletions(-) > > create mode 100644 drivers/android/binder_latency_tracer.c > > > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > > index 53b22e2..8aadaf4 100644 > > --- a/drivers/android/Kconfig > > +++ b/drivers/android/Kconfig > > @@ -54,6 +54,14 @@ config ANDROID_BINDER_IPC_SELFTEST > > exhaustively with combinations of various buffer sizes and > > alignments. > > > > +config BINDER_TRANSACTION_LATENCY_TRACKING > > + tristate "Android Binder transaction tracking" > > + help > > + Used for track abnormal binder transaction which is over threshold, > > + when the transaction is done or be free, this transaction would be > > + checked whether it executed overtime. > > + If yes, printing out the detailed info. > > + > > endif # if ANDROID > > > > endmenu > > diff --git a/drivers/android/Makefile b/drivers/android/Makefile > > index c9d3d0c9..c2ffdb6 100644 > > --- a/drivers/android/Makefile > > +++ b/drivers/android/Makefile > > @@ -4,3 +4,4 @@ ccflags-y += -I$(src) # needed for trace events > > obj-$(CONFIG_ANDROID_BINDERFS) += binderfs.o > > obj-$(CONFIG_ANDROID_BINDER_IPC) += binder.o binder_alloc.o > > obj-$(CONFIG_ANDROID_BINDER_IPC_SELFTEST) += binder_alloc_selftest.o > > +obj-$(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) += binder_latency_tracer.o > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > index 0cab900..65ad38c 100644 > > --- a/drivers/android/binder.c > > +++ b/drivers/android/binder.c > > @@ -2674,6 +2674,7 @@ static void binder_transaction(struct binder_proc *proc, > > return_error_line = __LINE__; > > goto err_alloc_t_failed; > > } > > + trace_binder_txn_latency_alloc(t); > > INIT_LIST_HEAD(&t->fd_fixups); > > binder_stats_created(BINDER_STAT_TRANSACTION); > > spin_lock_init(&t->lock); > > @@ -5177,6 +5178,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m, > > to_proc ? to_proc->pid : 0, > > t->to_thread ? t->to_thread->pid : 0, > > t->code, t->flags, t->priority, t->need_reply); > > + trace_binder_txn_latency_info(m, t); > > spin_unlock(&t->lock); > > > > if (proc != to_proc) { > > @@ -5818,4 +5820,8 @@ static int __init binder_init(void) > > #define CREATE_TRACE_POINTS > > #include "binder_trace.h" > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_alloc); > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_info); > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_free); > > + > > MODULE_LICENSE("GPL v2"); > > diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h > > index 872232f..309d1b10 100644 > > --- a/drivers/android/binder_internal.h > > +++ b/drivers/android/binder_internal.h > > @@ -15,6 +15,11 @@ > > #include > > #include "binder_alloc.h" > > > > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > > +#include > > +#include > > +#endif > > + > > struct binder_context { > > struct binder_node *binder_context_mgr_node; > > struct mutex context_mgr_node_lock; > > @@ -524,6 +529,14 @@ struct binder_transaction { > > * during thread teardown > > */ > > spinlock_t lock; > > + /** > > + * @timestamp and @tv are used to record the time > > + * that the binder transaction startup > > + */ > > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > > + struct timespec64 timestamp; > > + struct __kernel_old_timeval tv; > > As I stated in the 0/3 email, please use the correct in-kernel structure > for this. That structure is _ONLY_ for old userspace api compatibility > issues. Which is not the case here at all. > > thanks, > greg k-h Since it's not proper to use timeval & __kernel_old_timeval. The remaining structure with tv_usec that I found is __kernel_timex_timeval, but I'm not sure if this is proper one or not. All I can see is in https://lwn.net/ml/linux-kernel/20180705213604.18883-6-deepa.kernel@gmail.com/ I'm afraid of using wrong structure again. Could you give me some advices about this? Or is there another suitable way to replace timeval Many thanks, Frankie _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek