From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B75AC433E2 for ; Tue, 8 Sep 2020 05:38:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F6CB21973 for ; Tue, 8 Sep 2020 05:38:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="SC00cIb1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728756AbgIHFii (ORCPT ); Tue, 8 Sep 2020 01:38:38 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:36097 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728712AbgIHFif (ORCPT ); Tue, 8 Sep 2020 01:38:35 -0400 X-UUID: 1e52e0a625644801be7fb10483c43e75-20200908 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vXxcXjp/u4tUTeNK/WwgFqe99QTu92iZSo4LzEOqHcQ=; b=SC00cIb1DdLbVkCvelNk0WpsvUQlLHam3z1EB4hxDQldxQwgsHh3ZMDXCQqmcK3XHUSTmI5mVkw81HZyzjskxjpp/3hmnpT9tdsmvesQ4DmzAAJRHDhLOaBEBwf6MV1lFebxxGoT9mmtY36PfGiDe16Hz49RERro2FZTQbBlzaQ=; X-UUID: 1e52e0a625644801be7fb10483c43e75-20200908 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1623823333; Tue, 08 Sep 2020 13:38:26 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Sep 2020 13:38:24 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 13:38:25 +0800 Message-ID: <1599543504.16905.65.camel@mtkswgap22> Subject: Re: [PATCH v8 3/3] binder: add transaction latency tracer From: Frankie Chang To: Greg Kroah-Hartman CC: Todd Kjos , Joel Fernandes , Martijn Coenen , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Christian Brauner , , , , Jian-Min Liu Date: Tue, 8 Sep 2020 13:38:24 +0800 In-Reply-To: <20200907140920.GC3719869@kroah.com> References: <20200907070045.GA605692@kroah.com> <1599480055-25781-1-git-send-email-Frankie.Chang@mediatek.com> <1599480055-25781-4-git-send-email-Frankie.Chang@mediatek.com> <20200907122557.GC2029056@kroah.com> <1599486675.16905.34.camel@mtkswgap22> <20200907140920.GC3719869@kroah.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gTW9uLCAyMDIwLTA5LTA3IGF0IDE2OjA5ICswMjAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6DQo+IE9uIE1vbiwgU2VwIDA3LCAyMDIwIGF0IDA5OjUxOjE1UE0gKzA4MDAsIEZyYW5raWUg Q2hhbmcgd3JvdGU6DQo+ID4gT24gTW9uLCAyMDIwLTA5LTA3IGF0IDE0OjI1ICswMjAwLCBHcmVn IEtyb2FoLUhhcnRtYW4gd3JvdGU6DQo+ID4gPiBPbiBNb24sIFNlcCAwNywgMjAyMCBhdCAwODow MDo1NVBNICswODAwLCBGcmFua2llIENoYW5nIHdyb3RlOg0KPiA+ID4gPiBGcm9tOiAiRnJhbmtp ZS5DaGFuZyIgPEZyYW5raWUuQ2hhbmdAbWVkaWF0ZWsuY29tPg0KPiA+ID4gPiANCj4gPiA+ID4g UmVjb3JkIHN0YXJ0L2VuZCB0aW1lc3RhbXAgZm9yIGJpbmRlciB0cmFuc2FjdGlvbi4NCj4gPiA+ ID4gV2hlbiB0cmFuc2FjdGlvbiBpcyBjb21wbGV0ZWQgb3IgdHJhbnNhY3Rpb24gaXMgZnJlZSwN Cj4gPiA+ID4gaXQgd291bGQgYmUgY2hlY2tlZCBpZiB0cmFuc2FjdGlvbiBsYXRlbmN5IG92ZXIg dGhyZXNob2xkDQo+ID4gPiA+IChkZWZhdWx0IDIgc2VjKSwgaWYgeWVzLCBwcmludGluZyByZWxh dGVkIGluZm9ybWF0aW9uIGZvciB0cmFjaW5nLg0KPiA+ID4gPiANCj4gPiA+ID4gLyogSW1wbGVt ZW50IGRldGFpbHMgKi8NCj4gPiA+ID4gLSBBZGQgbGF0ZW5jeSB0cmFjZXIgbW9kdWxlIHRvIG1v bml0b3IgdHJhbnNhY3Rpb24NCj4gPiA+ID4gICBieSBhdHRhY2hpbmcgdG8gbmV3IHRyYWNlcG9p bnRzIGludHJvZHVjZWQNCj4gPiA+ID4gICB3aGVuIHRyYW5zYWN0aW9ucyBhcmUgYWxsb2NhdGVk IGFuZCBmcmVlZC4NCj4gPiA+ID4gICBUaGUgdHJhY2VfYmluZGVyX3R4bl9sYXRlbmN5X2ZyZWUg d291bGQgbm90IGJlIGVuYWJsZWQNCj4gPiA+ID4gICBieSBkZWZhdWx0LiBNb25pdG9yaW5nIHdo aWNoIHRyYW5zYWN0aW9uIGlzIHRvbyBzbG93IHRvDQo+ID4gPiA+ICAgY2F1c2Ugc29tZSBvZiBl eGNlcHRpb25zIGlzIGltcG9ydGFudC4gU28gd2UgaG9vayB0aGUNCj4gPiA+ID4gICB0cmFjZXBv aW50IHRvIGNhbGwgdGhlIG1vbml0b3IgZnVuY3Rpb24uDQo+ID4gPiA+IA0KPiA+ID4gPiAtIFNp bmNlIHNvbWUgb2YgbW9kdWxlcyB3b3VsZCB0cmlnZ2VyIHRpbWVvdXQgTkUNCj4gPiA+ID4gICBp ZiB0aGVpciBiaW5kZXIgdHJhbnNhY3Rpb24gZG9uJ3QgZmluaXNoIGluIHRpbWUsDQo+ID4gPiA+ ICAgc3VjaCBhcyBhdWRpbyB0aW1lb3V0ICg1IHNlYyksIGV2ZW4gQlQgY29tbWFuZA0KPiA+ID4g PiAgIHRpbWVvdXQgKDIgc2VjKSwgZXRjLg0KPiA+ID4gPiAgIFRoZXJlZm9yZSwgc2V0dGluZyB0 aGUgdGltZW91dCB0aHJlc2hvbGQgYXMgZGVmYXVsdA0KPiA+ID4gPiAgIDIgc2Vjb25kcyBjb3Vs ZCBiZSBoZWxwZnVsIHRvIGRlYnVnLg0KPiA+ID4gPiAgIEJ1dCB0aGlzIHRpbWVvdXQgdGhyZXNo b2xkIGlzIGNvbmZpZ3VyYWJsZSwgdG8gbGV0DQo+ID4gPiA+ICAgYWxsIHVzZXJzIGRldGVybWlu ZSB0aGUgbW9yZSBzdWl0YWJsZSB0aHJlc2hvbGQuDQo+ID4gPiA+IA0KPiA+ID4gPiAtIFRoZSBy ZWFzb24gd2h5IHByaW50aW5nIHRoZSByZWxhdGVkIGluZm9ybWF0aW9uIHRvDQo+ID4gPiA+ICAg a2VybmVsIGluZm9ybWF0aW9uIGxvZyBidXQgbm90IHRyYWNlIGJ1ZmZlciBpcyB0aGF0DQo+ID4g PiA+ICAgc29tZSBhYm5vcm1hbCB0cmFuc2FjdGlvbnMgbWF5IGJlIHBlbmRpbmcgZm9yIGEgbG9u Zw0KPiA+ID4gPiAgIHRpbWUgYWdvLCB0aGV5IGNvdWxkIG5vdCBiZSByZWNvcmRlZCBkdWUgdG8g YnVmZmVyDQo+ID4gPiA+ICAgbGltaXRlZC4NCj4gPiA+ID4gDQo+ID4gPiA+IFNpZ25lZC1vZmYt Ynk6IEZyYW5raWUuQ2hhbmcgPEZyYW5raWUuQ2hhbmdAbWVkaWF0ZWsuY29tPg0KPiA+ID4gPiBB Y2tlZC1ieTogVG9kZCBLam9zIDx0a2pvc0Bnb29nbGUuY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+ ID4gIGRyaXZlcnMvYW5kcm9pZC9LY29uZmlnICAgICAgICAgICAgICAgICB8ICAgIDggKysrDQo+ ID4gPiA+ICBkcml2ZXJzL2FuZHJvaWQvTWFrZWZpbGUgICAgICAgICAgICAgICAgfCAgICAxICsN Cj4gPiA+ID4gIGRyaXZlcnMvYW5kcm9pZC9iaW5kZXIuYyAgICAgICAgICAgICAgICB8ICAgIDYg KysNCj4gPiA+ID4gIGRyaXZlcnMvYW5kcm9pZC9iaW5kZXJfaW50ZXJuYWwuaCAgICAgICB8ICAg MTMgKysrKw0KPiA+ID4gPiAgZHJpdmVycy9hbmRyb2lkL2JpbmRlcl9sYXRlbmN5X3RyYWNlci5j IHwgIDExMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ICBkcml2ZXJz L2FuZHJvaWQvYmluZGVyX3RyYWNlLmggICAgICAgICAgfCAgIDI2ICsrKysrKy0NCj4gPiA+ID4g IDYgZmlsZXMgY2hhbmdlZCwgMTYzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ID4g PiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9hbmRyb2lkL2JpbmRlcl9sYXRlbmN5X3Ry YWNlci5jDQo+ID4gPiA+IA0KPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hbmRyb2lkL0tj b25maWcgYi9kcml2ZXJzL2FuZHJvaWQvS2NvbmZpZw0KPiA+ID4gPiBpbmRleCA1M2IyMmUyLi44 YWFkYWY0IDEwMDY0NA0KPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2FuZHJvaWQvS2NvbmZpZw0KPiA+ ID4gPiArKysgYi9kcml2ZXJzL2FuZHJvaWQvS2NvbmZpZw0KPiA+ID4gPiBAQCAtNTQsNiArNTQs MTQgQEAgY29uZmlnIEFORFJPSURfQklOREVSX0lQQ19TRUxGVEVTVA0KPiA+ID4gPiAgCSAgZXho YXVzdGl2ZWx5IHdpdGggY29tYmluYXRpb25zIG9mIHZhcmlvdXMgYnVmZmVyIHNpemVzIGFuZA0K PiA+ID4gPiAgCSAgYWxpZ25tZW50cy4NCj4gPiA+ID4gIA0KPiA+ID4gPiArY29uZmlnIEJJTkRF Ul9UUkFOU0FDVElPTl9MQVRFTkNZX1RSQUNLSU5HDQo+ID4gPiA+ICsJdHJpc3RhdGUgIkFuZHJv aWQgQmluZGVyIHRyYW5zYWN0aW9uIHRyYWNraW5nIg0KPiA+ID4gPiArCWhlbHANCj4gPiA+ID4g KwkgIFVzZWQgZm9yIHRyYWNrIGFibm9ybWFsIGJpbmRlciB0cmFuc2FjdGlvbiB3aGljaCBpcyBv dmVyIHRocmVzaG9sZCwNCj4gPiA+ID4gKwkgIHdoZW4gdGhlIHRyYW5zYWN0aW9uIGlzIGRvbmUg b3IgYmUgZnJlZSwgdGhpcyB0cmFuc2FjdGlvbiB3b3VsZCBiZQ0KPiA+ID4gPiArCSAgY2hlY2tl ZCB3aGV0aGVyIGl0IGV4ZWN1dGVkIG92ZXJ0aW1lLg0KPiA+ID4gPiArCSAgSWYgeWVzLCBwcmlu dGluZyBvdXQgdGhlIGRldGFpbGVkIGluZm8uDQo+ID4gPiA+ICsNCj4gPiA+ID4gIGVuZGlmICMg aWYgQU5EUk9JRA0KPiA+ID4gPiAgDQo+ID4gPiA+ICBlbmRtZW51DQo+ID4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2FuZHJvaWQvTWFrZWZpbGUgYi9kcml2ZXJzL2FuZHJvaWQvTWFrZWZpbGUN Cj4gPiA+ID4gaW5kZXggYzlkM2QwYzkuLmMyZmZkYjYgMTAwNjQ0DQo+ID4gPiA+IC0tLSBhL2Ry aXZlcnMvYW5kcm9pZC9NYWtlZmlsZQ0KPiA+ID4gPiArKysgYi9kcml2ZXJzL2FuZHJvaWQvTWFr ZWZpbGUNCj4gPiA+ID4gQEAgLTQsMyArNCw0IEBAIGNjZmxhZ3MteSArPSAtSSQoc3JjKQkJCSMg bmVlZGVkIGZvciB0cmFjZSBldmVudHMNCj4gPiA+ID4gIG9iai0kKENPTkZJR19BTkRST0lEX0JJ TkRFUkZTKQkJKz0gYmluZGVyZnMubw0KPiA+ID4gPiAgb2JqLSQoQ09ORklHX0FORFJPSURfQklO REVSX0lQQykJKz0gYmluZGVyLm8gYmluZGVyX2FsbG9jLm8NCj4gPiA+ID4gIG9iai0kKENPTkZJ R19BTkRST0lEX0JJTkRFUl9JUENfU0VMRlRFU1QpICs9IGJpbmRlcl9hbGxvY19zZWxmdGVzdC5v DQo+ID4gPiA+ICtvYmotJChDT05GSUdfQklOREVSX1RSQU5TQUNUSU9OX0xBVEVOQ1lfVFJBQ0tJ TkcpCSs9IGJpbmRlcl9sYXRlbmN5X3RyYWNlci5vDQo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2FuZHJvaWQvYmluZGVyLmMgYi9kcml2ZXJzL2FuZHJvaWQvYmluZGVyLmMNCj4gPiA+ID4g aW5kZXggMGNhYjkwMC4uNjVhZDM4YyAxMDA2NDQNCj4gPiA+ID4gLS0tIGEvZHJpdmVycy9hbmRy b2lkL2JpbmRlci5jDQo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvYW5kcm9pZC9iaW5kZXIuYw0KPiA+ ID4gPiBAQCAtMjY3NCw2ICsyNjc0LDcgQEAgc3RhdGljIHZvaWQgYmluZGVyX3RyYW5zYWN0aW9u KHN0cnVjdCBiaW5kZXJfcHJvYyAqcHJvYywNCj4gPiA+ID4gIAkJcmV0dXJuX2Vycm9yX2xpbmUg PSBfX0xJTkVfXzsNCj4gPiA+ID4gIAkJZ290byBlcnJfYWxsb2NfdF9mYWlsZWQ7DQo+ID4gPiA+ ICAJfQ0KPiA+ID4gPiArCXRyYWNlX2JpbmRlcl90eG5fbGF0ZW5jeV9hbGxvYyh0KTsNCj4gPiA+ ID4gIAlJTklUX0xJU1RfSEVBRCgmdC0+ZmRfZml4dXBzKTsNCj4gPiA+ID4gIAliaW5kZXJfc3Rh dHNfY3JlYXRlZChCSU5ERVJfU1RBVF9UUkFOU0FDVElPTik7DQo+ID4gPiA+ICAJc3Bpbl9sb2Nr X2luaXQoJnQtPmxvY2spOw0KPiA+ID4gPiBAQCAtNTE3Nyw2ICs1MTc4LDcgQEAgc3RhdGljIHZv aWQgcHJpbnRfYmluZGVyX3RyYW5zYWN0aW9uX2lsb2NrZWQoc3RydWN0IHNlcV9maWxlICptLA0K PiA+ID4gPiAgCQkgICB0b19wcm9jID8gdG9fcHJvYy0+cGlkIDogMCwNCj4gPiA+ID4gIAkJICAg dC0+dG9fdGhyZWFkID8gdC0+dG9fdGhyZWFkLT5waWQgOiAwLA0KPiA+ID4gPiAgCQkgICB0LT5j b2RlLCB0LT5mbGFncywgdC0+cHJpb3JpdHksIHQtPm5lZWRfcmVwbHkpOw0KPiA+ID4gPiArCXRy YWNlX2JpbmRlcl90eG5fbGF0ZW5jeV9pbmZvKG0sIHQpOw0KPiA+ID4gPiAgCXNwaW5fdW5sb2Nr KCZ0LT5sb2NrKTsNCj4gPiA+ID4gIA0KPiA+ID4gPiAgCWlmIChwcm9jICE9IHRvX3Byb2MpIHsN Cj4gPiA+ID4gQEAgLTU4MTgsNCArNTgyMCw4IEBAIHN0YXRpYyBpbnQgX19pbml0IGJpbmRlcl9p bml0KHZvaWQpDQo+ID4gPiA+ICAjZGVmaW5lIENSRUFURV9UUkFDRV9QT0lOVFMNCj4gPiA+ID4g ICNpbmNsdWRlICJiaW5kZXJfdHJhY2UuaCINCj4gPiA+ID4gIA0KPiA+ID4gPiArRVhQT1JUX1RS QUNFUE9JTlRfU1lNQk9MKGJpbmRlcl90eG5fbGF0ZW5jeV9hbGxvYyk7DQo+ID4gPiA+ICtFWFBP UlRfVFJBQ0VQT0lOVF9TWU1CT0woYmluZGVyX3R4bl9sYXRlbmN5X2luZm8pOw0KPiA+ID4gPiAr RVhQT1JUX1RSQUNFUE9JTlRfU1lNQk9MKGJpbmRlcl90eG5fbGF0ZW5jeV9mcmVlKTsNCj4gPiA+ ID4gKw0KPiA+ID4gPiAgTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOw0KPiA+ID4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9hbmRyb2lkL2JpbmRlcl9pbnRlcm5hbC5oIGIvZHJpdmVycy9hbmRyb2lk L2JpbmRlcl9pbnRlcm5hbC5oDQo+ID4gPiA+IGluZGV4IDg3MjIzMmYuLjMwOWQxYjEwIDEwMDY0 NA0KPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2FuZHJvaWQvYmluZGVyX2ludGVybmFsLmgNCj4gPiA+ ID4gKysrIGIvZHJpdmVycy9hbmRyb2lkL2JpbmRlcl9pbnRlcm5hbC5oDQo+ID4gPiA+IEBAIC0x NSw2ICsxNSwxMSBAQA0KPiA+ID4gPiAgI2luY2x1ZGUgPHVhcGkvbGludXgvYW5kcm9pZC9iaW5k ZXJmcy5oPg0KPiA+ID4gPiAgI2luY2x1ZGUgImJpbmRlcl9hbGxvYy5oIg0KPiA+ID4gPiAgDQo+ ID4gPiA+ICsjaWYgSVNfRU5BQkxFRChDT05GSUdfQklOREVSX1RSQU5TQUNUSU9OX0xBVEVOQ1lf VFJBQ0tJTkcpDQo+ID4gPiA+ICsjaW5jbHVkZSA8dWFwaS9saW51eC90aW1lX3R5cGVzLmg+DQo+ ID4gPiA+ICsjaW5jbHVkZSA8bGludXgvcnRjLmg+DQo+ID4gPiA+ICsjZW5kaWYNCj4gPiA+ID4g Kw0KPiA+ID4gPiAgc3RydWN0IGJpbmRlcl9jb250ZXh0IHsNCj4gPiA+ID4gIAlzdHJ1Y3QgYmlu ZGVyX25vZGUgKmJpbmRlcl9jb250ZXh0X21ncl9ub2RlOw0KPiA+ID4gPiAgCXN0cnVjdCBtdXRl eCBjb250ZXh0X21ncl9ub2RlX2xvY2s7DQo+ID4gPiA+IEBAIC01MjQsNiArNTI5LDE0IEBAIHN0 cnVjdCBiaW5kZXJfdHJhbnNhY3Rpb24gew0KPiA+ID4gPiAgCSAqIGR1cmluZyB0aHJlYWQgdGVh cmRvd24NCj4gPiA+ID4gIAkgKi8NCj4gPiA+ID4gIAlzcGlubG9ja190IGxvY2s7DQo+ID4gPiA+ ICsJLyoqDQo+ID4gPiA+ICsJICogQHRpbWVzdGFtcCBhbmQgQHR2IGFyZSB1c2VkIHRvIHJlY29y ZCB0aGUgdGltZQ0KPiA+ID4gPiArCSAqIHRoYXQgdGhlIGJpbmRlciB0cmFuc2FjdGlvbiBzdGFy dHVwDQo+ID4gPiA+ICsJICovDQo+ID4gPiA+ICsjaWYgSVNfRU5BQkxFRChDT05GSUdfQklOREVS X1RSQU5TQUNUSU9OX0xBVEVOQ1lfVFJBQ0tJTkcpDQo+ID4gPiA+ICsJc3RydWN0IHRpbWVzcGVj NjQgdGltZXN0YW1wOw0KPiA+ID4gPiArCXN0cnVjdCBfX2tlcm5lbF9vbGRfdGltZXZhbCB0djsN Cj4gPiA+IA0KPiA+ID4gQXMgSSBzdGF0ZWQgaW4gdGhlIDAvMyBlbWFpbCwgcGxlYXNlIHVzZSB0 aGUgY29ycmVjdCBpbi1rZXJuZWwgc3RydWN0dXJlDQo+ID4gPiBmb3IgdGhpcy4gIFRoYXQgc3Ry dWN0dXJlIGlzIF9PTkxZXyBmb3Igb2xkIHVzZXJzcGFjZSBhcGkgY29tcGF0aWJpbGl0eQ0KPiA+ ID4gaXNzdWVzLiAgV2hpY2ggaXMgbm90IHRoZSBjYXNlIGhlcmUgYXQgYWxsLg0KPiA+ID4gDQo+ ID4gPiB0aGFua3MsDQo+ID4gPiBncmVnIGstaA0KPiA+IA0KPiA+IFNpbmNlIGl0J3Mgbm90IHBy b3BlciB0byB1c2UgdGltZXZhbCAmIF9fa2VybmVsX29sZF90aW1ldmFsLg0KPiA+IFRoZSByZW1h aW5pbmcgc3RydWN0dXJlIHdpdGggdHZfdXNlYyB0aGF0IEkgZm91bmQgaXMNCj4gPiBfX2tlcm5l bF90aW1leF90aW1ldmFsLCBidXQgSSdtIG5vdCBzdXJlIGlmIHRoaXMgaXMgcHJvcGVyIG9uZSBv ciBub3QuDQo+ID4gQWxsIEkgY2FuIHNlZSBpcyBpbg0KPiA+IGh0dHBzOi8vbHduLm5ldC9tbC9s aW51eC1rZXJuZWwvMjAxODA3MDUyMTM2MDQuMTg4ODMtNi1kZWVwYS5rZXJuZWxAZ21haWwuY29t Lw0KPiA+IA0KPiA+IEknbSBhZnJhaWQgb2YgdXNpbmcgd3Jvbmcgc3RydWN0dXJlIGFnYWluLg0K PiA+IENvdWxkIHlvdSBnaXZlIG1lIHNvbWUgYWR2aWNlcyBhYm91dCB0aGlzPw0KPiA+IA0KPiA+ IE9yIGlzIHRoZXJlIGFub3RoZXIgc3VpdGFibGUgd2F5IHRvIHJlcGxhY2UgdGltZXZhbA0KPiAN Cj4gV2hhdCBleGFjdGx5IGFyZSB5b3UgdHJ5aW5nIHRvIG1lYXN1cmUgc3VjaCB0aGF0IHlvdSBm ZWVsIHlvdSBuZWVkIGENCj4gdGltZXZhbCBzdHJ1Y3R1cmU/DQo+IA0KQWN0dWFsbHkgSSdkIGxp a2UgdG8gcmVjb3JkIHRpbWVzdGFtcCB3aXRoIHN0YW5kYXJkIHRpbWUgc3RydWN0dXJlLCBzbyBJ DQp1c2VkICdzdHJ1Y3QgdGltZXZhbCcgaW4gdGhlIHBhc3QgcGF0Y2guIEhvd2V2ZXIgaXQncyBk ZXByZWNhdGVkLCBzbyBJDQphbSBsb29raW5nIGZvciB0aGUgYWx0ZXJuYXRpdmVzLg0KDQpBZGRp dGlvbmFsbHksIEkgaGF2ZSBhbHJlYWR5IGxvb2tlZCBzb21lIHBhdGNoZXMgdGhhdCByZXBsYWNp bmcgdGltZXZhbA0Kd2l0aCB0aW1lc3BlYzY0LiBJJ2xsIGRvIHRoZSBzYW1lIHdheSBpbiBuZXh0 IHZlcnNpb24gcGF0Y2guDQoNCk1hbnkgdGhhbmtzLA0KRnJhbmtpZQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEA41C2BBD0 for ; Tue, 8 Sep 2020 05:38:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E952137B for ; Tue, 8 Sep 2020 05:38:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xT/5/FLN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="SC00cIb1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E952137B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i7/C3TuzR0sVmWPkIPQasFTLkq4TG2kjRcl+g/8zO1o=; b=xT/5/FLN/sVawJR0RxitDEiBs 2ArDy/EMitvR2U5iiSYJvDiYnkrim4n3SSZ/S4bI7i7bFrUgZjLc9dmWiDadIBR+2waD0pV4BI0dY V7tOGCMAeP1wq3ZT6l1s6pWMF/pG10YkbvwyWz96FZNn6i6Qyx/jg6tRiC6fhvR5HiiLcqMYi6ZEM PmhMGmyU4wTklJB0rOoxqe8MtB/3tAYUelyLl6uhBiduxO/5IOPUhCsBT/JZhYQE2yv5ZuAqzwSUk fkEkLk1LpSrdVf6/HmRZcy4+hFqXaaqUd3W4bFs7H3CyStgPK6YDTofZQtkmDJq0p0HBfeKE8AUeP L/m4PDoQw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFWKz-0006v7-5o; Tue, 08 Sep 2020 05:38:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFWKw-0006ug-I5 for linux-mediatek@lists.infradead.org; Tue, 08 Sep 2020 05:38:36 +0000 X-UUID: 130e0ef0bac44c958c81f8ed0d5bda45-20200907 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=vXxcXjp/u4tUTeNK/WwgFqe99QTu92iZSo4LzEOqHcQ=; b=SC00cIb1DdLbVkCvelNk0WpsvUQlLHam3z1EB4hxDQldxQwgsHh3ZMDXCQqmcK3XHUSTmI5mVkw81HZyzjskxjpp/3hmnpT9tdsmvesQ4DmzAAJRHDhLOaBEBwf6MV1lFebxxGoT9mmtY36PfGiDe16Hz49RERro2FZTQbBlzaQ=; X-UUID: 130e0ef0bac44c958c81f8ed0d5bda45-20200907 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 75528169; Mon, 07 Sep 2020 21:38:27 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Sep 2020 22:38:25 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 8 Sep 2020 13:38:24 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 8 Sep 2020 13:38:25 +0800 Message-ID: <1599543504.16905.65.camel@mtkswgap22> Subject: Re: [PATCH v8 3/3] binder: add transaction latency tracer From: Frankie Chang To: Greg Kroah-Hartman Date: Tue, 8 Sep 2020 13:38:24 +0800 In-Reply-To: <20200907140920.GC3719869@kroah.com> References: <20200907070045.GA605692@kroah.com> <1599480055-25781-1-git-send-email-Frankie.Chang@mediatek.com> <1599480055-25781-4-git-send-email-Frankie.Chang@mediatek.com> <20200907122557.GC2029056@kroah.com> <1599486675.16905.34.camel@mtkswgap22> <20200907140920.GC3719869@kroah.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_013834_908988_76F0F1F5 X-CRM114-Status: GOOD ( 44.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Jian-Min Liu , linux-mediatek@lists.infradead.org, Joel Fernandes , Martijn Coenen , Christian Brauner , Todd Kjos Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 2020-09-07 at 16:09 +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 07, 2020 at 09:51:15PM +0800, Frankie Chang wrote: > > On Mon, 2020-09-07 at 14:25 +0200, Greg Kroah-Hartman wrote: > > > On Mon, Sep 07, 2020 at 08:00:55PM +0800, Frankie Chang wrote: > > > > From: "Frankie.Chang" > > > > > > > > Record start/end timestamp for binder transaction. > > > > When transaction is completed or transaction is free, > > > > it would be checked if transaction latency over threshold > > > > (default 2 sec), if yes, printing related information for tracing. > > > > > > > > /* Implement details */ > > > > - Add latency tracer module to monitor transaction > > > > by attaching to new tracepoints introduced > > > > when transactions are allocated and freed. > > > > The trace_binder_txn_latency_free would not be enabled > > > > by default. Monitoring which transaction is too slow to > > > > cause some of exceptions is important. So we hook the > > > > tracepoint to call the monitor function. > > > > > > > > - Since some of modules would trigger timeout NE > > > > if their binder transaction don't finish in time, > > > > such as audio timeout (5 sec), even BT command > > > > timeout (2 sec), etc. > > > > Therefore, setting the timeout threshold as default > > > > 2 seconds could be helpful to debug. > > > > But this timeout threshold is configurable, to let > > > > all users determine the more suitable threshold. > > > > > > > > - The reason why printing the related information to > > > > kernel information log but not trace buffer is that > > > > some abnormal transactions may be pending for a long > > > > time ago, they could not be recorded due to buffer > > > > limited. > > > > > > > > Signed-off-by: Frankie.Chang > > > > Acked-by: Todd Kjos > > > > --- > > > > drivers/android/Kconfig | 8 +++ > > > > drivers/android/Makefile | 1 + > > > > drivers/android/binder.c | 6 ++ > > > > drivers/android/binder_internal.h | 13 ++++ > > > > drivers/android/binder_latency_tracer.c | 112 +++++++++++++++++++++++++++++++ > > > > drivers/android/binder_trace.h | 26 ++++++- > > > > 6 files changed, 163 insertions(+), 3 deletions(-) > > > > create mode 100644 drivers/android/binder_latency_tracer.c > > > > > > > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > > > > index 53b22e2..8aadaf4 100644 > > > > --- a/drivers/android/Kconfig > > > > +++ b/drivers/android/Kconfig > > > > @@ -54,6 +54,14 @@ config ANDROID_BINDER_IPC_SELFTEST > > > > exhaustively with combinations of various buffer sizes and > > > > alignments. > > > > > > > > +config BINDER_TRANSACTION_LATENCY_TRACKING > > > > + tristate "Android Binder transaction tracking" > > > > + help > > > > + Used for track abnormal binder transaction which is over threshold, > > > > + when the transaction is done or be free, this transaction would be > > > > + checked whether it executed overtime. > > > > + If yes, printing out the detailed info. > > > > + > > > > endif # if ANDROID > > > > > > > > endmenu > > > > diff --git a/drivers/android/Makefile b/drivers/android/Makefile > > > > index c9d3d0c9..c2ffdb6 100644 > > > > --- a/drivers/android/Makefile > > > > +++ b/drivers/android/Makefile > > > > @@ -4,3 +4,4 @@ ccflags-y += -I$(src) # needed for trace events > > > > obj-$(CONFIG_ANDROID_BINDERFS) += binderfs.o > > > > obj-$(CONFIG_ANDROID_BINDER_IPC) += binder.o binder_alloc.o > > > > obj-$(CONFIG_ANDROID_BINDER_IPC_SELFTEST) += binder_alloc_selftest.o > > > > +obj-$(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) += binder_latency_tracer.o > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > > > index 0cab900..65ad38c 100644 > > > > --- a/drivers/android/binder.c > > > > +++ b/drivers/android/binder.c > > > > @@ -2674,6 +2674,7 @@ static void binder_transaction(struct binder_proc *proc, > > > > return_error_line = __LINE__; > > > > goto err_alloc_t_failed; > > > > } > > > > + trace_binder_txn_latency_alloc(t); > > > > INIT_LIST_HEAD(&t->fd_fixups); > > > > binder_stats_created(BINDER_STAT_TRANSACTION); > > > > spin_lock_init(&t->lock); > > > > @@ -5177,6 +5178,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m, > > > > to_proc ? to_proc->pid : 0, > > > > t->to_thread ? t->to_thread->pid : 0, > > > > t->code, t->flags, t->priority, t->need_reply); > > > > + trace_binder_txn_latency_info(m, t); > > > > spin_unlock(&t->lock); > > > > > > > > if (proc != to_proc) { > > > > @@ -5818,4 +5820,8 @@ static int __init binder_init(void) > > > > #define CREATE_TRACE_POINTS > > > > #include "binder_trace.h" > > > > > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_alloc); > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_info); > > > > +EXPORT_TRACEPOINT_SYMBOL(binder_txn_latency_free); > > > > + > > > > MODULE_LICENSE("GPL v2"); > > > > diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h > > > > index 872232f..309d1b10 100644 > > > > --- a/drivers/android/binder_internal.h > > > > +++ b/drivers/android/binder_internal.h > > > > @@ -15,6 +15,11 @@ > > > > #include > > > > #include "binder_alloc.h" > > > > > > > > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > > > > +#include > > > > +#include > > > > +#endif > > > > + > > > > struct binder_context { > > > > struct binder_node *binder_context_mgr_node; > > > > struct mutex context_mgr_node_lock; > > > > @@ -524,6 +529,14 @@ struct binder_transaction { > > > > * during thread teardown > > > > */ > > > > spinlock_t lock; > > > > + /** > > > > + * @timestamp and @tv are used to record the time > > > > + * that the binder transaction startup > > > > + */ > > > > +#if IS_ENABLED(CONFIG_BINDER_TRANSACTION_LATENCY_TRACKING) > > > > + struct timespec64 timestamp; > > > > + struct __kernel_old_timeval tv; > > > > > > As I stated in the 0/3 email, please use the correct in-kernel structure > > > for this. That structure is _ONLY_ for old userspace api compatibility > > > issues. Which is not the case here at all. > > > > > > thanks, > > > greg k-h > > > > Since it's not proper to use timeval & __kernel_old_timeval. > > The remaining structure with tv_usec that I found is > > __kernel_timex_timeval, but I'm not sure if this is proper one or not. > > All I can see is in > > https://lwn.net/ml/linux-kernel/20180705213604.18883-6-deepa.kernel@gmail.com/ > > > > I'm afraid of using wrong structure again. > > Could you give me some advices about this? > > > > Or is there another suitable way to replace timeval > > What exactly are you trying to measure such that you feel you need a > timeval structure? > Actually I'd like to record timestamp with standard time structure, so I used 'struct timeval' in the past patch. However it's deprecated, so I am looking for the alternatives. Additionally, I have already looked some patches that replacing timeval with timespec64. I'll do the same way in next version patch. Many thanks, Frankie _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek