From: Kees Cook <keescook@chromium.org>
To: Tycho Andersen <tycho@tycho.pizza>
Cc: Kees Cook <keescook@chromium.org>,
syzbot+3ad9614a12f80994c32e@syzkaller.appspotmail.com,
"Tobin C . Harding" <me@tobin.cc>,
Christian Brauner <christian@brauner.io>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] seccomp: don't leak memory when filter install races
Date: Tue, 8 Sep 2020 11:40:57 -0700 [thread overview]
Message-ID: <159959037666.1186953.15847741084926154331.b4-ty@chromium.org> (raw)
In-Reply-To: <20200902014017.934315-1-tycho@tycho.pizza>
On Tue, 1 Sep 2020 19:40:16 -0600, Tycho Andersen wrote:
> In seccomp_set_mode_filter() with TSYNC | NEW_LISTENER, we first initialize
> the listener fd, then check to see if we can actually use it later in
> seccomp_may_assign_mode(), which can fail if anyone else in our thread
> group has installed a filter and caused some divergence. If we can't, we
> partially clean up the newly allocated file: we put the fd, put the file,
> but don't actually clean up the *memory* that was allocated at
> filter->notif. Let's clean that up too.
>
> [...]
Applied, thanks!
[1/2] seccomp: don't leak memory when filter install races
https://git.kernel.org/kees/c/a566a9012acd
[2/2] mailmap, MAINTAINERS: move to tycho.pizza
https://git.kernel.org/kees/c/19d1d49f2a8c
Best regards,
--
Kees Cook
prev parent reply other threads:[~2020-09-08 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 1:40 [PATCH 1/2] seccomp: don't leak memory when filter install races Tycho Andersen
2020-09-02 1:40 ` [PATCH 2/2] mailmap, MAINTAINERS: move to tycho.pizza Tycho Andersen
2020-09-02 1:40 ` Tycho Andersen
2020-09-02 8:36 ` Christian Brauner
2020-09-02 9:08 ` [PATCH 1/2] seccomp: don't leak memory when filter install races Christian Brauner
2020-09-02 13:39 ` Tycho Andersen
2020-09-08 18:40 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159959037666.1186953.15847741084926154331.b4-ty@chromium.org \
--to=keescook@chromium.org \
--cc=christian@brauner.io \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=syzbot+3ad9614a12f80994c32e@syzkaller.appspotmail.com \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.