All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>,
	<berrange@redhat.com>, <dme@dme.org>
Cc: alex.chen@huawei.com, ann.zhuangyanying@huawei.com,
	zhang.zhanghailiang@huawei.com, xiexiangyou@huawei.com,
	qemu-devel@nongnu.org
Subject: [PATCH v7 09/12] migration/dirtyrate: Implement set_sample_page_period() and get_sample_page_period()
Date: Wed, 9 Sep 2020 22:18:13 +0800	[thread overview]
Message-ID: <1599661096-127913-10-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1599661096-127913-1-git-send-email-zhengchuan@huawei.com>

Implement set_sample_page_period()/get_sample_page_period() to sleep
specific time between sample actions.

Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
---
 migration/dirtyrate.c | 24 ++++++++++++++++++++++++
 migration/dirtyrate.h |  6 ++++++
 2 files changed, 30 insertions(+)

diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index ae1959b..8a30261 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -27,6 +27,30 @@
 static int CalculatingState = DIRTY_RATE_STATUS_UNSTARTED;
 static struct DirtyRateStat DirtyStat;
 
+static int64_t set_sample_page_period(int64_t msec, int64_t initial_time)
+{
+    int64_t current_time;
+
+    current_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
+    if ((current_time - initial_time) >= msec) {
+        msec = current_time - initial_time;
+    } else {
+        g_usleep((msec + initial_time - current_time) * 1000);
+    }
+
+    return msec;
+}
+
+static bool get_sample_page_period(int64_t sec)
+{
+    if (sec < MIN_FETCH_DIRTYRATE_TIME_SEC ||
+        sec > MAX_FETCH_DIRTYRATE_TIME_SEC) {
+        return false;
+    }
+
+    return true;
+}
+
 static int dirtyrate_set_state(int *state, int old_state, int new_state)
 {
     assert(new_state < DIRTY_RATE_STATUS__MAX);
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index faaf9da..8f9bc80 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -29,6 +29,12 @@
  */
 #define MIN_RAMBLOCK_SIZE                         128
 
+/*
+ * Take 1s as minimum time for calculation duration
+ */
+#define MIN_FETCH_DIRTYRATE_TIME_SEC              1
+#define MAX_FETCH_DIRTYRATE_TIME_SEC              60
+
 struct DirtyRateConfig {
     uint64_t sample_pages_per_gigabytes; /* sample pages per GB */
     int64_t sample_period_seconds; /* time duration between two sampling */
-- 
1.8.3.1



  parent reply	other threads:[~2020-09-09 14:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 14:18 [PATCH v7 00/12] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-09-09 14:18 ` [PATCH v7 01/12] migration/dirtyrate: setup up query-dirtyrate framwork Chuan Zheng
2020-09-09 14:18 ` [PATCH v7 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status Chuan Zheng
2020-09-10 14:27   ` Li Qiang
2020-09-09 14:18 ` [PATCH v7 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info Chuan Zheng
2020-09-09 14:18 ` [PATCH v7 04/12] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-09-10 16:27   ` Dr. David Alan Gilbert
2020-09-09 14:18 ` [PATCH v7 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-09-09 14:18 ` [PATCH v7 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-09-10 13:51   ` Li Qiang
2020-09-13  2:59     ` Zheng Chuan
2020-09-14 11:25       ` Li Qiang
2020-09-09 14:18 ` [PATCH v7 07/12] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-09-10 16:45   ` Dr. David Alan Gilbert
2020-09-09 14:18 ` [PATCH v7 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-09-09 14:18 ` Chuan Zheng [this message]
2020-09-10 13:59   ` [PATCH v7 09/12] migration/dirtyrate: Implement set_sample_page_period() and get_sample_page_period() Li Qiang
2020-09-13  3:00     ` Zheng Chuan
2020-09-09 14:18 ` [PATCH v7 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-09-10 17:26   ` Dr. David Alan Gilbert
2020-09-09 14:18 ` [PATCH v7 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-09-10 14:27   ` Li Qiang
2020-09-13  3:00     ` Zheng Chuan
2020-09-10 17:36   ` Dr. David Alan Gilbert
2020-09-09 14:18 ` [PATCH v7 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug Chuan Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1599661096-127913-10-git-send-email-zhengchuan@huawei.com \
    --to=zhengchuan@huawei.com \
    --cc=alex.chen@huawei.com \
    --cc=ann.zhuangyanying@huawei.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=dme@dme.org \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=xiexiangyou@huawei.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.