* [PATCH] net/sfc: fix meson build warning with gcc
@ 2018-04-16 17:09 Ferruh Yigit
2018-04-16 17:31 ` Thomas Monjalon
2018-04-17 8:59 ` Bruce Richardson
0 siblings, 2 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-04-16 17:09 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dev, Ferruh Yigit, Bruce Richardson
icc flag is causing build error with gcc, build error:
cc1: warning: unrecognized gcc debugging option: i
cc1: warning: unrecognized gcc debugging option: g
cc1: warning: unrecognized gcc debugging option: -
cc1: warning: unrecognized gcc debugging option: d
cc1: warning: unrecognized gcc debugging option: i
cc1: warning: unrecognized gcc debugging option: s
cc1: warning: unrecognized gcc debugging option: b
cc1: warning: unrecognized gcc debugging option: l
cc1: warning: unrecognized gcc debugging option: e
cc1: warning: unrecognized gcc debugging option:
cc1: warning: unrecognized gcc debugging option: 3
cc1: warning: unrecognized gcc debugging option: 6
cc1: warning: unrecognized gcc debugging option: 5
cc1: warning: unrecognized gcc debugging option: 6
cc1: warning: unrecognized command line option
‘-Wno-address-of-packed-member’
Removing icc flag completely since it is not supported right now.
Fixes: f16d0b36f816 ("drivers/net: fix icc deprecated parameter warning")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/sfc/meson.build | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build
index a37fc44a7..0de2e17fe 100644
--- a/drivers/net/sfc/meson.build
+++ b/drivers/net/sfc/meson.build
@@ -30,10 +30,6 @@ extra_flags += [
'-Wbad-function-cast'
]
-# Suppress ICC false positive warning on 'bulk' may be used before its
-# value is set
-extra_flags += '-diag-disable 3656'
-
foreach flag: extra_flags
if cc.has_argument(flag)
cflags += flag
--
2.14.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sfc: fix meson build warning with gcc
2018-04-16 17:09 [PATCH] net/sfc: fix meson build warning with gcc Ferruh Yigit
@ 2018-04-16 17:31 ` Thomas Monjalon
2018-04-17 8:59 ` Bruce Richardson
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-04-16 17:31 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Andrew Rybchenko, Bruce Richardson
16/04/2018 19:09, Ferruh Yigit:
> icc flag is causing build error with gcc, build error:
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: g
> cc1: warning: unrecognized gcc debugging option: -
> cc1: warning: unrecognized gcc debugging option: d
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: s
> cc1: warning: unrecognized gcc debugging option: b
> cc1: warning: unrecognized gcc debugging option: l
> cc1: warning: unrecognized gcc debugging option: e
> cc1: warning: unrecognized gcc debugging option:
> cc1: warning: unrecognized gcc debugging option: 3
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized gcc debugging option: 5
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized command line option
> ‘-Wno-address-of-packed-member’
>
> Removing icc flag completely since it is not supported right now.
>
> Fixes: f16d0b36f816 ("drivers/net: fix icc deprecated parameter warning")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/sfc: fix meson build warning with gcc
2018-04-16 17:09 [PATCH] net/sfc: fix meson build warning with gcc Ferruh Yigit
2018-04-16 17:31 ` Thomas Monjalon
@ 2018-04-17 8:59 ` Bruce Richardson
1 sibling, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2018-04-17 8:59 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Andrew Rybchenko, dev
On Mon, Apr 16, 2018 at 06:09:29PM +0100, Ferruh Yigit wrote:
> icc flag is causing build error with gcc, build error:
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: g
> cc1: warning: unrecognized gcc debugging option: -
> cc1: warning: unrecognized gcc debugging option: d
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: s
> cc1: warning: unrecognized gcc debugging option: b
> cc1: warning: unrecognized gcc debugging option: l
> cc1: warning: unrecognized gcc debugging option: e
> cc1: warning: unrecognized gcc debugging option:
> cc1: warning: unrecognized gcc debugging option: 3
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized gcc debugging option: 5
> cc1: warning: unrecognized gcc debugging option: 6
> cc1: warning: unrecognized command line option
> ‘-Wno-address-of-packed-member’
>
> Removing icc flag completely since it is not supported right now.
>
> Fixes: f16d0b36f816 ("drivers/net: fix icc deprecated parameter warning")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> ---
And just by way of further info, the underlying problem here is that gcc is
returning 0 i.e. not reporting error, when called normally with
-diag-disable flag. This prevents meson from detecting that the flag is
unsupported. :-(
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-17 8:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 17:09 [PATCH] net/sfc: fix meson build warning with gcc Ferruh Yigit
2018-04-16 17:31 ` Thomas Monjalon
2018-04-17 8:59 ` Bruce Richardson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.