All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Valente <paolo.valente@linaro.org>
To: sedat.dilek@gmail.com
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
	Jens Axboe <axboe@kernel.dk>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-block@vger.kernel.org, Goldwyn Rodrigues <rgoldwyn@suse.de>,
	Mark Brown <broonie@kernel.org>
Subject: Re: Playing with BFQ
Date: Tue, 16 May 2017 15:28:36 +0200	[thread overview]
Message-ID: <15C3004B-B176-434B-A7E7-2DCD898C49D6@linaro.org> (raw)
In-Reply-To: <CA+icZUXxnq2MAhZcmQ=x_tzvBeCWHyQETenM7h2Ug19rYj6CNw@mail.gmail.com>


> Il giorno 16 mag 2017, alle ore 15:22, Sedat Dilek =
<sedat.dilek@gmail.com> ha scritto:
>=20
> On Tue, May 16, 2017 at 10:45 AM, Paolo Valente
> <paolo.valente@linaro.org> wrote:
>>=20
>>> Il giorno 13 mag 2017, alle ore 09:50, Sedat Dilek =
<sedat.dilek@gmail.com> ha scritto:
>>>=20
>>> On Wed, May 3, 2017 at 11:21 AM, Paolo Valente =
<paolo.valente@linaro.org> wrote:
>>>>=20
>>>>> Il giorno 03 mag 2017, alle ore 10:00, Sedat Dilek =
<sedat.dilek@gmail.com> ha scritto:
>>>>>=20
>>>>> On Tue, May 2, 2017 at 2:16 PM, Markus Trippelsdorf
>>>>> <markus@trippelsdorf.de> wrote:
>>>>>> On 2017.05.02 at 14:07 +0200, Sedat Dilek wrote:
>>>>>>> On Tue, May 2, 2017 at 10:00 AM, Markus Trippelsdorf
>>>>>>> <markus@trippelsdorf.de> wrote:
>>>>>>>> On 2017.05.02 at 09:54 +0200, Sedat Dilek wrote:
>>>>>>>>> Hi,
>>>>>>>>>=20
>>>>>>>>> I want to play with BFQ.
>>>>>>>>>=20
>>>>>>>>> My base is block-next as of 28-Apr-2017.
>>>>>>> [...]
>>>>>>>>> Not sure if the attached patches make sense (right now).
>>>>>>>>=20
>>>>>>>> No, it doesn't make sense at all.
>>>>>>>=20
>>>>>>> Hmm, I looked at 4.11.0-v8r11 and 0001 has exactly what my 2 =
patches do :-).
>>>>>>=20
>>>>>> BFQ started as a conventional scheduler. But because mq is the =
way of
>>>>>> the future it was ported before it was accepted into mainline.
>>>>>>=20
>>>>>=20
>>>>> I am still playing and want to do my own experiences with BFQ.
>>>>>=20
>>>>> Not sure if FIO is a good testcase-tool here.
>>>>>=20
>>>>=20
>>>> If you want to perform a thorough benchmarking of also =
responsiveness
>>>> and latency for time-sensitive applications (such as video playing)
>>>> then you may want to use S [1].  It's rather rustic, do ask if you
>>>> encounter any difficulty.
>>>>=20
>>>> [1] https://github.com/Algodev-github/S
>>>>=20
>>>=20
>>> Sorry for the delay.
>>=20
>> Don't worry, I'm replying late too ...
>>=20
>>> Currently, I am swittching from Ubuntu/precise 12.04 LTS (EOL) back =
to
>>> the Debian world.
>>>=20
>>> The responsiveness is really bad when my mlocate cron-job, a git =
pull
>>> on linux.git and firefox runs parallel.
>>=20
>> Thanks for reporting this issue.  I have a few considerations and
>> requests for information on it.
>>=20
>> 1) Two of the three sources of I/O you mention, namely mlocate update
>> and git pull, are doing writes.  As I already pointed in a few
>> occasions and places, intense write workloads trigger problems that =
an
>> I/O scheduler cannot solve.  In contrast, these problems *can* be
>> solved using BFQ.  In particular, I already have a prototype =
solution,
>> but I have't found support yet to turn it into a possible
>> production-level solution;  till a few days, ago, when I talked about
>> this with Goldwyn Rodrigues (in CC). He seems interested in having a
>> look at this solution, and possibly collaborating on it.
>>=20
>> 2) A web browser like Firefox can generate extremely varying
>> workloads; so, if you mentioned Firefox as one of the sources of I/O
>> in your unlucky situation, then it would be important to know what
>> Firefox was doing.
>>=20
>> 3) Even if BFQ cannot counteract problems occurring above its head, =
it
>> usually improves responsiveness even in heavy-write scenarios.  It
>> would then be interesting if you could compare responsiveness with =
the
>> other I/O schedulers (mq-deadline, Kyber) and with none too (make =
sure
>> that the I/O is really the same in all cases).
>>=20
>=20
> Not willing to test on this dead horse called Ubuntu 12.04.
>=20
>>=20
>>> This is with Linux v4.11.1-rc1 and BFQ patchset v4.11.0-v8r11.
>>>=20
>>> My linux-config is attached.
>>>=20
>>>>> So if MQ is the way why isn't the Kconfig called =
CONFIG_MQ_IOSCHED_BFQ
>>>>> according to CONFIG_MQ_IOSCHED_DEADLINE?
>>>>>=20
>>>>> As we are talking about "*Storage* I/O schedulers" which of the MQ
>>>>> Kconfig make sense when using MQ_DEADLINE and (MQ_)BFQ?
>>>>>=20
>>>>> # egrep -i 'bfq|deadline|_mq|mq_|_mq_' =
/boot/config-4.11.0-1-bfq-amd64
>>>>> CONFIG_POSIX_MQUEUE=3Dy
>>>>> CONFIG_POSIX_MQUEUE_SYSCTL=3Dy
>>>>> CONFIG_BLK_WBT_MQ=3Dy
>>>>> CONFIG_BLK_MQ_PCI=3Dy
>>>>> CONFIG_BLK_MQ_VIRTIO=3Dy
>>>>> CONFIG_IOSCHED_DEADLINE=3Dy
>>>>> CONFIG_IOSCHED_BFQ=3Dy
>>>>> CONFIG_BFQ_GROUP_IOSCHED=3Dy
>>>>> # CONFIG_DEFAULT_DEADLINE is not set
>>>>> CONFIG_DEFAULT_BFQ=3Dy
>>>>> CONFIG_DEFAULT_IOSCHED=3D"bfq"
>>>>> CONFIG_MQ_IOSCHED_DEADLINE=3Dy
>>>>> # CONFIG_NET_SCH_MQPRIO is not set
>>>>> CONFIG_SCSI_MQ_DEFAULT=3Dy
>>>>> # CONFIG_DM_MQ_DEFAULT is not set
>>>>>=20
>>>>=20
>>>> The config for BFQ seems correct.  For the others, it depends on =
what
>>>> scheduler you want.  If useful for you, the other two MQ- =
schedulers
>>>> are mq-deadline and cyber.
>>>>=20
>>>=20
>>> What about those two (Kconfig) patches which is in your current
>>> bfq-4.11.y patchset.
>>>=20
>>=20
>> I'm not sure I fully understand the purpose of the two patches you
>> propose (in your following emails).  The first patch seems to move =
BFQ
>> config options to a different position in Kconfig.iosched, but the
>> position of those items should be irrelevant.  Am I missing =
something?
>> The second patch seems to have to do with configuration bits of bfq
>> for blk, yet such a bfq version is not available in mainline.
>>=20
>> In any case, for possible new submissions, you should inline your
>> patches.  For complete instructions on submitting patches, have a =
look
>> at Documentation/process/submitting-patches
>>=20
>=20
> All my testings was done with your patchset against Linux v4.11.y.
> You have the same kconfig/kbuild stuff in your 0001 patch [1], so :-)?
> What you have in 0001 is missing in Linux v4.12-rc1.
> Not sure if this is intended.

4.12-rc1 contains bfq for blk-mq, while the patch you mention is for
bfq for blk (never accepted in mainline).  Maybe you could get a
clearer idea by having a look at the commits that add bfq (for blk-mq)
in 4.12-rc1.

Hope this helps,
Paolo

> I will re-submit and add a "4.12" in the subject-line when I am at =
home.
>=20
> - Sedat -
>=20
> [1] =
http://algo.ing.unimo.it/people/paolo/disk_sched/patches/4.11.0-v8r11/0001=
-block-cgroups-kconfig-build-bits-for-BFQ-v7r11-4.11..patch

  reply	other threads:[~2017-05-16 13:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-02  7:54 Playing with BFQ Sedat Dilek
2017-05-02  8:00 ` Markus Trippelsdorf
2017-05-02  8:07   ` Sedat Dilek
2017-05-02  9:14     ` Sedat Dilek
2017-05-02 12:07   ` Sedat Dilek
2017-05-02 12:16     ` Markus Trippelsdorf
2017-05-03  8:00       ` Sedat Dilek
2017-05-03  9:16         ` Markus Trippelsdorf
2017-05-03  9:24           ` Paolo Valente
2017-05-13  7:54             ` Sedat Dilek
2017-05-13  8:00               ` Sedat Dilek
2017-05-03  9:21         ` Paolo Valente
2017-05-13  7:50           ` Sedat Dilek
2017-05-16  8:45             ` Paolo Valente
2017-05-16 13:22               ` Sedat Dilek
2017-05-16 13:28                 ` Paolo Valente [this message]
2017-05-16 13:38                   ` Sedat Dilek
2017-05-16 13:41                     ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15C3004B-B176-434B-A7E7-2DCD898C49D6@linaro.org \
    --to=paolo.valente@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=broonie@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=rgoldwyn@suse.de \
    --cc=sedat.dilek@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.