From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46609 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvxmQ-0007qD-AG
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 15:36:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <andreas.faerber@web.de>) id 1OvxmG-0006Tm-Qg
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 15:36:30 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:43717)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <andreas.faerber@web.de>) id 1OvxmG-0006T5-Kp
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 15:36:20 -0400
Message-Id: <15F942FE-97D7-4747-A80E-219FF54DDB04@web.de>
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
In-Reply-To: <AANLkTinSUjEHqFpNSqt0dF-r5ft5TWnFpWfu9ZVLQ-dA@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Wed, 15 Sep 2010 21:35:56 +0200
References: <EB85576B-C366-4830-8993-B02083CA6F16@web.de>
	<1284574159-892-1-git-send-email-andreas.faerber@web.de>
	<AANLkTinSUjEHqFpNSqt0dF-r5ft5TWnFpWfu9ZVLQ-dA@mail.gmail.com>
Sender: andreas.faerber@web.de
Subject: [Qemu-devel] Re: [PATCH v6] Introduce qemu_madvise()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Am 15.09.2010 um 21:00 schrieb Blue Swirl:

> madvise() actually
> returns 0 or -1 with error code in errno. Should we try to match that?

posix_madvise() doesn't seem to... "otherwise, an error number shall  
be returned to indicate the error"

It documents EINVAL for invalid advice, and so does madvise. Are we  
using ENOTSUP knowingly?

Maybe return -1 and set errno to the posix_madvise() return code? (but  
is it errno = -retval or errno = retval then?)

Andreas