From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC0CC433E1 for ; Tue, 18 Aug 2020 20:02:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD2122075E for ; Tue, 18 Aug 2020 20:02:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uCpv3d7l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h16vjtuk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD2122075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xJQZ1KJrVadZVKhg6wnveKO/Kt9+OUqovoE3Ps44gAI=; b=uCpv3d7lt+p31uNrxB1xTjP9R 8q6xtJylR9gYTGk2CLHXvoUY2qamd25vMG+5gMtnxVE//+5xWqJTOr4vWuKaP0nZv3NxywAs1e20N E53vX/2jWd1uWgvOvDgJeOLUEhvFEBOLpuMWkypi9/38DgkZxoLOTqeNLWTh1BbWUNBbhFzPITLNE tLeMl1J9UOIoDCAnn1Xs+ks38E5NKimcSbW2YyovVImv9VKqv6dpElBOOJzE7R+85PGXRrLJtmdPD Te9eQqJ48bfmYFV90nYBqOizdEda20Kd67GDkX/VOs+nvxDJx6kZoJkWM+LmWxnXSPesPWZkTaNZW dzwWK5Enw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k87mK-0007Nr-6L; Tue, 18 Aug 2020 20:00:16 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k87mH-0007MF-C2 for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 20:00:14 +0000 Received: by mail-pf1-x441.google.com with SMTP id a79so10487266pfa.8 for ; Tue, 18 Aug 2020 13:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U+4owX93EjSbz+LxJpOtVNg7eTsLSFrjIGt3YSoYydc=; b=h16vjtuk6fEjDkgMOoSqeq3Qry1HRZ3une28sHJYTEtj4SWXZoGTHpM5oZGfBuJusl Giqp5sYY6RjncNXhtKltuRG4Dkx6Go4XdZNZEgyjamRMOg/88nMT6UcRGKpauU3cNsPE eaF2NDs59N7pPooamLXrzh+uIBwOoo9z5kahO7dI8UQjTZ7GcLKpn+2QK9ux87NSZnSp QoGToxebMyG1GIGJ33biTzkT7gy53yrrs3Cc3weqQbjtJMkOJe5cw7M3rmiAcmg96SOl WfEJn5iIbwMVpCugFjVZoupEzkTZ8xre6B+KXWFtCqktBR3Y+n5j6m6GJbS/XPzZrxsP Qawg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U+4owX93EjSbz+LxJpOtVNg7eTsLSFrjIGt3YSoYydc=; b=CJLFkqXZV09DGEOu2yoAFqMRVbVit/KqzPLhxhVuDoNFYUxcZ2QYxWCJgHZLUa20a9 fEt0B8I256CdR2jWUr477zNVtjy6YGFD/vLZX7rjl9H5Q1qfIlCRExFyyigEd2e5kGho ljp6RARD19NTfHufhnU2KTRYJKRJjHLbx9PXI2CSMLB5dOQhc6oh5pjDMzP8DaPfxElX Am513MI5LN26vw0+oQh9g3pkgEsuSon/899OzZIFccFJjOO2vL7EQcRwSPDHrp5HB3pZ B3RBtZP4mYFTaUX0xLryl3QjoZnOPUlXr2kJFbvSVB9ZbSgno1fOrUdDVMi1mooJwNkr 71gg== X-Gm-Message-State: AOAM533tVmb8mtyNutXx1YFLw/ghmLkUqYH1xj6M2NH6q4ls0RiOdHng /cAl/+NGjFEebXP2WXZPJVQ= X-Google-Smtp-Source: ABdhPJwP4inEpFe+TBXTCBcjLuEudMOqPAlNvSRjauXcv4wAc7F/G9vUTyF8vQXo47zAWdp4krGCuQ== X-Received: by 2002:a63:8ec8:: with SMTP id k191mr14354972pge.154.1597780810475; Tue, 18 Aug 2020 13:00:10 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id hi13sm655710pjb.26.2020.08.18.13.00.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2020 13:00:09 -0700 (PDT) Subject: Re: [PATCH v1 6/6] ARM: BCM5301X: Add DT for Meraki MR32 To: Christian Lamparter , linux-arm-kernel@lists.infradead.org References: <90b9f9e7e9a50099c88d4ffbc6868dd0ed436944.1597768760.git.chunkeey@gmail.com> <942144b9b030b0cafd07bb019347f26403734600.1597768760.git.chunkeey@gmail.com> <8d2f02c85824df460282a06540cf6c735c8161ac.1597768760.git.chunkeey@gmail.com> <5e9435aabe663fecd76ecf7775bbfd2d60021b16.1597768760.git.chunkeey@gmail.com> From: Florian Fainelli Message-ID: <15cb10dc-440e-d30a-f857-c500c7b41561@gmail.com> Date: Tue, 18 Aug 2020 13:00:08 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <5e9435aabe663fecd76ecf7775bbfd2d60021b16.1597768760.git.chunkeey@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_160013_448814_6DF574B7 X-CRM114-Status: GOOD ( 27.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , bcm-kernel-feedback-list@broadcom.com, Chris Blake , Rob Herring Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/18/2020 9:39 AM, Christian Lamparter wrote: > This patch adds support for Cisco Meraki MR32. > The unit was donated by Chris Blake. Thank you! > > SoC: Broadcom BCM53016A1 (1 GHz, 2 cores) > RAM: 128 MiB > NAND: 128 MiB Spansion S34ML01G2 (~114 MiB useable) > ETH: 1GBit Ethernet Port - PoE > WIFI1: Broadcom BCM43520 an+ac (2x2:2 - id: 0x4352) > WIFI2: Broadcom BCM43520 bgn (2x2:2 - id: 0x4352) > WIFI3: Broadcom BCM43428 abgn (1x1:1 - id: 43428) > > BLE: Broadcom BCM20732 (ttyS1) > LEDS: 1 x Programmable RGB Status LED (driven by a PWM) > 1 x White LED (GPIO) > 1 x Orange LED Fault Indicator (GPIO) > 2 x LAN Activity / Speed LEDs (On the RJ45 Port) > BUTTON: one Reset button > MISC: AT24C64 8KiB EEPROM (i2c - stores Ethernet MAC) > ina219 hardware monitor (i2c) > Kensington Lock > > SERIAL: > WARNING: The serial port needs a TTL/RS-232 3V3 level converter! > The Serial setting is 115200-8-N-1. The board has a populated > right angle 1x4 0.1" pinheader. > The pinout is: VCC, RX, TX, GND. > > Odd stuff: > - uart0 clock frequency is 62.5 MHz. > - The LEDs are labeled as SYS-LED1 through SYS-LED3 > because of the silkscreen on the PCB. > - the original u-boot has been compiled with most functions > and commands disabled. The u-boot env isn't setup properly > either and as a result, the bcm47xxpart probing is not > working. Hence, the nand partitions are specified through a > "fixed-partition" binding. > - The "WICED SMART(TM)" Bluetooth LE 4.0 BCM20732 chip is > connected to uart2 of the SoC. The BCM20732 does not > provide a HCI. So the linux' bluetooth stack is useless. > The mock-up node with the compatible binding and > enable-gpios property is provided solely as documentation. > > Signed-off-by: Christian Lamparter > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/bcm53016-meraki-mr32.dts | 191 +++++++++++++++++++++ > 2 files changed, 192 insertions(+) > create mode 100644 arch/arm/boot/dts/bcm53016-meraki-mr32.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index e6a1cac0bfc7..b0756d62772b 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -126,6 +126,7 @@ dtb-$(CONFIG_ARCH_BCM_5301X) += \ > bcm47094-luxul-xwr-3100.dtb \ > bcm47094-luxul-xwr-3150-v1.dtb \ > bcm47094-netgear-r8500.dtb \ > + bcm53016-meraki-mr32.dtb \ > bcm47094-phicomm-k3.dtb \ > bcm94708.dtb \ > bcm94709.dtb \ > diff --git a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts > new file mode 100644 > index 000000000000..816fe8cd492d > --- /dev/null > +++ b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts > @@ -0,0 +1,191 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > +/* > + * Broadcom BCM470X / BCM5301X ARM platform code. > + * DTS for Meraki MR32 / Codename: Espresso > + * > + * Copyright (C) 2018-2020 Christian Lamparter > + */ > + > +/dts-v1/; > + > +#include "bcm4708.dtsi" > +#include "bcm5301x-nand-cs0-bch8.dtsi" > +#include > + > +/ { > + compatible = "meraki,mr32", "brcm,brcm53016", "brcm,bcm4708"; > + model = "Meraki MR32"; > + > + chosen { > + bootargs = " console=ttyS0,115200n8 earlycon"; > + }; > + > + memory { > + reg = <0x00000000 0x08000000>; Should not this include a device_type = "memory" property? Also, it should be memory@0 to avoid DTC warnings. [snip] > + > +&gmac1 { > + status = "disabled"; > +}; > +&gmac2 { > + status = "disabled"; > +}; > +&gmac3 { > + status = "disabled"; > +}; We should probably make the various gmac nodes disabled by default at some point. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel