From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH 3/5] net/ixgbe: add module EEPROM callbacks
 for ixgbe
Date: Tue, 13 Mar 2018 14:46:50 +0000
Message-ID: <15e2e186-0ca1-0998-8f28-caaf0f034f49@intel.com>
References: <1520828243-25191-1-git-send-email-zijie.pan@6wind.com>
 <1520828243-25191-4-git-send-email-zijie.pan@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Zijie Pan <zijie.pan@6wind.com>
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 84DF8AACA
 for <dev@dpdk.org>; Tue, 13 Mar 2018 15:46:52 +0100 (CET)
In-Reply-To: <1520828243-25191-4-git-send-email-zijie.pan@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 12/03/2018 04:17, Zijie Pan wrote:
[..]
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c |   76 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)

Reviewed-by: Remy Horton <remy.horton@intel.com>


> +	if (addr_mode & IXGBE_SFF_ADDRESSING_MODE) {
> +		PMD_DRV_LOG(ERR, "Address change required to access page 0xA2, but not supported. Please report the module type to the driver maintainers.");

Checkpatch: 80 characters