From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41990C433EF for ; Mon, 20 Dec 2021 12:54:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DFE3283267; Mon, 20 Dec 2021 13:54:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oD4BaxfJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D7D2B83046; Sun, 19 Dec 2021 12:20:44 +0100 (CET) Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1523A82F95 for ; Sun, 19 Dec 2021 12:20:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=fr0st61te@gmail.com Received: by mail-lf1-x12e.google.com with SMTP id l22so15091701lfg.7 for ; Sun, 19 Dec 2021 03:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=1Dk4Eq5NjjHc2yLTCKF1kyVHPzMpMguzhwOha/j+z7o=; b=oD4BaxfJLT08dBbERycDjSs2KkEnwjE1DyXuXGNMLoEbtX5RzBfmetQ9qVuiQS39DN P7cI+waWx++NJL602fjX1KIwfoTLi6h31qCChV4gZdJKwguf1dMssbfHaqsdqqojyE84 5aHukTGSvCUeQmQ/pSt0qKHeWpVgxBp9pSS1lwl8Hiu2XdRuOa9mujNj3eFQo6zD3xv8 aWDvtjQOYqiYRw6acnHqbxHd2Y/plQBLCdjcudpR5M6mRgOqFw7snfinUPxPG/OPxHrm DvC1lCAtyCnZxrfM+gLAME4YUT2rYBDTKm38m6cyMdBxHgUWfpjS/Zs//EPTlpYXPafd 07/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=1Dk4Eq5NjjHc2yLTCKF1kyVHPzMpMguzhwOha/j+z7o=; b=2QjzMVjeLLnVKjMCn6O9it8Sr0rS1ETkHp1tSxmCu1iBC7OzXUtWehBmeEolFyyFz0 M+XODaFYvbEfp51hSh2+rl+Dk7M1uqloYO9fmzmiJW0GEHVD8oUEVQZt1tATcsrPfJ3I ni+H16uikFat5pI2LafhOV9t99EKLJkBr2vUfwUqczX5njoCYuGMZEWXO3wW03lNrD2P jcNS8IBNT3mPkiptg65tBVfQ1TALLcv4Cbbo3Tfovp8cJ2d5exzYyM3N6p+88lgfoETA pLSeX5wQpbdoNtbBteMtX/NkTn8DCSuowa1izwE02ItME0YMmgHoAEcSsgNUE6iXDhpK kHog== X-Gm-Message-State: AOAM530YEHk1smqX43P7tK2JYj7szCQ/B1Me+IiJDslKRS686lbDcaFB uhcnLby/D2nTF577+fwuwm4= X-Google-Smtp-Source: ABdhPJzHh5fdQaEvbyF4QG9/drOct9vAOMfi3JUZIyJTmtVXDh5qOxhRXNl72S0bRqTykg/9z1WNuA== X-Received: by 2002:a05:6512:39c4:: with SMTP id k4mr11191179lfu.79.1639912841389; Sun, 19 Dec 2021 03:20:41 -0800 (PST) Received: from [100.119.25.86] (95-31-191-138.broadband.corbina.ru. [95.31.191.138]) by smtp.gmail.com with ESMTPSA id c36sm85878lfv.193.2021.12.19.03.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Dec 2021 03:20:40 -0800 (PST) Message-ID: <15e3b8694c54a48ba1c508adaf612f9ad3dd399a.camel@gmail.com> Subject: Re: [PATCH] fw_setenv: Unbreak fw_setenv caused by buggy MEMISLOCKED use From: Ivan Mikhaylov To: Joakim Tjernlund , "u-boot@lists.denx.de" , "joe.hershberger@ni.com" Date: Sun, 19 Dec 2021 14:20:40 +0000 In-Reply-To: References: <20211208143311.32178-1-joakim.tjernlund@infinera.com> <737669d5049da1341a4705d8d88b3b75e3bcb5d7.camel@infinera.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 20 Dec 2021 13:54:44 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, 2021-12-18 at 18:23 +0000, Joakim Tjernlund wrote: > Ping? > Maybe just revert commit 8a726b852502 ("fw_setenv: lock the flash > only if it was locked before") ? > > ________________________________________ > From: Joakim Tjernlund > Sent: 13 December 2021 18:22 > To: u-boot@lists.denx.de; joe.hershberger@ni.com; fr0st61te@gmail.com > Subject: Re: [PATCH] fw_setenv: Unbreak fw_setenv caused by buggy > MEMISLOCKED use > > +Joe Hershberger > >  Jocke > > On Wed, 2021-12-08 at 15:33 +0100, Joakim Tjernlund wrote: > > Commit "fw_setenv: lock the flash only if it was locked before" > > checks for Locked status with uninitialized erase data. > > Address by moving the test for MEMISLOCKED. > > > > Fixes: 8a726b852502 ("fw_setenv: lock the flash only if it was > > locked before") > > Signed-off-by: Joakim Tjernlund Joakim, can you provide more detailed description about what you want to fix or revert, please? In which case you see problems with 8a726b852502? Thanks.