From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 526DDC433F5 for ; Tue, 15 Mar 2022 19:08:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E734D83AC4; Tue, 15 Mar 2022 20:08:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=boundarydevices.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=boundarydevices.com header.i=@boundarydevices.com header.b="cUgJ42cz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BC14F83AC4; Tue, 15 Mar 2022 20:08:09 +0100 (CET) Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1A46283A9F for ; Tue, 15 Mar 2022 20:08:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=boundarydevices.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=troy.kisky@boundarydevices.com Received: by mail-pj1-x1034.google.com with SMTP id v4so299539pjh.2 for ; Tue, 15 Mar 2022 12:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=RdS5iJcwdluBXH/b+VDeDuN/KqLYIECT9kY4jQncf4g=; b=cUgJ42czUfwvCpPZj6qqUmfNMiGbEaHFNAn/SkH7ve6tPLfUaSe6duIeUFLBHZOLz1 ov4xNtia7xjFzv6HBcP1Y9HxPDePn849+nm3RKXSoKomFmR7IdvCKBW5HPsOaCjfCx8u EMQqq6O57s6xNrVjw+ZBbd6MmQ0CPfsyFUiQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=RdS5iJcwdluBXH/b+VDeDuN/KqLYIECT9kY4jQncf4g=; b=xOrSfSHryqekJr+6P/Qp4RWmumDZ0CDMbLwtCQZWUV58lnVjKcWraQUqFJR8HJXgRt g+XHHWBNChWH3IZvGeJkUyu6OwuHMs500XlRgDNhYuD5N+gHsni+XkTcejp7pbN421Xx DIa1eFxAhrj3gR6t1cqI7EqxgWbL8KFQsSpbOlKCQ8+U3tw+0y5bDbxC8lHSSwlr0eu3 IcBsRd/+5SK7kNR3+r7GCip59V2yDbx8LC6mvWyApZH66nxgIHExTBn+Ta1r/1mjF+Uy oCUITyf5vKQx93n+CRmkj9qmAmtxE2QBYFaOx2rHzC7U1uwWTga6OJBf4l/RGOqr5o03 c/ZA== X-Gm-Message-State: AOAM532YewuVQ6Rc+qewhNrf36enMT8+V04/Zr6B6kD8DPLtU3YaAIZi XjYIUh+bAXronzeDX4eM6PG3iA== X-Google-Smtp-Source: ABdhPJyOBO/REx9/5akl0qhhv36/lbY4zOe7E6ml9gsHfHM+3Y+g+ekqNMpbhmJ6eAkOMcv3szY5HA== X-Received: by 2002:a17:90a:a58e:b0:1bd:4752:90cf with SMTP id b14-20020a17090aa58e00b001bd475290cfmr6216871pjq.54.1647371284298; Tue, 15 Mar 2022 12:08:04 -0700 (PDT) Received: from [192.168.0.4] (wsip-72-200-236-186.oc.oc.cox.net. [72.200.236.186]) by smtp.googlemail.com with ESMTPSA id k3-20020a056a00168300b004f7e60da26csm7790678pfc.182.2022.03.15.12.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 12:08:03 -0700 (PDT) Message-ID: <15ff0408-7b2f-c892-9239-ed923c835365@boundarydevices.com> Date: Tue, 15 Mar 2022 12:08:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v1 0/5] Move board specific files to board directory Content-Language: en-US To: Tom Rini Cc: Simon Glass , U-Boot Mailing List References: <20211217230131.2715940-1-troy.kisky@boundarydevices.com> <20211228131115.GZ2773246@bill-the-cat> <20220107151250.GK2773246@bill-the-cat> <20220208143016.GN7515@bill-the-cat> From: Troy Kisky In-Reply-To: <20220208143016.GN7515@bill-the-cat> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2/8/2022 6:30 AM, Tom Rini wrote: > On Fri, Jan 07, 2022 at 10:33:34AM -0800, Troy Kisky wrote: >> On 1/7/2022 7:12 AM, Tom Rini wrote: >>> On Thu, Jan 06, 2022 at 01:14:40PM -0800, Troy Kisky wrote: >>>> On 12/28/2021 5:11 AM, Tom Rini wrote: >>>>> On Tue, Dec 28, 2021 at 01:33:05AM -0700, Simon Glass wrote: >>>>>> Hi Troy, >>>>>> >>>>>> On Fri, 17 Dec 2021 at 16:02, Troy Kisky wrote: >>>>>>> >>>>>>> This series intends to let board specific files live in the boards >>>>>>> directory. The last patch moves files for nitrogen6x. >>>>>>> I have tested it with buildman >>>>>>> >>>>>>> ./tools/buildman/buildman boundary -b denx_master >>>>>>> >>>>>>> But it is likely the more scripts then just tools/genboardscfg.py would >>>>>>> need to be updated. >>>>>>> >>>>>>> Troy Kisky (5): >>>>>>> kconfig: allow defconfigs to live in board directory >>>>>>> dts: allow dts files in board directory >>>>>>> scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to live >>>>>>> in board directory >>>>>>> genboardcfg: allow defconfigs in board directory >>>>>>> nitrogen6x: move board specific files to nitrogen6x directory >>>>>>> >>>>>>> arch/arm/dts/Makefile | 3 -- >>>>>>> board/boundary/nitrogen6x/MAINTAINERS | 13 ------- >>>>>>> board/boundary/nitrogen6x/Makefile | 13 +++++++ >>>>>>> .../nitrogen6x}/imx6dl-nitrogen6x.dts | 0 >>>>>>> .../boundary/nitrogen6x}/imx6q-nitrogen6x.dts | 0 >>>>>>> .../boundary/nitrogen6x}/imx6q-sabrelite.dts | 0 >>>>>>> .../nitrogen6x}/imx6qdl-nitrogen6x.dtsi | 0 >>>>>>> .../nitrogen6x}/imx6qdl-sabrelite.dtsi | 0 >>>>>>> .../nitrogen6x}/mx6qsabrelite_defconfig | 0 >>>>>>> .../nitrogen6x}/nitrogen6dl2g_defconfig | 0 >>>>>>> .../nitrogen6x}/nitrogen6dl_defconfig | 0 >>>>>>> .../nitrogen6x}/nitrogen6q2g_defconfig | 0 >>>>>>> .../boundary/nitrogen6x}/nitrogen6q_defconfig | 0 >>>>>>> .../nitrogen6x}/nitrogen6s1g_defconfig | 0 >>>>>>> .../boundary/nitrogen6x}/nitrogen6s_defconfig | 0 >>>>>>> .../boundary/nitrogen6x}/nitrogen6x.h | 2 +- >>>>>>> dts/Makefile | 11 +++++- >>>>>>> scripts/Makefile.autoconf | 9 ++++- >>>>>>> scripts/Makefile.lib | 1 + >>>>>>> scripts/kconfig/Makefile | 9 ++++- >>>>>>> tools/genboardscfg.py | 37 ++++++++++++++++++- >>>>>>> 21 files changed, 75 insertions(+), 23 deletions(-) >>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6dl-nitrogen6x.dts (100%) >>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6q-nitrogen6x.dts (100%) >>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6q-sabrelite.dts (100%) >>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6qdl-nitrogen6x.dtsi (100%) >>>>>>> rename {arch/arm/dts => board/boundary/nitrogen6x}/imx6qdl-sabrelite.dtsi (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/mx6qsabrelite_defconfig (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6dl2g_defconfig (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6dl_defconfig (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6q2g_defconfig (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6q_defconfig (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6s1g_defconfig (100%) >>>>>>> rename {configs => board/boundary/nitrogen6x}/nitrogen6s_defconfig (100%) >>>>>>> rename {include/configs => board/boundary/nitrogen6x}/nitrogen6x.h (98%) I'm not about the goal. >>>>>> >>>>>> Can you please add a few notes about the motivation for this change? >>>>> >>>>> Sorry for the delayed reply here. I'm also not entirely sure this is a >>>>> good idea. Moving the defconfig files? Maybe. It does make checking >>>>> all configs a bit more tricky, but indeed the configs directory is >>>>> unwieldy. Moving the dts files? Those should be a direct cp from the >>>>> kernel, so that makes things less clear to me. Especially since it will >>>>> need other common files that will still be elsewhere. >>>>> >>>> >>>> They will still be a direct copy. Notice the 100% rename. Common files still living in the dts >>>> directory is less clear. I can try to address the "piecemeal building of .dts files" if this >>>> still has a chance of being accepted. >>> >>> So, here's my worry. Today, in an ideal world that we're not yet at, I >>> could do: >>> 1. cd ~/src/linux; git checkout v5.16 >>> 2. cd ~/src/u-boot; for DTS in arch/arm/dts/*.dts*; do \ >>> [ -f ~/src/linux/$DTS ] && cp ~/src/linux/$DTS $DTS; done Perhaps we can mimic Linux's arm/arm64 dts split and make the above work better? >>> >> >> Still, a script could easily check that a dts file exists before overwriting it >> and find the correct directory to put it in. A little more complicated, but not a lot. >> >> >>> And now we're resynced with v5.16. That gets a lot more complex with >>> board/*/*/*.dts* too. And since those files should be direct imports >>> I'm not sure how them residing in board/ helps. >> >> One thing that maybe be worth remembering, at one time, Linus was suggesting that dtb's would NOT be >> a permanent part of Linux. That has probably changed, but maybe eventually, that master repo will be >> vendor specific. >> >> >>> >>> But! I can see how having board-u-boot.dtsi exist under board/ might >>> help. Or at least, having those files reside somewhere that's NOT where >>> the unmodified imported dts files also live. Long term I think we need >>> to move towards making it easier to import the dts files, and clearer >>> that they should be "read only" other than when being resynced, than it >>> is today. >>> >> >> If you guys are OK with any of the patches, let me know, and I'll submit a restricted series. > > Again, sorry for the delay. I just don't think right now these file > moves are the right path forward. Maybe at some point further down the > road perhaps, once other cleanups are done and having > defconfig/u-boot.dtsi/etc in the board directory will be easier to > maintain long term. >