From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDA3BC43461 for ; Mon, 14 Sep 2020 14:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A59D20E65 for ; Mon, 14 Sep 2020 14:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IvfVSwBv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbgINOEP (ORCPT ); Mon, 14 Sep 2020 10:04:15 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:5478 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726537AbgINOCa (ORCPT ); Mon, 14 Sep 2020 10:02:30 -0400 X-UUID: a20d357e455d4bcb9f7b0afd4d2f3b0e-20200914 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=cLdj0X30p6O5aAOutE1K4/oxJCAmQzrpPvIelAe8dXw=; b=IvfVSwBvruvn11Wu7+kq5CSUIP1IVhSi/mjYCh7xR+v94CD55Tv6cY94A1hcrm4h4N7D55M0ZlzHBH2TZoVlnkOMFN8zfxMJqLkCM2D9C5ByWQpCaunamMrmdeFyFZGwSQq75EaoqRlpEzVdQvSZWOliNcUVi0NYC5pANZlZJDQ=; X-UUID: a20d357e455d4bcb9f7b0afd4d2f3b0e-20200914 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1162671277; Mon, 14 Sep 2020 22:02:22 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Sep 2020 22:02:20 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Sep 2020 22:02:20 +0800 Message-ID: <1600092019.14806.32.camel@mhfsdcap03> Subject: Re: [v4,3/4] reset-controller: ti: introduce a new reset handler From: Crystal Guo To: "robh+dt@kernel.org" CC: Suman Anna , Philipp Zabel , "matthias.bgg@gmail.com" , srv_heupstream , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Seiya Wang =?UTF-8?Q?=28=E7=8E=8B=E8=BF=BA=E5=90=9B=29?= , Stanley Chu =?UTF-8?Q?=28=E6=9C=B1=E5=8E=9F=E9=99=9E=29?= , Yingjoe Chen =?UTF-8?Q?=28=E9=99=B3=E8=8B=B1=E6=B4=B2=29?= , Fan Chen =?UTF-8?Q?=28=E9=99=B3=E5=87=A1=29?= , "Yong Liang =?UTF-8?Q?=28=E6=A2=81=E5=8B=87=29?=" Date: Mon, 14 Sep 2020 22:00:19 +0800 In-Reply-To: <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> References: <20200817030324.5690-1-crystal.guo@mediatek.com> <20200817030324.5690-4-crystal.guo@mediatek.com> <3a5decee-5f31-e27d-a120-1f835241a87c@ti.com> <1599620279.14806.18.camel@mhfsdcap03> <096362e9-dee8-4e7a-2518-47328068c2fd@ti.com> <1599792140.14806.22.camel@mhfsdcap03> <9d72aaef-49fe-ebb6-215d-05ad3ab27af4@ti.com> <1599804422.14806.27.camel@mhfsdcap03> <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 45A69AB5EB0307C47D3EE730CE03B37B6DC73E1E5FF7A7ED01BBCA588A5E68AB2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gRnJpLCAyMDIwLTA5LTExIGF0IDIyOjQ0ICswODAwLCBTdW1hbiBBbm5hIHdyb3RlOg0KPiBP biA5LzExLzIwIDk6MjYgQU0sIFBoaWxpcHAgWmFiZWwgd3JvdGU6DQo+ID4gSGkgQ3J5c3RhbCwN Cj4gPiANCj4gPiBPbiBGcmksIDIwMjAtMDktMTEgYXQgMTQ6MDcgKzA4MDAsIENyeXN0YWwgR3Vv IHdyb3RlOg0KPiA+IFsuLi5dDQo+ID4+IFNob3VsZCBJIGFkZCB0aGUgU29DLXNwZWNpZmljIGRh dGEgYXMgZm9sbG93cz8NCj4gPj4gVGhpcyBtYXkgYWxzbyBtb2RpZnkgdGhlIHRpIG9yaWdpbmFs IGNvZGUsIGlzIGl0IE9LPw0KPiA+Pg0KPiA+PiArICAgICAgIGRhdGEtPnJlc2V0X2RhdGEgPSBv Zl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoJnBkZXYtPmRldik7DQo+ID4+ICsNCj4gPj4gKyAgICAg ICBsaXN0ID0gb2ZfZ2V0X3Byb3BlcnR5KG5wLCBkYXRhLT5yZXNldF9kYXRhLT5yZXNldF9iaXRz LCAmc2l6ZSk7DQo+ID4+DQo+ID4+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGNvbW1vbl9yZXNldF9k YXRhIHRpX3Jlc2V0X2RhdGEgPSB7DQo+ID4+ICsgICAgICAgLnJlc2V0X29wX2F2YWlsYWJsZSA9 IGZhbHNlLA0KPiA+PiArICAgICAgIC5yZXNldF9iaXRzID0gInRpLCByZXNldC1iaXRzIiwNCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXg0KPiA+IFRoYXQgc3BhY2UgZG9lc24ndCBi ZWxvbmcgdGhlcmUuDQo+ID4gDQo+ID4+ICt9Ow0KPiA+PiArDQo+ID4+ICtzdGF0aWMgY29uc3Qg c3RydWN0IGNvbW1vbl9yZXNldF9kYXRhIG1lZGlhdGVrX3Jlc2V0X2RhdGEgPSB7DQo+ID4+ICsg ICAgICAgLnJlc2V0X29wX2F2YWlsYWJsZSA9IHRydWUsDQo+ID4+ICsgICAgICAgLnJlc2V0X2Jp dHMgPSAibWVkaWF0ZWssIHJlc2V0LWJpdHMiLA0KPiA+PiArfTsNCj4gPiANCj4gPiBJIHVuZGVy c3RhbmQgUm9icyBjb21tZW50cyBhcyBtZWFuaW5nICJ0aSxyZXNldC1iaXRzIiBzaG91bGQgaGF2 ZSBiZWVuDQo+ID4gY2FsbGVkICJyZXNldC1iaXRzIiBpbiB0aGUgZmlyc3QgcGxhY2UsIGFuZCB5 b3Ugc2hvdWxkbid0IHJlcGVhdCBhZGRpbmcNCj4gPiB0aGUgdmVuZG9yIHByZWZpeCwgYXMgdGhh dCBpcyBpbXBsaWVkIGJ5IHRoZSBjb21wYXRpYmxlLiBTbyB0aGlzIHNob3VsZA0KPiA+IHByb2Jh Ymx5IGJlIGp1c3QgInJlc2V0LWJpdHMiLg0KPiANCj4gSG1tLCBub3Qgc3VyZSBhYm91dCB0aGF0 LiBJIHRoaW5rIFJvYiB3YW50cyB0aGUgcmVzZXQgZGF0YSBpdHNlbGYgdG8gYmUgYWRkZWQgaW4N Cj4gdGhlIGRyaXZlciBhcyBpcyBiZWluZyBkb25lIG9uIHNvbWUgb3RoZXIgU29DcyAoZWc6IGxp a2UgaW4gcmVzZXQtcWNvbS1wZGMuYykuDQo+IA0KPiByZWdhcmRzDQo+IFN1bWFuDQo+IA0KSGkg Um9iLA0KDQpDYW4geW91IGhlbHAgdG8gY29tbWVudCBhYm91dCB0aGlzIHBvaW50Pw0KTW9kaWZ5 ICJ0aSxyZXNldC1iaXRzIiB0byAicmVzZXQtYml0cyIgb3IgYWRkICJtZWRpYXRlayxyZXNldC1i aXRzIiA/DQoNCk1hbnkgdGhhbmtzfg0KQ3J5c3RhbA0KDQo+ID4gDQo+ID4gT3RoZXJ3aXNlIHRo aXMgbG9va3MgbGlrZSBpdCBzaG91bGQgd29yay4NCj4gPiANCj4gPiByZWdhcmRzDQo+ID4gUGhp bGlwcA0KPiA+IA0KPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5546C433E2 for ; Mon, 14 Sep 2020 14:06:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3DFA2074B for ; Mon, 14 Sep 2020 14:06:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GIuVEkbL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IvfVSwBv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3DFA2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nwDYs8L9Q/qm4a4Yy02H8Qd3M9Tm8V8CCV5AI5ZYXwg=; b=GIuVEkbLxje2jIHV/kzIpNFr+ uJZn6yBTNj5VRWwWCl200nBpvz3DikPFrR5BYbYqMiJ84eJH05Bk+5MCFaaWjKHCgcTPFOu4VDHM7 16rXrKadp7RTHptK+jJUj7JZeqBX8LkKY/lfbgJAnXthy8RN9PkZkMTIcrFgGjILpvmybT3zWJ6Er YawkEsg6ePPqQtG5y/7sUlX5PoTwB3bNX5YSEfQDAHdPoYawWrO7ugdg2JFd9pnM4Gk/aNa6G+rQk 1bF8oVKOLRLWXoDjEqaISmtcXx6vBSt66L+E/4VrxNaQ2iRF9E/9tIr7HpyOySOEz+cbgKLU4+Xhr b/PcjjDRQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHp7G-0004Vh-Bi; Mon, 14 Sep 2020 14:05:58 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHp7A-0004TF-Ss; Mon, 14 Sep 2020 14:05:54 +0000 X-UUID: 71135805e5e44d8fb0d6fa65273d0471-20200914 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=cLdj0X30p6O5aAOutE1K4/oxJCAmQzrpPvIelAe8dXw=; b=IvfVSwBvruvn11Wu7+kq5CSUIP1IVhSi/mjYCh7xR+v94CD55Tv6cY94A1hcrm4h4N7D55M0ZlzHBH2TZoVlnkOMFN8zfxMJqLkCM2D9C5ByWQpCaunamMrmdeFyFZGwSQq75EaoqRlpEzVdQvSZWOliNcUVi0NYC5pANZlZJDQ=; X-UUID: 71135805e5e44d8fb0d6fa65273d0471-20200914 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1440615605; Mon, 14 Sep 2020 06:02:27 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Sep 2020 07:02:25 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Sep 2020 22:02:20 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Sep 2020 22:02:20 +0800 Message-ID: <1600092019.14806.32.camel@mhfsdcap03> Subject: Re: [v4,3/4] reset-controller: ti: introduce a new reset handler From: Crystal Guo To: "robh+dt@kernel.org" Date: Mon, 14 Sep 2020 22:00:19 +0800 In-Reply-To: <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> References: <20200817030324.5690-1-crystal.guo@mediatek.com> <20200817030324.5690-4-crystal.guo@mediatek.com> <3a5decee-5f31-e27d-a120-1f835241a87c@ti.com> <1599620279.14806.18.camel@mhfsdcap03> <096362e9-dee8-4e7a-2518-47328068c2fd@ti.com> <1599792140.14806.22.camel@mhfsdcap03> <9d72aaef-49fe-ebb6-215d-05ad3ab27af4@ti.com> <1599804422.14806.27.camel@mhfsdcap03> <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 45A69AB5EB0307C47D3EE730CE03B37B6DC73E1E5FF7A7ED01BBCA588A5E68AB2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_100553_070726_BFA032B1 X-CRM114-Status: GOOD ( 20.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Yong Liang =?UTF-8?Q?=28=E6=A2=81=E5=8B=87=29?= , Stanley Chu =?UTF-8?Q?=28=E6=9C=B1=E5=8E=9F=E9=99=9E=29?= , srv_heupstream , Seiya Wang =?UTF-8?Q?=28=E7=8E=8B=E8=BF=BA=E5=90=9B=29?= , "linux-kernel@vger.kernel.org" , Fan Chen =?UTF-8?Q?=28=E9=99=B3=E5=87=A1=29?= , "linux-mediatek@lists.infradead.org" , Philipp Zabel , "matthias.bgg@gmail.com" , Yingjoe Chen =?UTF-8?Q?=28=E9=99=B3=E8=8B=B1=E6=B4=B2=29?= , Suman Anna , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2020-09-11 at 22:44 +0800, Suman Anna wrote: > On 9/11/20 9:26 AM, Philipp Zabel wrote: > > Hi Crystal, > > > > On Fri, 2020-09-11 at 14:07 +0800, Crystal Guo wrote: > > [...] > >> Should I add the SoC-specific data as follows? > >> This may also modify the ti original code, is it OK? > >> > >> + data->reset_data = of_device_get_match_data(&pdev->dev); > >> + > >> + list = of_get_property(np, data->reset_data->reset_bits, &size); > >> > >> +static const struct common_reset_data ti_reset_data = { > >> + .reset_op_available = false, > >> + .reset_bits = "ti, reset-bits", > > ^ > > That space doesn't belong there. > > > >> +}; > >> + > >> +static const struct common_reset_data mediatek_reset_data = { > >> + .reset_op_available = true, > >> + .reset_bits = "mediatek, reset-bits", > >> +}; > > > > I understand Robs comments as meaning "ti,reset-bits" should have been > > called "reset-bits" in the first place, and you shouldn't repeat adding > > the vendor prefix, as that is implied by the compatible. So this should > > probably be just "reset-bits". > > Hmm, not sure about that. I think Rob wants the reset data itself to be added in > the driver as is being done on some other SoCs (eg: like in reset-qcom-pdc.c). > > regards > Suman > Hi Rob, Can you help to comment about this point? Modify "ti,reset-bits" to "reset-bits" or add "mediatek,reset-bits" ? Many thanks~ Crystal > > > > Otherwise this looks like it should work. > > > > regards > > Philipp > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9889C433E2 for ; Mon, 14 Sep 2020 14:07:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70C032074B for ; Mon, 14 Sep 2020 14:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X3hfKBHZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IvfVSwBv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70C032074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0g1P4R+kFtqjutNrjtslVsgXToPpH/aIDhylo8wykyE=; b=X3hfKBHZXVuu8DYNP+o88LVxk Ngwtu3lNlqclJR6T+JPnXyCxQyMxBk8dvpNr5yKzI3qxrN8dNb17Zx6r6T/PDFjzGWL87Bd4n9Hze TbKqy9Hmn/TNrU7R42r/Vjo7GKrb+PENgz9tSpskHwwN8KQPeKkkFBhRDEo58gfE1gxiXvYn0+zJi a2EDzFiV/knF8wgQk4l/WgiQWHAO6v8d0U5ou7wZkOb5DtT62hoVWIvizglP2Lvid0DCFx5/LOMDs hIyqEqSi2An6vUyha8+G/NvWMj7o5DNwysxCjBscwapHdN2pUWoBOLUt5YMQ+So5Hdr6ofrG3Ul7T rurIxY+zA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHp7E-0004VH-Kl; Mon, 14 Sep 2020 14:05:56 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHp7A-0004TF-Ss; Mon, 14 Sep 2020 14:05:54 +0000 X-UUID: 71135805e5e44d8fb0d6fa65273d0471-20200914 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=cLdj0X30p6O5aAOutE1K4/oxJCAmQzrpPvIelAe8dXw=; b=IvfVSwBvruvn11Wu7+kq5CSUIP1IVhSi/mjYCh7xR+v94CD55Tv6cY94A1hcrm4h4N7D55M0ZlzHBH2TZoVlnkOMFN8zfxMJqLkCM2D9C5ByWQpCaunamMrmdeFyFZGwSQq75EaoqRlpEzVdQvSZWOliNcUVi0NYC5pANZlZJDQ=; X-UUID: 71135805e5e44d8fb0d6fa65273d0471-20200914 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1440615605; Mon, 14 Sep 2020 06:02:27 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Sep 2020 07:02:25 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Sep 2020 22:02:20 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 14 Sep 2020 22:02:20 +0800 Message-ID: <1600092019.14806.32.camel@mhfsdcap03> Subject: Re: [v4,3/4] reset-controller: ti: introduce a new reset handler From: Crystal Guo To: "robh+dt@kernel.org" Date: Mon, 14 Sep 2020 22:00:19 +0800 In-Reply-To: <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> References: <20200817030324.5690-1-crystal.guo@mediatek.com> <20200817030324.5690-4-crystal.guo@mediatek.com> <3a5decee-5f31-e27d-a120-1f835241a87c@ti.com> <1599620279.14806.18.camel@mhfsdcap03> <096362e9-dee8-4e7a-2518-47328068c2fd@ti.com> <1599792140.14806.22.camel@mhfsdcap03> <9d72aaef-49fe-ebb6-215d-05ad3ab27af4@ti.com> <1599804422.14806.27.camel@mhfsdcap03> <407863ba-e336-11fc-297d-f1be1f58adaa@ti.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 45A69AB5EB0307C47D3EE730CE03B37B6DC73E1E5FF7A7ED01BBCA588A5E68AB2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_100553_070726_BFA032B1 X-CRM114-Status: GOOD ( 20.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Yong Liang =?UTF-8?Q?=28=E6=A2=81=E5=8B=87=29?= , Stanley Chu =?UTF-8?Q?=28=E6=9C=B1=E5=8E=9F=E9=99=9E=29?= , srv_heupstream , Seiya Wang =?UTF-8?Q?=28=E7=8E=8B=E8=BF=BA=E5=90=9B=29?= , "linux-kernel@vger.kernel.org" , Fan Chen =?UTF-8?Q?=28=E9=99=B3=E5=87=A1=29?= , "linux-mediatek@lists.infradead.org" , Philipp Zabel , "matthias.bgg@gmail.com" , Yingjoe Chen =?UTF-8?Q?=28=E9=99=B3=E8=8B=B1=E6=B4=B2=29?= , Suman Anna , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2020-09-11 at 22:44 +0800, Suman Anna wrote: > On 9/11/20 9:26 AM, Philipp Zabel wrote: > > Hi Crystal, > > > > On Fri, 2020-09-11 at 14:07 +0800, Crystal Guo wrote: > > [...] > >> Should I add the SoC-specific data as follows? > >> This may also modify the ti original code, is it OK? > >> > >> + data->reset_data = of_device_get_match_data(&pdev->dev); > >> + > >> + list = of_get_property(np, data->reset_data->reset_bits, &size); > >> > >> +static const struct common_reset_data ti_reset_data = { > >> + .reset_op_available = false, > >> + .reset_bits = "ti, reset-bits", > > ^ > > That space doesn't belong there. > > > >> +}; > >> + > >> +static const struct common_reset_data mediatek_reset_data = { > >> + .reset_op_available = true, > >> + .reset_bits = "mediatek, reset-bits", > >> +}; > > > > I understand Robs comments as meaning "ti,reset-bits" should have been > > called "reset-bits" in the first place, and you shouldn't repeat adding > > the vendor prefix, as that is implied by the compatible. So this should > > probably be just "reset-bits". > > Hmm, not sure about that. I think Rob wants the reset data itself to be added in > the driver as is being done on some other SoCs (eg: like in reset-qcom-pdc.c). > > regards > Suman > Hi Rob, Can you help to comment about this point? Modify "ti,reset-bits" to "reset-bits" or add "mediatek,reset-bits" ? Many thanks~ Crystal > > > > Otherwise this looks like it should work. > > > > regards > > Philipp > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel