From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF96C10DCE for ; Fri, 13 Mar 2020 01:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F9BE20716 for ; Fri, 13 Mar 2020 01:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726390AbgCMBzm (ORCPT ); Thu, 12 Mar 2020 21:55:42 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:60566 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726194AbgCMBzm (ORCPT ); Thu, 12 Mar 2020 21:55:42 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3CC268047441D80DBB2B; Fri, 13 Mar 2020 09:55:38 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Fri, 13 Mar 2020 09:55:31 +0800 Subject: Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests To: Auger Eric CC: Marc Zyngier , , , , , , , , , , References: <20200310145410.26308-1-eric.auger@redhat.com> <20200310145410.26308-11-eric.auger@redhat.com> <46f0ed1d-3bda-f91b-e2b0-addf1c61c373@redhat.com> <301a8b402ff7e480e927b0f8f8b093f2@kernel.org> <7fb9f81f-6520-526d-7031-d3d08cb1dd6a@huawei.com> From: Zenghui Yu Message-ID: <160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com> Date: Fri, 13 Mar 2020 09:55:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Eric, On 2020/3/12 17:59, Auger Eric wrote: > Hi Zenghui, > > On 3/12/20 10:19 AM, Zenghui Yu wrote: >> On 2020/3/11 22:00, Marc Zyngier wrote: >>> That is still a problem with the ITS. There is no architectural way >>> to report an error, even if the error numbers are architected... >>> >>> One thing we could do though is to implement the stall model (as >>> described >>> in 5.3.2). It still doesn't give us the error, but at least the command >>> queue would stop on detecting an error. >> >> It would be interesting to see the buggy guest's behavior under the >> stall mode. I've used the following diff (absolutely *not* a formal >> patch, don't handle CREADR.Stalled and CWRITER.Retry at all) to have >> a try, and caught another command error in the 'its-trigger' test. >> >> logs/its-trigger.log: >> " INT dev_id=2 event_id=20 >> lib/arm64/gic-v3-its-cmd.c:194: assert failed: false: INT timeout! " >> >> dmesg: >> [13297.711958] ------------[ cut here ]------------ >> [13297.711964] ITS command error encoding 0x10307 >> >> It's the last INT test in test_its_trigger() who has triggered this >> error, Eric? > > Yes it may be the culprit. Anyway I removed the collection unmap in v6. I forgot to mention that this is based on your v6. I'll reply to it. > > By the way are you OK now with v6? I think Drew plans to send a pull > request by the end of this week. Sorry I haven't looked at it yet (v5 already looks good except for some minor issues). Thanks, Zenghui From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC941C10DCE for ; Fri, 13 Mar 2020 01:56:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AC76206EB for ; Fri, 13 Mar 2020 01:56:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AC76206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52708 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCZYw-0000JG-SF for qemu-devel@archiver.kernel.org; Thu, 12 Mar 2020 21:56:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54705) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCZYG-0008F1-4t for qemu-devel@nongnu.org; Thu, 12 Mar 2020 21:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCZYF-0003wF-4B for qemu-devel@nongnu.org; Thu, 12 Mar 2020 21:55:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:39564 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCZYB-0003cq-HU; Thu, 12 Mar 2020 21:55:47 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3CC268047441D80DBB2B; Fri, 13 Mar 2020 09:55:38 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Fri, 13 Mar 2020 09:55:31 +0800 Subject: Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests To: Auger Eric References: <20200310145410.26308-1-eric.auger@redhat.com> <20200310145410.26308-11-eric.auger@redhat.com> <46f0ed1d-3bda-f91b-e2b0-addf1c61c373@redhat.com> <301a8b402ff7e480e927b0f8f8b093f2@kernel.org> <7fb9f81f-6520-526d-7031-d3d08cb1dd6a@huawei.com> From: Zenghui Yu Message-ID: <160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com> Date: Fri, 13 Mar 2020 09:55:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, kvm@vger.kernel.org, Marc Zyngier , qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, thuth@redhat.com, alexandru.elisei@arm.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Eric, On 2020/3/12 17:59, Auger Eric wrote: > Hi Zenghui, > > On 3/12/20 10:19 AM, Zenghui Yu wrote: >> On 2020/3/11 22:00, Marc Zyngier wrote: >>> That is still a problem with the ITS. There is no architectural way >>> to report an error, even if the error numbers are architected... >>> >>> One thing we could do though is to implement the stall model (as >>> described >>> in 5.3.2). It still doesn't give us the error, but at least the command >>> queue would stop on detecting an error. >> >> It would be interesting to see the buggy guest's behavior under the >> stall mode. I've used the following diff (absolutely *not* a formal >> patch, don't handle CREADR.Stalled and CWRITER.Retry at all) to have >> a try, and caught another command error in the 'its-trigger' test. >> >> logs/its-trigger.log: >> " INT dev_id=2 event_id=20 >> lib/arm64/gic-v3-its-cmd.c:194: assert failed: false: INT timeout! " >> >> dmesg: >> [13297.711958] ------------[ cut here ]------------ >> [13297.711964] ITS command error encoding 0x10307 >> >> It's the last INT test in test_its_trigger() who has triggered this >> error, Eric? > > Yes it may be the culprit. Anyway I removed the collection unmap in v6. I forgot to mention that this is based on your v6. I'll reply to it. > > By the way are you OK now with v6? I think Drew plans to send a pull > request by the end of this week. Sorry I haven't looked at it yet (v5 already looks good except for some minor issues). Thanks, Zenghui From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB56C1975A for ; Fri, 13 Mar 2020 01:55:47 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 270EF206EB for ; Fri, 13 Mar 2020 01:55:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 270EF206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8218F4AEEF; Thu, 12 Mar 2020 21:55:46 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PAdiSh+k0wFp; Thu, 12 Mar 2020 21:55:45 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 73A2E4A5A3; Thu, 12 Mar 2020 21:55:45 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1EF514A5A3 for ; Thu, 12 Mar 2020 21:55:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id btDk8WnG1TVm for ; Thu, 12 Mar 2020 21:55:42 -0400 (EDT) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id A29594A51F for ; Thu, 12 Mar 2020 21:55:42 -0400 (EDT) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3CC268047441D80DBB2B; Fri, 13 Mar 2020 09:55:38 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Fri, 13 Mar 2020 09:55:31 +0800 Subject: Re: [kvm-unit-tests PATCH v5 10/13] arm/arm64: ITS: INT functional tests To: Auger Eric References: <20200310145410.26308-1-eric.auger@redhat.com> <20200310145410.26308-11-eric.auger@redhat.com> <46f0ed1d-3bda-f91b-e2b0-addf1c61c373@redhat.com> <301a8b402ff7e480e927b0f8f8b093f2@kernel.org> <7fb9f81f-6520-526d-7031-d3d08cb1dd6a@huawei.com> From: Zenghui Yu Message-ID: <160015aa-f5d7-2fdc-8d06-1322af241896@huawei.com> Date: Fri, 13 Mar 2020 09:55:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Cc: kvm@vger.kernel.org, Marc Zyngier , qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, thuth@redhat.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Eric, On 2020/3/12 17:59, Auger Eric wrote: > Hi Zenghui, > > On 3/12/20 10:19 AM, Zenghui Yu wrote: >> On 2020/3/11 22:00, Marc Zyngier wrote: >>> That is still a problem with the ITS. There is no architectural way >>> to report an error, even if the error numbers are architected... >>> >>> One thing we could do though is to implement the stall model (as >>> described >>> in 5.3.2). It still doesn't give us the error, but at least the command >>> queue would stop on detecting an error. >> >> It would be interesting to see the buggy guest's behavior under the >> stall mode. I've used the following diff (absolutely *not* a formal >> patch, don't handle CREADR.Stalled and CWRITER.Retry at all) to have >> a try, and caught another command error in the 'its-trigger' test. >> >> logs/its-trigger.log: >> " INT dev_id=2 event_id=20 >> lib/arm64/gic-v3-its-cmd.c:194: assert failed: false: INT timeout! " >> >> dmesg: >> [13297.711958] ------------[ cut here ]------------ >> [13297.711964] ITS command error encoding 0x10307 >> >> It's the last INT test in test_its_trigger() who has triggered this >> error, Eric? > > Yes it may be the culprit. Anyway I removed the collection unmap in v6. I forgot to mention that this is based on your v6. I'll reply to it. > > By the way are you OK now with v6? I think Drew plans to send a pull > request by the end of this week. Sorry I haven't looked at it yet (v5 already looks good except for some minor issues). Thanks, Zenghui _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm