All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 1895703] [NEW] performance degradation in tcg since Meson switch
@ 2020-09-15 16:50 Philippe Mathieu-Daudé
  2020-09-16 11:11 ` [Bug 1895703] " Paolo Bonzini
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-15 16:50 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
introduced a degradation in performance in some TCG targets:

--------------------------------------------------------
Test Program: matmult_double
--------------------------------------------------------
Target              Instructions     Previous    Latest
                                     1d806cef   7fd51e68
----------  --------------------  ----------  ----------
alpha              3 233 957 639       -----     +7.472%
m68k               3 919 110 506       -----    +18.433%
--------------------------------------------------------

Original report from Ahmed Karaman with further testing done
by Aleksandar Markovic:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

** Affects: qemu
     Importance: Undecided
         Status: New


** Tags: buildsys tcg

** Tags added: buildsys tcg

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
@ 2020-09-16 11:11 ` Paolo Bonzini
  2020-09-17 17:50 ` Ahmed Karaman
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2020-09-16 11:11 UTC (permalink / raw)
  To: qemu-devel

Can I get a sample statically linked m68k binary that exhibits this
effect?

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
  2020-09-16 11:11 ` [Bug 1895703] " Paolo Bonzini
@ 2020-09-17 17:50 ` Ahmed Karaman
  2020-09-18 15:38 ` Paolo Bonzini
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Ahmed Karaman @ 2020-09-17 17:50 UTC (permalink / raw)
  To: qemu-devel

** Attachment added: "matmult_double-m68k"
   https://bugs.launchpad.net/qemu/+bug/1895703/+attachment/5411765/+files/matmult_double-m68k

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
  2020-09-16 11:11 ` [Bug 1895703] " Paolo Bonzini
  2020-09-17 17:50 ` Ahmed Karaman
@ 2020-09-18 15:38 ` Paolo Bonzini
  2020-09-18 16:02 ` Peter Maydell
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2020-09-18 15:38 UTC (permalink / raw)
  To: qemu-devel

I get

$ qemu-m68k ./matmult_double-m68k
Error while loading /home/pbonzini/matmult_double-m68k: Permission denied

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
                   ` (2 preceding siblings ...)
  2020-09-18 15:38 ` Paolo Bonzini
@ 2020-09-18 16:02 ` Peter Maydell
  2020-09-18 17:07 ` Paolo Bonzini
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Peter Maydell @ 2020-09-18 16:02 UTC (permalink / raw)
  To: qemu-devel

Paolo: what are the permissions on matmult_double-m68k on your local fs?
(needs to be readable/executable by you)

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
                   ` (3 preceding siblings ...)
  2020-09-18 16:02 ` Peter Maydell
@ 2020-09-18 17:07 ` Paolo Bonzini
  2020-09-18 23:16 ` Paolo Bonzini
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2020-09-18 17:07 UTC (permalink / raw)
  To: qemu-devel

Uff, of course...

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
                   ` (4 preceding siblings ...)
  2020-09-18 17:07 ` Paolo Bonzini
@ 2020-09-18 23:16 ` Paolo Bonzini
  2020-11-21 23:44 ` Peter Maydell
  2020-12-10  9:16 ` Thomas Huth
  7 siblings, 0 replies; 9+ messages in thread
From: Paolo Bonzini @ 2020-09-18 23:16 UTC (permalink / raw)
  To: qemu-devel

This patch shold fix the regression:

diff --git a/configure b/configure
index 0004c46525..0786144043 100755
--- a/configure
+++ b/configure
@@ -7414,6 +7414,7 @@ NINJA=${ninja:-$PWD/ninjatool} $meson setup \
         -Dwerror=$(if test "$werror" = yes; then echo true; else echo false; fi) \
         -Dstrip=$(if test "$strip_opt" = yes; then echo true; else echo false; fi) \
         -Db_pie=$(if test "$pie" = yes; then echo true; else echo false; fi) \
+        -Db_staticpic=$(if test "$pie" = yes; then echo true; else echo false; fi) \
         -Db_coverage=$(if test "$gcov" = yes; then echo true; else echo false; fi) \
 	-Dmalloc=$malloc -Dmalloc_trim=$malloc_trim -Dsparse=$sparse \
 	-Dkvm=$kvm -Dhax=$hax -Dwhpx=$whpx -Dhvf=$hvf \

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  New

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
                   ` (5 preceding siblings ...)
  2020-09-18 23:16 ` Paolo Bonzini
@ 2020-11-21 23:44 ` Peter Maydell
  2020-12-10  9:16 ` Thomas Huth
  7 siblings, 0 replies; 9+ messages in thread
From: Peter Maydell @ 2020-11-21 23:44 UTC (permalink / raw)
  To: qemu-devel

This was fixed initially by commit 0c3dd50eaecbfe2, which is the change
suggested in Paolo's comment #6, and then refined by commit
a5cb7c5afe717d4.


** Changed in: qemu
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  Fix Committed

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug 1895703] Re: performance degradation in tcg since Meson switch
  2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
                   ` (6 preceding siblings ...)
  2020-11-21 23:44 ` Peter Maydell
@ 2020-12-10  9:16 ` Thomas Huth
  7 siblings, 0 replies; 9+ messages in thread
From: Thomas Huth @ 2020-12-10  9:16 UTC (permalink / raw)
  To: qemu-devel

Released with QEMU v5.2.0.

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1895703

Title:
  performance degradation in tcg since Meson switch

Status in QEMU:
  Fix Released

Bug description:
  The buildsys conversion to Meson (1d806cef0e3..7fd51e68c34)
  introduced a degradation in performance in some TCG targets:

  --------------------------------------------------------
  Test Program: matmult_double
  --------------------------------------------------------
  Target              Instructions     Previous    Latest
                                       1d806cef   7fd51e68
  ----------  --------------------  ----------  ----------
  alpha              3 233 957 639       -----     +7.472%
  m68k               3 919 110 506       -----    +18.433%
  --------------------------------------------------------

  Original report from Ahmed Karaman with further testing done
  by Aleksandar Markovic:
  https://www.mail-archive.com/qemu-devel@nongnu.org/msg740279.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1895703/+subscriptions


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-12-10  9:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 16:50 [Bug 1895703] [NEW] performance degradation in tcg since Meson switch Philippe Mathieu-Daudé
2020-09-16 11:11 ` [Bug 1895703] " Paolo Bonzini
2020-09-17 17:50 ` Ahmed Karaman
2020-09-18 15:38 ` Paolo Bonzini
2020-09-18 16:02 ` Peter Maydell
2020-09-18 17:07 ` Paolo Bonzini
2020-09-18 23:16 ` Paolo Bonzini
2020-11-21 23:44 ` Peter Maydell
2020-12-10  9:16 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.