All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot2 for Jiafei Pan" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Jiafei Pan <Jiafei.Pan@nxp.com>,
	Thomas Gleixner <tglx@linutronix.de>, x86 <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [tip: irq/core] softirq: Add debug check to __raise_softirq_irqoff()
Date: Wed, 16 Sep 2020 13:21:59 -0000	[thread overview]
Message-ID: <160026251907.15536.10650431255857233346.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200814045522.45719-1-Jiafei.Pan@nxp.com>

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     cdabce2e3dff7e4bcef73473987618569d178af3
Gitweb:        https://git.kernel.org/tip/cdabce2e3dff7e4bcef73473987618569d178af3
Author:        Jiafei Pan <Jiafei.Pan@nxp.com>
AuthorDate:    Fri, 14 Aug 2020 12:55:22 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 16 Sep 2020 15:18:56 +02:00

softirq: Add debug check to __raise_softirq_irqoff()

__raise_softirq_irqoff() must be called with interrupts disabled to protect
the per CPU softirq pending state update against an interrupt and soft
interrupt handling on return from interrupt.

Add a lockdep assertion to validate the calling convention.

[ tglx: Massaged changelog ]

Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20200814045522.45719-1-Jiafei.Pan@nxp.com

---
 kernel/softirq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index bf88d7f..09229ad 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -481,6 +481,7 @@ void raise_softirq(unsigned int nr)
 
 void __raise_softirq_irqoff(unsigned int nr)
 {
+	lockdep_assert_irqs_disabled();
 	trace_softirq_raise(nr);
 	or_softirq_pending(1UL << nr);
 }

      parent reply	other threads:[~2020-09-16 18:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14  4:55 [PATCH v2] softirq: add irq off checking for __raise_softirq_irqoff Jiafei Pan
2020-09-10  2:30 ` Jiafei Pan
2020-09-16 13:21 ` tip-bot2 for Jiafei Pan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160026251907.15536.10650431255857233346.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=Jiafei.Pan@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.