All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: <linux-acpi@vger.kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Hanjun Guo <guohanjun@huawei.com>
Subject: [PATCH RFC 24/25] ACPI: sysfs: Remove the dead debug interfaces
Date: Thu, 17 Sep 2020 15:39:04 +0800	[thread overview]
Message-ID: <1600328345-27627-25-git-send-email-guohanjun@huawei.com> (raw)
In-Reply-To: <1600328345-27627-1-git-send-email-guohanjun@huawei.com>

After the cleanup of the ACPICA debug functionality, some of the
ACPICA debug interfaces for ACPI drivers are not unsed anymore,
remove those interfaces.

While we are at it, update the wrong kernel doc as well.

Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
 drivers/acpi/sysfs.c        | 18 +++++++-----------
 include/acpi/acpi_drivers.h |  8 ++------
 2 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
index a5cc4f3..4237256 100644
--- a/drivers/acpi/sysfs.c
+++ b/drivers/acpi/sysfs.c
@@ -18,12 +18,12 @@
 #ifdef CONFIG_ACPI_DEBUG
 /*
  * ACPI debug sysfs I/F, including:
- * /sys/modules/acpi/parameters/debug_layer
- * /sys/modules/acpi/parameters/debug_level
- * /sys/modules/acpi/parameters/trace_method_name
- * /sys/modules/acpi/parameters/trace_state
- * /sys/modules/acpi/parameters/trace_debug_layer
- * /sys/modules/acpi/parameters/trace_debug_level
+ * /sys/module/acpi/parameters/debug_layer
+ * /sys/module/acpi/parameters/debug_level
+ * /sys/module/acpi/parameters/trace_method_name
+ * /sys/module/acpi/parameters/trace_state
+ * /sys/module/acpi/parameters/trace_debug_layer
+ * /sys/module/acpi/parameters/trace_debug_level
  */
 
 struct acpi_dlayer {
@@ -56,14 +56,10 @@ struct acpi_dlevel {
 	ACPI_DEBUG_INIT(ACPI_AC_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_BATTERY_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_BUTTON_COMPONENT),
-	ACPI_DEBUG_INIT(ACPI_SBS_COMPONENT),
-	ACPI_DEBUG_INIT(ACPI_FAN_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_PCI_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_POWER_COMPONENT),
-	ACPI_DEBUG_INIT(ACPI_CONTAINER_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_SYSTEM_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_THERMAL_COMPONENT),
-	ACPI_DEBUG_INIT(ACPI_MEMORY_DEVICE_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_VIDEO_COMPONENT),
 	ACPI_DEBUG_INIT(ACPI_PROCESSOR_COMPONENT),
 };
@@ -289,7 +285,7 @@ static int param_get_trace_state(char *buffer, const struct kernel_param *kp)
 #endif /* CONFIG_ACPI_DEBUG */
 
 
-/* /sys/modules/acpi/parameters/aml_debug_output */
+/* /sys/module/acpi/parameters/aml_debug_output */
 
 module_param_named(aml_debug_output, acpi_gbl_enable_aml_debug_object,
 		   byte, 0644);
diff --git a/include/acpi/acpi_drivers.h b/include/acpi/acpi_drivers.h
index 5eb1759..614d0a9 100644
--- a/include/acpi/acpi_drivers.h
+++ b/include/acpi/acpi_drivers.h
@@ -12,21 +12,17 @@
 #define ACPI_MAX_STRING			80
 
 /*
- * Please update drivers/acpi/debug.c and Documentation/firmware-guide/acpi/debug.rst
- * if you add to this list.
+ * Please update drivers/acpi/sysfs.c and Documentation/firmware-guide/acpi/debug.rst
+ * if you add to or remove from this list.
  */
 #define ACPI_BUS_COMPONENT		0x00010000
 #define ACPI_AC_COMPONENT		0x00020000
 #define ACPI_BATTERY_COMPONENT		0x00040000
 #define ACPI_BUTTON_COMPONENT		0x00080000
-#define ACPI_SBS_COMPONENT		0x00100000
-#define ACPI_FAN_COMPONENT		0x00200000
 #define ACPI_PCI_COMPONENT		0x00400000
 #define ACPI_POWER_COMPONENT		0x00800000
-#define ACPI_CONTAINER_COMPONENT	0x01000000
 #define ACPI_SYSTEM_COMPONENT		0x02000000
 #define ACPI_THERMAL_COMPONENT		0x04000000
-#define ACPI_MEMORY_DEVICE_COMPONENT	0x08000000
 #define ACPI_VIDEO_COMPONENT		0x10000000
 #define ACPI_PROCESSOR_COMPONENT	0x20000000
 
-- 
1.7.12.4


  parent reply	other threads:[~2020-09-17  8:34 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  7:38 [PATCH 00/25] ACPI: First step to decouple ACPICA debug functionality from ACPI driver Hanjun Guo
2020-09-17  7:38 ` [PATCH 01/25] ACPI: cmos_rtc: Remove the ACPI_MODULE_NAME() Hanjun Guo
2020-09-17  7:38 ` [PATCH 02/25] ACPI: configfs: Decouple with ACPICA Hanjun Guo
2020-09-17  7:38 ` [PATCH 03/25] ACPI: configfs: Add the missing config_item_put() Hanjun Guo
2020-09-17  7:38 ` [PATCH 04/25] ACPI: debug: Remove the not used function Hanjun Guo
2020-09-17  7:38 ` [PATCH 05/25] ACPI: LPSS: Remove the ACPI_MODULE_NAME() Hanjun Guo
2020-09-17  7:38 ` [PATCH 06/25] ACPI: memhotplug: Remove the leftover ACPICA debug functionality Hanjun Guo
2020-09-17  7:38 ` [PATCH 07/25] ACPI: memhotplug: Remove the state for memory device Hanjun Guo
2020-09-17  7:38 ` [PATCH 08/25] ACPI: platform: Remove the leftover ACPICA debug functinality Hanjun Guo
2020-09-17  7:38 ` [PATCH 09/25] ACPI: container: Remove the leftover ACPICA debug functionality Hanjun Guo
2020-09-17  7:38 ` [PATCH 10/25] ACPI: custom_method: Remove the ACPICA debug code Hanjun Guo
2020-09-17  7:38 ` [PATCH 11/25] ACPI: debugfs: " Hanjun Guo
2020-09-17  7:38 ` [PATCH 12/25] ACPI: dock: " Hanjun Guo
2020-09-17  7:38 ` [PATCH 13/25] ACPI: event: " Hanjun Guo
2020-09-17  7:38 ` [PATCH 14/25] ACPI: PCI: Remove the unused " Hanjun Guo
2020-09-17  7:38 ` [PATCH 15/25] ACPI: proc: " Hanjun Guo
2020-09-17  7:38 ` [PATCH 16/25] ACPI: processor: Remove the dead " Hanjun Guo
2020-09-17  7:38 ` [PATCH 17/25] ACPI: processor: Remove the duplicated ACPI_PROCESSOR_CLASS macro Hanjun Guo
2020-09-17  7:38 ` [PATCH 18/25] ACPI: SBS: Simplify the driver init code Hanjun Guo
2020-09-17  7:38 ` [PATCH 19/25] ACPI: SBS: Simplify the code using module_acpi_driver() Hanjun Guo
2020-09-17  7:39 ` [PATCH 20/25] ACPI: tiny-power-button: Remove the dead ACPICA debug code Hanjun Guo
2020-09-17  7:39 ` [PATCH 21/25] ACPI: tiny-power-button: Simplify the code using module_acpi_driver() Hanjun Guo
2020-09-17  7:39 ` [PATCH 22/25] ACPI: video: Remove the dead ACPICA debug code Hanjun Guo
2020-09-17  7:39 ` [PATCH 23/25] ACPI: wakeup: " Hanjun Guo
2020-09-17  7:39 ` Hanjun Guo [this message]
2020-09-17  7:39 ` [PATCH RFC 25/25] ACPI: debug: Update the ACPI debug document Hanjun Guo
2020-09-17 15:08 ` [PATCH 00/25] ACPI: First step to decouple ACPICA debug functionality from ACPI driver Rafael J. Wysocki
2020-09-18  1:55   ` Hanjun Guo
2020-09-18 13:34     ` Rafael J. Wysocki
2020-09-19  7:22       ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1600328345-27627-25-git-send-email-guohanjun@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.