[Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o

From: Paolo Bonzini <1896096@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Bug 1896096] Re: Git version: Build process is broken in block_curl.c.o
Date: Sun, 20 Sep 2020 09:24:10 -0000	[thread overview]
Message-ID: <160059385018.21668.5622841215039776067.malone@wampee.canonical.com> (raw)
In-Reply-To: 160036517624.17887.51064102046414127.malonedeb@soybean.canonical.com

> But --extra-cflags="my additional compiler switch" seems to
> also add it to the link line which seems a bit odd?

That's due to LTO.  IIRC autotools do the same (after all
the linking step is a "cc" invocation), but I may be wrong.

> I wonder why you didn't just bite the bullet and go full Meson
> (à la Libvirt) and get rid of the configure script completely?

Because that would have been 8000 more lines to convert and
more bugs that would not have been caught before the merge.
The problem with having custom Makefiles is that some rebases
were horrible.  When going from 4.2 to 5.1, there were a couple
merge commits that took me one day each!  In addition, compared
to Libvirt adding new source files seemed much more common in QEMU.

Basically the conversion was merged in the "worst possible
state that can already be considered an improvement", in order
to focus on fixing bugs and progressing in the conversion,
rather than on rebases.  I must admit it was a bit worse than
expected, but as long as maintainers have not been blocked in
their work it's still more or less going according to plan.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1896096

Title:
  Git version: Build process is broken in block_curl.c.o

Status in QEMU:
  Invalid

Bug description:
  Gcc version: 10.2.0
  Glusterfs: 8.1
  Libguestfs: 1.42

  Configure options used:

  configure \
      --prefix=/usr \
      --sysconfdir=/etc \
      --localstatedir=/var \
      --libexecdir=/usr/lib/qemu \
      --extra-ldflags="$LDFLAGS" \
      --smbd=/usr/bin/smbd \
      --enable-modules \
      --enable-sdl \
      --disable-werror \
      --enable-slirp=system \
      --enable-xfsctl \
      --audio-drv-list="pa alsa sdl"

  Error log attached. Here is the beginning:

  /usr/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../lib/Scrt1.o: in function `_start':
  (.text+0x24): undefined reference to `main'
  /usr/bin/ld: libblock-curl.a(block_curl.c.o): in function `curl_block_init':

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1896096/+subscriptions