From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=lyed=C6=vger.kernel.org=stable-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 98BC0C43463
	for <stable@archiver.kernel.org>; Mon, 21 Sep 2020 11:49:32 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 5D3392145D
	for <stable@archiver.kernel.org>; Mon, 21 Sep 2020 11:49:32 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="aKFlF+6y"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726641AbgIULtb (ORCPT <rfc822;stable@archiver.kernel.org>);
        Mon, 21 Sep 2020 07:49:31 -0400
Received: from mx2.suse.de ([195.135.220.15]:56342 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726522AbgIULtb (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 21 Sep 2020 07:49:31 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1;
        t=1600688969;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:content-transfer-encoding:
         in-reply-to:in-reply-to:references:references;
        bh=3ByZHliO9xGu4qAvhF4W99RnKyoIv7qIEmoIOubJl9E=;
        b=aKFlF+6yb/YdhzNOhSNDVUm5yfH1UKsXRsN+k8RYWE7qpt3tmDXEbMwe3rPxLxX2MhXxo2
        ANl8l0XgQiL0S9W5lVb774uCyaPv/JrSQB+WKn+2GXqvpAZ+yujZKqpH0EX00yRScmit7t
        RkYCMJaHvyv6JnAHJXrU9XOvggAG5yc=
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id DEC23ACA3;
        Mon, 21 Sep 2020 11:50:05 +0000 (UTC)
Message-ID: <1600688954.2424.76.camel@suse.com>
Subject: Re: [PATCH v2] USB: cdc-acm: add Whistler radio scanners TRX series
 support
From:   Oliver Neukum <oneukum@suse.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org,
        Daniel Caujolle-Bert <f1rmb.daniel@gmail.com>,
        stable@vger.kernel.org
Date:   Mon, 21 Sep 2020 13:49:14 +0200
In-Reply-To: <20200921113601.GT24441@localhost>
References: <20200921081022.6881-1-johan@kernel.org>
         <1600677792.2424.61.camel@suse.com> <20200921093145.GS24441@localhost>
         <1600684156.2424.65.camel@suse.com> <20200921113601.GT24441@localhost>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.6 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

Am Montag, den 21.09.2020, 13:36 +0200 schrieb Johan Hovold:
> On Mon, Sep 21, 2020 at 12:29:16PM +0200, Oliver Neukum wrote:

Hi,

> I meant that instead of falling back to "combined-interface" probing we
> could assume that all interfaces with three endpoints are "combined" and
> simply ignore the union and call managementy. descriptors and all the ways
> that devices may have gotten those wrong.

I am afraid we would break the spec. I cannot recall a prohibition on
having more endpoints than necessary. Heuristics and ignoring invalid
descriptors is one things. Ignoring valid descriptors is something
else.

> I was thinking more of the individual entries in the device-id table
> whose control interfaces may not even be of the Communication class. But
> hopefully that was verified when adding them.

Now you are confusing me. In case of a quirky device, why change
the current logic?

	Regards
		Oliver