Re: [PATCH v5 00/15] Reverse debugging

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/160077693745.10249.9707329107813662236.stgit@pasha-ThinkPad-X280/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 160077693745.10249.9707329107813662236.stgit@pasha-ThinkPad-X280
Subject: [PATCH v5 00/15] Reverse debugging

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
bfcc6f4 tests/acceptance: add reverse debugging test
343ce83 replay: create temporary snapshot at debugger connection
4df10da docs: convert replay.txt to rst
67714f2 replay: describe reverse debugging in docs/replay.txt
472afd4 gdbstub: add reverse continue support in replay mode
b92fa55 gdbstub: add reverse step support in replay mode
0990f34 replay: flush rr queue before loading the vmstate
2281821 replay: implement replay-seek command
30da319 replay: introduce breakpoint at the specified step
fdb8eb0 replay: introduce info hmp/qmp command
a3d1495 qapi: introduce replay.json for record/replay-related stuff
122d3a3 migration: introduce icount field for snapshots
75fe2f9 qcow2: introduce icount field for snapshots
d44e026 replay: provide an accessor for rr filename
d9d8c65 replay: don't record interrupt poll

=== OUTPUT BEGIN ===
1/15 Checking commit d9d8c659f280 (replay: don't record interrupt poll)
2/15 Checking commit d44e026c50f1 (replay: provide an accessor for rr filename)
3/15 Checking commit 75fe2f9d5334 (qcow2: introduce icount field for snapshots)
4/15 Checking commit 122d3a303369 (migration: introduce icount field for snapshots)
ERROR: trailing whitespace
#226: FILE: tests/qemu-iotests/267.out:37:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#237: FILE: tests/qemu-iotests/267.out:48:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#248: FILE: tests/qemu-iotests/267.out:73:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#259: FILE: tests/qemu-iotests/267.out:98:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#270: FILE: tests/qemu-iotests/267.out:109:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#281: FILE: tests/qemu-iotests/267.out:123:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#292: FILE: tests/qemu-iotests/267.out:138:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#303: FILE: tests/qemu-iotests/267.out:149:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#312: FILE: tests/qemu-iotests/267.out:156:
+1         snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#323: FILE: tests/qemu-iotests/267.out:170:
+--        snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#332: FILE: tests/qemu-iotests/267.out:177:
+1         snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

ERROR: trailing whitespace
#338: FILE: tests/qemu-iotests/267.out:181:
+1         snap0                SIZE yyyy-mm-dd hh:mm:ss 00:00:00.000           $

total: 12 errors, 0 warnings, 259 lines checked

Patch 4/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/15 Checking commit a3d1495605ea (qapi: introduce replay.json for record/replay-related stuff)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93: 
new file mode 100644

total: 0 errors, 1 warnings, 78 lines checked

Patch 5/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/15 Checking commit fdb8eb04a86b (replay: introduce info hmp/qmp command)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#122: 
new file mode 100644

total: 0 errors, 1 warnings, 120 lines checked

Patch 6/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/15 Checking commit 30da319e1bf0 (replay: introduce breakpoint at the specified step)
8/15 Checking commit 22818212bd8f (replay: implement replay-seek command)
9/15 Checking commit 0990f341c806 (replay: flush rr queue before loading the vmstate)
10/15 Checking commit b92fa55d0e24 (gdbstub: add reverse step support in replay mode)
WARNING: line over 80 characters
#220: FILE: replay/replay-debugging.c:237:
+        replay_seek(replay_get_current_icount() - 1, replay_stop_vm_debug, &err);

total: 0 errors, 1 warnings, 201 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/15 Checking commit 472afd426332 (gdbstub: add reverse continue support in replay mode)
WARNING: line over 80 characters
#150: FILE: replay/replay-debugging.c:300:
+        replay_seek(replay_get_current_icount() - 1, replay_continue_stop, &err);

total: 0 errors, 1 warnings, 146 lines checked

Patch 11/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/15 Checking commit 67714f2b1ac6 (replay: describe reverse debugging in docs/replay.txt)
13/15 Checking commit 4df10da3b04d (docs: convert replay.txt to rst)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
rename from docs/replay.txt

total: 0 errors, 1 warnings, 15 lines checked

Patch 13/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/15 Checking commit 343ce83ab1d4 (replay: create temporary snapshot at debugger connection)
15/15 Checking commit bfcc6f489986 (tests/acceptance: add reverse debugging test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 215 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/160077693745.10249.9707329107813662236.stgit@pasha-ThinkPad-X280/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com