From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A6BC2D0A8 for ; Wed, 23 Sep 2020 08:55:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A26DA206C9 for ; Wed, 23 Sep 2020 08:55:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="a6aUI9n4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726784AbgIWIzx (ORCPT ); Wed, 23 Sep 2020 04:55:53 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:35014 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726244AbgIWIzx (ORCPT ); Wed, 23 Sep 2020 04:55:53 -0400 X-UUID: 2bf97a6600f943e4adc8bbc6c2fdc2ca-20200923 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NhDFo4XEQ22ht9DWcD1rv2Z1SL8D0UP7rC77FJzJezA=; b=a6aUI9n4gihndt34QAfgg9trnivH32mBxcjCYy7Wf/46W1qFe4NSGYQo9JhBkhwJzgTnh1r/dVv/VyB7I8pRechZVPHOfituOvccu4otXlQQ1OhH6dVwzFbONEqpHh78wDc1rlGuufqoDeIo2hoaXDSbMEvvjKZ7dz/lZ52cnPY=; X-UUID: 2bf97a6600f943e4adc8bbc6c2fdc2ca-20200923 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1074763504; Wed, 23 Sep 2020 16:55:48 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Sep 2020 16:55:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Sep 2020 16:55:46 +0800 Message-ID: <1600851204.21970.0.camel@mhfsdcap03> Subject: Re: [PATCH v4 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic() From: Chunfeng Yun To: Yoshihiro Shimoda CC: Mathias Nyman , Matthias Brugger , "Eric W. Biederman" , Sumit Garg , Lee Jones , "Jann Horn" , Jason Yan , Arnd Bergmann , Chuhong Yuan , "Gustavo A. R. Silva" , "Ben Dooks (Codethink)" , Saurav Girepunje , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mediatek@lists.infradead.org" , Sergei Shtylyov , Daniel Thompson , Mathias Nyman , Greg Kroah-Hartman , Felipe Balbi Date: Wed, 23 Sep 2020 16:53:24 +0800 In-Reply-To: References: <1600668815-12135-1-git-send-email-chunfeng.yun@mediatek.com> <1600668815-12135-4-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FE3AB98C311EFA98981F2CBA12670AB0267560B3D3B7CB0206D39F82BE2A85D52000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gV2VkLCAyMDIwLTA5LTIzIGF0IDA4OjQ3ICswMDAwLCBZb3NoaWhpcm8gU2hpbW9kYSB3cm90 ZToNCj4gSGkgQ2h1bmdlbmcsDQo+IA0KPiBUaGFuayB5b3UgZm9yIHRoZSBwYXRjaCENCj4gDQo+ ID4gRnJvbTogQ2h1bmZlbmcgWXVuLCBTZW50OiBNb25kYXksIFNlcHRlbWJlciAyMSwgMjAyMCAz OjEzIFBNDQo+ID4gDQo+ID4gVXNlIHJlYWRsX3BvbGxfdGltZW91dF9hdG9taWMoKSB0byBzaW1w bGlmeSBjb2RlDQo+ID4gDQo+ID4gQ2M6IE1hdGhpYXMgTnltYW4gPG1hdGhpYXMubnltYW5AbGlu dXguaW50ZWwuY29tPg0KPiA+IENjOiBZb3NoaWhpcm8gU2hpbW9kYSA8eW9zaGloaXJvLnNoaW1v ZGEudWhAcmVuZXNhcy5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTogQ2h1bmZlbmcgWXVuIDxjaHVu ZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+IHY0OiBjaGFuZ2VzDQo+ID4gICAg IDEuIHJlbW92ZSB1bm5lY2Vzc2FyeSBwYXJlbnRoZXNlcyBzdWdnZXN0ZWQgYnkgWW9zaGloaXJv DQo+ID4gICAgIDIuIGZpeCB0aGUgd3JvbmcgcmV0dXJuIHZhbHVlIHN1Z2dlc3RlZCBieSBZb3No aWhpcm8gJiBEYW5pZWwNCj4gPiANCj4gPiB2Mn52Mzogbm8gY2hhbmdlcw0KPiA+IC0tLQ0KPiA+ ICBkcml2ZXJzL3VzYi9ob3N0L3hoY2ktcmNhci5jIHwgNDMgKysrKysrKysrKysrLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgMzEgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNi L2hvc3QveGhjaS1yY2FyLmMgYi9kcml2ZXJzL3VzYi9ob3N0L3hoY2ktcmNhci5jDQo+ID4gaW5k ZXggYzEwMjVkMy4uMWJjNGZlNyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3VzYi9ob3N0L3ho Y2ktcmNhci5jDQo+ID4gKysrIGIvZHJpdmVycy91c2IvaG9zdC94aGNpLXJjYXIuYw0KPiA+IEBA IC02LDYgKzYsNyBAQA0KPiA+ICAgKi8NCj4gPiANCj4gPiAgI2luY2x1ZGUgPGxpbnV4L2Zpcm13 YXJlLmg+DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9pb3BvbGwuaD4NCj4gPiAgI2luY2x1ZGUgPGxp bnV4L21vZHVsZS5oPg0KPiA+ICAjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+DQo+ ID4gICNpbmNsdWRlIDxsaW51eC9vZi5oPg0KPiA+IEBAIC0xMjcsOCArMTI4LDcgQEAgc3RhdGlj IGludCB4aGNpX3JjYXJfZG93bmxvYWRfZmlybXdhcmUoc3RydWN0IHVzYl9oY2QgKmhjZCkNCj4g PiAgCXZvaWQgX19pb21lbSAqcmVncyA9IGhjZC0+cmVnczsNCj4gPiAgCXN0cnVjdCB4aGNpX3Bs YXRfcHJpdiAqcHJpdiA9IGhjZF90b194aGNpX3ByaXYoaGNkKTsNCj4gPiAgCWNvbnN0IHN0cnVj dCBmaXJtd2FyZSAqZnc7DQo+ID4gLQlpbnQgcmV0dmFsLCBpbmRleCwgaiwgdGltZTsNCj4gPiAt CWludCB0aW1lb3V0ID0gMTAwMDA7DQo+ID4gKwlpbnQgcmV0dmFsLCBpbmRleCwgajsNCj4gPiAg CXUzMiBkYXRhLCB2YWwsIHRlbXA7DQo+ID4gIAl1MzIgcXVpcmtzID0gMDsNCj4gPiAgCWNvbnN0 IHN0cnVjdCBzb2NfZGV2aWNlX2F0dHJpYnV0ZSAqYXR0cjsNCj4gPiBAQCAtMTY2LDMyICsxNjYs MTkgQEAgc3RhdGljIGludCB4aGNpX3JjYXJfZG93bmxvYWRfZmlybXdhcmUoc3RydWN0IHVzYl9o Y2QgKmhjZCkNCj4gPiAgCQl0ZW1wIHw9IFJDQVJfVVNCM19ETF9DVFJMX0ZXX1NFVF9EQVRBMDsN Cj4gPiAgCQl3cml0ZWwodGVtcCwgcmVncyArIFJDQVJfVVNCM19ETF9DVFJMKTsNCj4gPiANCj4g PiAtCQlmb3IgKHRpbWUgPSAwOyB0aW1lIDwgdGltZW91dDsgdGltZSsrKSB7DQo+ID4gLQkJCXZh bCA9IHJlYWRsKHJlZ3MgKyBSQ0FSX1VTQjNfRExfQ1RSTCk7DQo+ID4gLQkJCWlmICgodmFsICYg UkNBUl9VU0IzX0RMX0NUUkxfRldfU0VUX0RBVEEwKSA9PSAwKQ0KPiA+IC0JCQkJYnJlYWs7DQo+ ID4gLQkJCXVkZWxheSgxKTsNCj4gPiAtCQl9DQo+ID4gLQkJaWYgKHRpbWUgPT0gdGltZW91dCkg ew0KPiA+IC0JCQlyZXR2YWwgPSAtRVRJTUVET1VUOw0KPiA+ICsJCXJldHZhbCA9IHJlYWRsX3Bv bGxfdGltZW91dF9hdG9taWMocmVncyArIFJDQVJfVVNCM19ETF9DVFJMLA0KPiA+ICsJCQkJdmFs LCAhKHZhbCAmIFJDQVJfVVNCM19ETF9DVFJMX0ZXX1NFVF9EQVRBMCksDQo+ID4gKwkJCQkxLCAx MDAwMCk7DQo+ID4gKwkJaWYgKHJldHZhbCA8IDApDQo+ID4gIAkJCWJyZWFrOw0KPiA+IC0JCX0N Cj4gPiAgCX0NCj4gPiANCj4gPiAgCXRlbXAgPSByZWFkbChyZWdzICsgUkNBUl9VU0IzX0RMX0NU UkwpOw0KPiA+ICAJdGVtcCAmPSB+UkNBUl9VU0IzX0RMX0NUUkxfRU5BQkxFOw0KPiA+ICAJd3Jp dGVsKHRlbXAsIHJlZ3MgKyBSQ0FSX1VTQjNfRExfQ1RSTCk7DQo+ID4gDQo+ID4gLQlmb3IgKHRp bWUgPSAwOyB0aW1lIDwgdGltZW91dDsgdGltZSsrKSB7DQo+ID4gLQkJdmFsID0gcmVhZGwocmVn cyArIFJDQVJfVVNCM19ETF9DVFJMKTsNCj4gPiAtCQlpZiAodmFsICYgUkNBUl9VU0IzX0RMX0NU UkxfRldfU1VDQ0VTUykgew0KPiA+IC0JCQlyZXR2YWwgPSAwOw0KPiA+IC0JCQlicmVhazsNCj4g PiAtCQl9DQo+ID4gLQkJdWRlbGF5KDEpOw0KPiA+IC0JfQ0KPiA+IC0JaWYgKHRpbWUgPT0gdGlt ZW91dCkNCj4gPiAtCQlyZXR2YWwgPSAtRVRJTUVET1VUOw0KPiA+ICsJcmV0dmFsID0gcmVhZGxf cG9sbF90aW1lb3V0X2F0b21pYygocmVncyArIFJDQVJfVVNCM19ETF9DVFJMKSwNCj4gDQo+IFdl IGNhbiBhbHNvIHJlbW92ZSB0aGVzZSB1bm5lY2Vzc2FyeSBwYXJlbnRoZXNlcyBsaWtlIGJlbG93 Lg0KT2ssIHdpbGwgcmVtb3ZlIGl0LCB0aGFua3MgYSBsb3QNCg0KPiANCj4gKwlyZXR2YWwgPSBy ZWFkbF9wb2xsX3RpbWVvdXRfYXRvbWljKHJlZ3MgKyBSQ0FSX1VTQjNfRExfQ1RSTCwNCj4gDQo+ IEFmdGVyIGZpeGVkIHRoaXM6DQo+IA0KPiBSZXZpZXdlZC1ieTogWW9zaGloaXJvIFNoaW1vZGEg PHlvc2hpaGlyby5zaGltb2RhLnVoQHJlbmVzYXMuY29tPg0KPiANCj4gQmVzdCByZWdhcmRzLA0K PiBZb3NoaWhpcm8gU2hpbW9kYQ0KPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AC2FC2D0A8 for ; Wed, 23 Sep 2020 08:56:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF5A7206C9 for ; Wed, 23 Sep 2020 08:56:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y8o5Xier"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Mkyc7HvH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF5A7206C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z5vnn3W6QjifBTdKBpyNTxOIrdRyCTeT4bpJeylI9Gw=; b=Y8o5Xierm/EVOACzwzotaDfLw haawsTovUwZ0QFyH7JSoEinZaFDgVvwAQtC1rTh/M4aiFnPb42MbWd1l0Yn/glShwWb/7jVNVLImc xFvaVz7QF1EkoBK3IyFzpD3HuhWh8CZCR8HL+a95qiuYCnXFAyAzpQx6Ma4Fv8qEHo8pNTqE0fw7j 6vaFzUz8MbHxZyVFnrz2mHg0VTOCH8EJxR2wscXgu56rWrA1++qzn0nNpdtlKwX4vVFJFXZNTt+CX rPM0CDce0Hx51c5Uou6AND8bHednm2Jq3tATSsf3TMtzbxF4DGnZKu+UGpERD8qvdjv7NwPBeb0gr YUwe1R8Hw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL0ZL-0002f0-0U; Wed, 23 Sep 2020 08:56:07 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL0ZG-0002cZ-2U; Wed, 23 Sep 2020 08:56:04 +0000 X-UUID: fb480d1ffb6f419f953ad6a6ea120fa9-20200923 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NhDFo4XEQ22ht9DWcD1rv2Z1SL8D0UP7rC77FJzJezA=; b=Mkyc7HvHouBd7qmDGDL4oDUnaXvMFYNbv1JjKb/i9JhpF/z1QRn3INYtwCiD27tBsVMwC8p1i0a6mrTvEoXbsk8NZzSDHRLB7b0vPFxL3KPkmzGBZdLfHjd62DALKadN3KgG3DoaoPmMLJQz2jRGyB7DNS5EY0Kzr538qsDsRqQ=; X-UUID: fb480d1ffb6f419f953ad6a6ea120fa9-20200923 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1053516855; Wed, 23 Sep 2020 00:55:51 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Sep 2020 01:55:49 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Sep 2020 16:55:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Sep 2020 16:55:46 +0800 Message-ID: <1600851204.21970.0.camel@mhfsdcap03> Subject: Re: [PATCH v4 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic() From: Chunfeng Yun To: Yoshihiro Shimoda Date: Wed, 23 Sep 2020 16:53:24 +0800 In-Reply-To: References: <1600668815-12135-1-git-send-email-chunfeng.yun@mediatek.com> <1600668815-12135-4-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FE3AB98C311EFA98981F2CBA12670AB0267560B3D3B7CB0206D39F82BE2A85D52000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_045602_273143_8792D65A X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Daniel Thompson , "linux-usb@vger.kernel.org" , Mathias Nyman , Arnd Bergmann , Mathias Nyman , Jann Horn , Greg Kroah-Hartman , Jason Yan , Chuhong Yuan , "Gustavo A. R. Silva" , "linux-kernel@vger.kernel.org" , Saurav Girepunje , "Ben Dooks \(Codethink\)" , "linux-mediatek@lists.infradead.org" , "Eric W. Biederman" , Matthias Brugger , Lee Jones , Sergei Shtylyov , "linux-arm-kernel@lists.infradead.org" , Felipe Balbi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2020-09-23 at 08:47 +0000, Yoshihiro Shimoda wrote: > Hi Chungeng, > > Thank you for the patch! > > > From: Chunfeng Yun, Sent: Monday, September 21, 2020 3:13 PM > > > > Use readl_poll_timeout_atomic() to simplify code > > > > Cc: Mathias Nyman > > Cc: Yoshihiro Shimoda > > Signed-off-by: Chunfeng Yun > > --- > > v4: changes > > 1. remove unnecessary parentheses suggested by Yoshihiro > > 2. fix the wrong return value suggested by Yoshihiro & Daniel > > > > v2~v3: no changes > > --- > > drivers/usb/host/xhci-rcar.c | 43 ++++++++++++------------------------------- > > 1 file changed, 12 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c > > index c1025d3..1bc4fe7 100644 > > --- a/drivers/usb/host/xhci-rcar.c > > +++ b/drivers/usb/host/xhci-rcar.c > > @@ -6,6 +6,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -127,8 +128,7 @@ static int xhci_rcar_download_firmware(struct usb_hcd *hcd) > > void __iomem *regs = hcd->regs; > > struct xhci_plat_priv *priv = hcd_to_xhci_priv(hcd); > > const struct firmware *fw; > > - int retval, index, j, time; > > - int timeout = 10000; > > + int retval, index, j; > > u32 data, val, temp; > > u32 quirks = 0; > > const struct soc_device_attribute *attr; > > @@ -166,32 +166,19 @@ static int xhci_rcar_download_firmware(struct usb_hcd *hcd) > > temp |= RCAR_USB3_DL_CTRL_FW_SET_DATA0; > > writel(temp, regs + RCAR_USB3_DL_CTRL); > > > > - for (time = 0; time < timeout; time++) { > > - val = readl(regs + RCAR_USB3_DL_CTRL); > > - if ((val & RCAR_USB3_DL_CTRL_FW_SET_DATA0) == 0) > > - break; > > - udelay(1); > > - } > > - if (time == timeout) { > > - retval = -ETIMEDOUT; > > + retval = readl_poll_timeout_atomic(regs + RCAR_USB3_DL_CTRL, > > + val, !(val & RCAR_USB3_DL_CTRL_FW_SET_DATA0), > > + 1, 10000); > > + if (retval < 0) > > break; > > - } > > } > > > > temp = readl(regs + RCAR_USB3_DL_CTRL); > > temp &= ~RCAR_USB3_DL_CTRL_ENABLE; > > writel(temp, regs + RCAR_USB3_DL_CTRL); > > > > - for (time = 0; time < timeout; time++) { > > - val = readl(regs + RCAR_USB3_DL_CTRL); > > - if (val & RCAR_USB3_DL_CTRL_FW_SUCCESS) { > > - retval = 0; > > - break; > > - } > > - udelay(1); > > - } > > - if (time == timeout) > > - retval = -ETIMEDOUT; > > + retval = readl_poll_timeout_atomic((regs + RCAR_USB3_DL_CTRL), > > We can also remove these unnecessary parentheses like below. Ok, will remove it, thanks a lot > > + retval = readl_poll_timeout_atomic(regs + RCAR_USB3_DL_CTRL, > > After fixed this: > > Reviewed-by: Yoshihiro Shimoda > > Best regards, > Yoshihiro Shimoda > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 056B6C4727D for ; Wed, 23 Sep 2020 08:57:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6FE2206C9 for ; Wed, 23 Sep 2020 08:57:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="z1//zCkn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Mkyc7HvH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6FE2206C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9NQQJFsLVPmDTdJNx42NFNgyuhZiccCqkt4qzHbYA4A=; b=z1//zCknBok5yzd/O0OvayJ5d yvA5Qi83dVqjUdsYyZW1mn+9qbhRv0BHoLDUQZQgEuOKzCCfshR4xWQXbARgsrYg5syAmkRxS1xwP 60a5ZDJw+Z3MKBd69tDwxVdcSYyKWwt1a2wL3ncD25xqdjgX7JojHXIqJdxnw4VzUUWWOB/R9/BQQ FmTIi6ai6KYQo/6DoA7PsoyTDn0vbPliTFsJ4LHhFe+24o999IwywWekocLJEW/qIM7V25MpbH3Lk 7oFflAt7iReqCeuXarJb7upMrsDSNFTlEhNrjhCLyFFBUhYdFaOZeZoTCLCMnrgO/pf17QGv01Pf0 wKXCgFfbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL0ZJ-0002eh-MO; Wed, 23 Sep 2020 08:56:05 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kL0ZG-0002cZ-2U; Wed, 23 Sep 2020 08:56:04 +0000 X-UUID: fb480d1ffb6f419f953ad6a6ea120fa9-20200923 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NhDFo4XEQ22ht9DWcD1rv2Z1SL8D0UP7rC77FJzJezA=; b=Mkyc7HvHouBd7qmDGDL4oDUnaXvMFYNbv1JjKb/i9JhpF/z1QRn3INYtwCiD27tBsVMwC8p1i0a6mrTvEoXbsk8NZzSDHRLB7b0vPFxL3KPkmzGBZdLfHjd62DALKadN3KgG3DoaoPmMLJQz2jRGyB7DNS5EY0Kzr538qsDsRqQ=; X-UUID: fb480d1ffb6f419f953ad6a6ea120fa9-20200923 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1053516855; Wed, 23 Sep 2020 00:55:51 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Sep 2020 01:55:49 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Sep 2020 16:55:45 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 23 Sep 2020 16:55:46 +0800 Message-ID: <1600851204.21970.0.camel@mhfsdcap03> Subject: Re: [PATCH v4 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic() From: Chunfeng Yun To: Yoshihiro Shimoda Date: Wed, 23 Sep 2020 16:53:24 +0800 In-Reply-To: References: <1600668815-12135-1-git-send-email-chunfeng.yun@mediatek.com> <1600668815-12135-4-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: FE3AB98C311EFA98981F2CBA12670AB0267560B3D3B7CB0206D39F82BE2A85D52000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_045602_273143_8792D65A X-CRM114-Status: GOOD ( 25.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Daniel Thompson , "linux-usb@vger.kernel.org" , Mathias Nyman , Arnd Bergmann , Mathias Nyman , Jann Horn , Greg Kroah-Hartman , Jason Yan , Chuhong Yuan , "Gustavo A. R. Silva" , "linux-kernel@vger.kernel.org" , Saurav Girepunje , "Ben Dooks \(Codethink\)" , "linux-mediatek@lists.infradead.org" , "Eric W. Biederman" , Matthias Brugger , Lee Jones , Sergei Shtylyov , "linux-arm-kernel@lists.infradead.org" , Felipe Balbi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-09-23 at 08:47 +0000, Yoshihiro Shimoda wrote: > Hi Chungeng, > > Thank you for the patch! > > > From: Chunfeng Yun, Sent: Monday, September 21, 2020 3:13 PM > > > > Use readl_poll_timeout_atomic() to simplify code > > > > Cc: Mathias Nyman > > Cc: Yoshihiro Shimoda > > Signed-off-by: Chunfeng Yun > > --- > > v4: changes > > 1. remove unnecessary parentheses suggested by Yoshihiro > > 2. fix the wrong return value suggested by Yoshihiro & Daniel > > > > v2~v3: no changes > > --- > > drivers/usb/host/xhci-rcar.c | 43 ++++++++++++------------------------------- > > 1 file changed, 12 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/usb/host/xhci-rcar.c b/drivers/usb/host/xhci-rcar.c > > index c1025d3..1bc4fe7 100644 > > --- a/drivers/usb/host/xhci-rcar.c > > +++ b/drivers/usb/host/xhci-rcar.c > > @@ -6,6 +6,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -127,8 +128,7 @@ static int xhci_rcar_download_firmware(struct usb_hcd *hcd) > > void __iomem *regs = hcd->regs; > > struct xhci_plat_priv *priv = hcd_to_xhci_priv(hcd); > > const struct firmware *fw; > > - int retval, index, j, time; > > - int timeout = 10000; > > + int retval, index, j; > > u32 data, val, temp; > > u32 quirks = 0; > > const struct soc_device_attribute *attr; > > @@ -166,32 +166,19 @@ static int xhci_rcar_download_firmware(struct usb_hcd *hcd) > > temp |= RCAR_USB3_DL_CTRL_FW_SET_DATA0; > > writel(temp, regs + RCAR_USB3_DL_CTRL); > > > > - for (time = 0; time < timeout; time++) { > > - val = readl(regs + RCAR_USB3_DL_CTRL); > > - if ((val & RCAR_USB3_DL_CTRL_FW_SET_DATA0) == 0) > > - break; > > - udelay(1); > > - } > > - if (time == timeout) { > > - retval = -ETIMEDOUT; > > + retval = readl_poll_timeout_atomic(regs + RCAR_USB3_DL_CTRL, > > + val, !(val & RCAR_USB3_DL_CTRL_FW_SET_DATA0), > > + 1, 10000); > > + if (retval < 0) > > break; > > - } > > } > > > > temp = readl(regs + RCAR_USB3_DL_CTRL); > > temp &= ~RCAR_USB3_DL_CTRL_ENABLE; > > writel(temp, regs + RCAR_USB3_DL_CTRL); > > > > - for (time = 0; time < timeout; time++) { > > - val = readl(regs + RCAR_USB3_DL_CTRL); > > - if (val & RCAR_USB3_DL_CTRL_FW_SUCCESS) { > > - retval = 0; > > - break; > > - } > > - udelay(1); > > - } > > - if (time == timeout) > > - retval = -ETIMEDOUT; > > + retval = readl_poll_timeout_atomic((regs + RCAR_USB3_DL_CTRL), > > We can also remove these unnecessary parentheses like below. Ok, will remove it, thanks a lot > > + retval = readl_poll_timeout_atomic(regs + RCAR_USB3_DL_CTRL, > > After fixed this: > > Reviewed-by: Yoshihiro Shimoda > > Best regards, > Yoshihiro Shimoda > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel