All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-08-20 11:22 ` Hanks Chen
  0 siblings, 0 replies; 12+ messages in thread
From: Hanks Chen @ 2020-08-20 11:22 UTC (permalink / raw)
  To: Sean Wang, Linus Walleij, Matthias Brugger
  Cc: linux-mediatek, linux-gpio, linux-arm-kernel, linux-kernel,
	CC Hwang, sin_jieyang, Hanks Chen

check mtk_is_virt_gpio input parameter,
virtual gpio need to support eint mode.

add error handler for the ko case
to fix this boot fail:
pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]

Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>

---
Changes since v1:
- update Singed-off-by
- align with pinctrl/mediatek/pinctrl-mtk-mt*.h 

---
 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index c53e2c391e32..a485d79f51a1 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
 
 	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
 
+	/* if the GPIO is not supported for eint mode */
+	if (desc->eint.eint_m == NO_EINT_SUPPORT)
+		return virt_gpio;
+
 	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
 		virt_gpio = true;
 
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-08-20 11:22 ` Hanks Chen
  0 siblings, 0 replies; 12+ messages in thread
From: Hanks Chen @ 2020-08-20 11:22 UTC (permalink / raw)
  To: Sean Wang, Linus Walleij, Matthias Brugger
  Cc: CC Hwang, sin_jieyang, Hanks Chen, linux-kernel, linux-gpio,
	linux-mediatek, linux-arm-kernel

check mtk_is_virt_gpio input parameter,
virtual gpio need to support eint mode.

add error handler for the ko case
to fix this boot fail:
pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]

Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>

---
Changes since v1:
- update Singed-off-by
- align with pinctrl/mediatek/pinctrl-mtk-mt*.h 

---
 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index c53e2c391e32..a485d79f51a1 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
 
 	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
 
+	/* if the GPIO is not supported for eint mode */
+	if (desc->eint.eint_m == NO_EINT_SUPPORT)
+		return virt_gpio;
+
 	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
 		virt_gpio = true;
 
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-08-20 11:22 ` Hanks Chen
  0 siblings, 0 replies; 12+ messages in thread
From: Hanks Chen @ 2020-08-20 11:22 UTC (permalink / raw)
  To: Sean Wang, Linus Walleij, Matthias Brugger
  Cc: CC Hwang, sin_jieyang, Hanks Chen, linux-kernel, linux-gpio,
	linux-mediatek, linux-arm-kernel

check mtk_is_virt_gpio input parameter,
virtual gpio need to support eint mode.

add error handler for the ko case
to fix this boot fail:
pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]

Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>

---
Changes since v1:
- update Singed-off-by
- align with pinctrl/mediatek/pinctrl-mtk-mt*.h 

---
 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index c53e2c391e32..a485d79f51a1 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
 
 	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
 
+	/* if the GPIO is not supported for eint mode */
+	if (desc->eint.eint_m == NO_EINT_SUPPORT)
+		return virt_gpio;
+
 	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
 		virt_gpio = true;
 
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
  2020-08-20 11:22 ` Hanks Chen
  (?)
@ 2020-09-25 12:50   ` Hanks Chen
  -1 siblings, 0 replies; 12+ messages in thread
From: Hanks Chen @ 2020-09-25 12:50 UTC (permalink / raw)
  To: Sean Wang, Matthias Brugger, Linus Walleij
  Cc: Linus Walleij, Matthias Brugger, linux-mediatek, linux-gpio,
	linux-arm-kernel, linux-kernel, CC Hwang, sin_jieyang

Hi Sean & Linux & Matthias,

Please kindly let me know your comments about this fixes patch.
Thanks

Regards,
Hanks


On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
> 
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> 
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> 
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h 
> 
> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index c53e2c391e32..a485d79f51a1 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
>  
>  	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
>  
> +	/* if the GPIO is not supported for eint mode */
> +	if (desc->eint.eint_m == NO_EINT_SUPPORT)
> +		return virt_gpio;
> +
>  	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
>  		virt_gpio = true;
>  


^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-09-25 12:50   ` Hanks Chen
  0 siblings, 0 replies; 12+ messages in thread
From: Hanks Chen @ 2020-09-25 12:50 UTC (permalink / raw)
  To: Sean Wang, Matthias Brugger, Linus Walleij
  Cc: CC Hwang, sin_jieyang, Linus Walleij, linux-kernel, linux-gpio,
	linux-mediatek, Matthias Brugger, linux-arm-kernel

Hi Sean & Linux & Matthias,

Please kindly let me know your comments about this fixes patch.
Thanks

Regards,
Hanks


On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
> 
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> 
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> 
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h 
> 
> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index c53e2c391e32..a485d79f51a1 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
>  
>  	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
>  
> +	/* if the GPIO is not supported for eint mode */
> +	if (desc->eint.eint_m == NO_EINT_SUPPORT)
> +		return virt_gpio;
> +
>  	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
>  		virt_gpio = true;
>  

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-09-25 12:50   ` Hanks Chen
  0 siblings, 0 replies; 12+ messages in thread
From: Hanks Chen @ 2020-09-25 12:50 UTC (permalink / raw)
  To: Sean Wang, Matthias Brugger, Linus Walleij
  Cc: CC Hwang, sin_jieyang, Linus Walleij, linux-kernel, linux-gpio,
	linux-mediatek, Matthias Brugger, linux-arm-kernel

Hi Sean & Linux & Matthias,

Please kindly let me know your comments about this fixes patch.
Thanks

Regards,
Hanks


On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
> 
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> 
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> 
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h 
> 
> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index c53e2c391e32..a485d79f51a1 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
>  
>  	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
>  
> +	/* if the GPIO is not supported for eint mode */
> +	if (desc->eint.eint_m == NO_EINT_SUPPORT)
> +		return virt_gpio;
> +
>  	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
>  		virt_gpio = true;
>  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
  2020-09-25 12:50   ` Hanks Chen
  (?)
@ 2020-09-27 18:07     ` Sean Wang
  -1 siblings, 0 replies; 12+ messages in thread
From: Sean Wang @ 2020-09-27 18:07 UTC (permalink / raw)
  To: Hanks Chen
  Cc: Matthias Brugger, Linus Walleij,
	moderated list:ARM/Mediatek SoC support,
	open list:GPIO SUBSYSTEM, linux-arm Mailing List, lkml, CC Hwang,
	sin_jieyang

On Fri, Sep 25, 2020 at 5:51 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
>
> Hi Sean & Linux & Matthias,
>
> Please kindly let me know your comments about this fixes patch.
> Thanks
>

Acked-by: Sean Wang <sean.wang@kernel.org>

> Regards,
> Hanks
>
>
> On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> > check mtk_is_virt_gpio input parameter,
> > virtual gpio need to support eint mode.
> >
> > add error handler for the ko case
> > to fix this boot fail:
> > pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> > lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> >
> > Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> > Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> >
> > ---
> > Changes since v1:
> > - update Singed-off-by
> > - align with pinctrl/mediatek/pinctrl-mtk-mt*.h
> >
> > ---
> >  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index c53e2c391e32..a485d79f51a1 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
> >
> >       desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
> >
> > +     /* if the GPIO is not supported for eint mode */
> > +     if (desc->eint.eint_m == NO_EINT_SUPPORT)
> > +             return virt_gpio;
> > +
> >       if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
> >               virt_gpio = true;
> >
>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-09-27 18:07     ` Sean Wang
  0 siblings, 0 replies; 12+ messages in thread
From: Sean Wang @ 2020-09-27 18:07 UTC (permalink / raw)
  To: Hanks Chen
  Cc: CC Hwang, sin_jieyang, Linus Walleij, lkml,
	open list:GPIO SUBSYSTEM,
	moderated list:ARM/Mediatek SoC support, Matthias Brugger,
	linux-arm Mailing List

On Fri, Sep 25, 2020 at 5:51 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
>
> Hi Sean & Linux & Matthias,
>
> Please kindly let me know your comments about this fixes patch.
> Thanks
>

Acked-by: Sean Wang <sean.wang@kernel.org>

> Regards,
> Hanks
>
>
> On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> > check mtk_is_virt_gpio input parameter,
> > virtual gpio need to support eint mode.
> >
> > add error handler for the ko case
> > to fix this boot fail:
> > pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> > lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> >
> > Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> > Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> >
> > ---
> > Changes since v1:
> > - update Singed-off-by
> > - align with pinctrl/mediatek/pinctrl-mtk-mt*.h
> >
> > ---
> >  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index c53e2c391e32..a485d79f51a1 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
> >
> >       desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
> >
> > +     /* if the GPIO is not supported for eint mode */
> > +     if (desc->eint.eint_m == NO_EINT_SUPPORT)
> > +             return virt_gpio;
> > +
> >       if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
> >               virt_gpio = true;
> >
>

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-09-27 18:07     ` Sean Wang
  0 siblings, 0 replies; 12+ messages in thread
From: Sean Wang @ 2020-09-27 18:07 UTC (permalink / raw)
  To: Hanks Chen
  Cc: CC Hwang, sin_jieyang, Linus Walleij, lkml,
	open list:GPIO SUBSYSTEM,
	moderated list:ARM/Mediatek SoC support, Matthias Brugger,
	linux-arm Mailing List

On Fri, Sep 25, 2020 at 5:51 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
>
> Hi Sean & Linux & Matthias,
>
> Please kindly let me know your comments about this fixes patch.
> Thanks
>

Acked-by: Sean Wang <sean.wang@kernel.org>

> Regards,
> Hanks
>
>
> On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> > check mtk_is_virt_gpio input parameter,
> > virtual gpio need to support eint mode.
> >
> > add error handler for the ko case
> > to fix this boot fail:
> > pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> > lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> >
> > Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> > Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> >
> > ---
> > Changes since v1:
> > - update Singed-off-by
> > - align with pinctrl/mediatek/pinctrl-mtk-mt*.h
> >
> > ---
> >  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index c53e2c391e32..a485d79f51a1 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
> >
> >       desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
> >
> > +     /* if the GPIO is not supported for eint mode */
> > +     if (desc->eint.eint_m == NO_EINT_SUPPORT)
> > +             return virt_gpio;
> > +
> >       if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
> >               virt_gpio = true;
> >
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
  2020-08-20 11:22 ` Hanks Chen
  (?)
@ 2020-09-30  8:48   ` Linus Walleij
  -1 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2020-09-30  8:48 UTC (permalink / raw)
  To: Hanks Chen
  Cc: Sean Wang, Matthias Brugger,
	moderated list:ARM/Mediatek SoC support,
	open list:GPIO SUBSYSTEM, Linux ARM, linux-kernel, CC Hwang,
	sin_jieyang

On Thu, Aug 20, 2020 at 1:22 PM Hanks Chen <hanks.chen@mediatek.com> wrote:

> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
>
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
>
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
>
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-09-30  8:48   ` Linus Walleij
  0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2020-09-30  8:48 UTC (permalink / raw)
  To: Hanks Chen
  Cc: CC Hwang, sin_jieyang, Sean Wang, linux-kernel,
	open list:GPIO SUBSYSTEM,
	moderated list:ARM/Mediatek SoC support, Matthias Brugger,
	Linux ARM

On Thu, Aug 20, 2020 at 1:22 PM Hanks Chen <hanks.chen@mediatek.com> wrote:

> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
>
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
>
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
>
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h

Patch applied.

Yours,
Linus Walleij

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 12+ messages in thread
* Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter
@ 2020-09-30  8:48   ` Linus Walleij
  0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2020-09-30  8:48 UTC (permalink / raw)
  To: Hanks Chen
  Cc: CC Hwang, sin_jieyang, Sean Wang, linux-kernel,
	open list:GPIO SUBSYSTEM,
	moderated list:ARM/Mediatek SoC support, Matthias Brugger,
	Linux ARM

On Thu, Aug 20, 2020 at 1:22 PM Hanks Chen <hanks.chen@mediatek.com> wrote:

> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
>
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
>
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@mediatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
>
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h

Patch applied.

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-09-30  8:50 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20 11:22 [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input parameter Hanks Chen
2020-08-20 11:22 ` Hanks Chen
2020-08-20 11:22 ` Hanks Chen
2020-09-25 12:50 ` Hanks Chen
2020-09-25 12:50   ` Hanks Chen
2020-09-25 12:50   ` Hanks Chen
2020-09-27 18:07   ` Sean Wang
2020-09-27 18:07     ` Sean Wang
2020-09-27 18:07     ` Sean Wang
2020-09-30  8:48 ` Linus Walleij
2020-09-30  8:48   ` Linus Walleij
2020-09-30  8:48   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.